[Xorp-hackers] Rtrmgr start without config.boot

Mark Handley M.Handley@cs.ucl.ac.uk
Sat, 15 Oct 2005 21:44:43 +0100


I looked at your patch.  I think we need to discuss what it is we actually want.

There are a number of reasons why the read_file might fail, including:

 - the file doesn't exist.
 - the file isn't readable.
 - the directory isn't executable.

Do we want the rtrmgr to start in all three cases?  I think the last
two should probably be fatal errors, because something is badly
broken, and you want to force the user to fix it.  In the case of the
file not being readable, there is also the possibility that it *is*
writable.  So continuing would be very weird in that case, as you'd be
able to save without an error, but never able to load the config you
saved.

In the case where the file doesn't exist, should we create the file at
this point?  Then at least there is a config file that matches the
running config.  Or should we only do this on an explicit save?  I
think we should probably create it - best do that, rather than
discover a permissions problem later when the user has typed in a long
config.  But what then should happen if the create failed?  Probably
we'd want a warning on the xorpsh when a new xorpsh first connects.

Anyway, I'd like feedback on this before committing any changes.

 - Mark

On 10/15/05, Kristian Larsson <kristian@juniks.net> wrote:
> Hey everybody :)
>
> Right now the rtrmgr won't start without a
> configraution file and this doesn't go well with my
> rtrmgr-should-always-start-no-matter-what-policy ;)
> Seriously though, isn't a warning message enough?
> I mean you touch the file and xorp starts, no one
> bothers actually writing a correct configuration
> file.
>
> I've created a bug and a patch for it on the
> BugZilla for everyones evaluation :)
>
>   Kristian.
> _______________________________________________
> Xorp-hackers mailing list
> Xorp-hackers@icir.org
> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers
>
>