[Xorp-hackers] Tiny patch to detect missing operators to prevent logic error / unreachable code crash

Marat Nepomnyashy marat at vyatta.com
Mon Jul 3 16:33:57 PDT 2006


Hi Pavlin,

Please consider the attached patch for inclusion.

Patch prevents an unreachable code crash in file rtrmgr/config_operators.cc 
method operator_to_str(...).

Patch modifies file rtrmgr/template_base_command.cc, method 
AllowOperatorsCommand::verify_variables(...), that is shallower in the call 
stack from where the crash occurs, to return false when the ConfigOperator 
is OP_NONE, signaling that the configuration node is not valid and 
preventing the execution from reaching the point of crash.

Thanks,
Marat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-check-operator-01
Type: application/octet-stream
Size: 464 bytes
Desc: not available
Url : http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-hackers/attachments/20060703/90f59469/attachment.obj 


More information about the Xorp-hackers mailing list