[Xorp-hackers] Tiny patch to detect missing operators to prevent logic error / unreachable code crash

Pavlin Radoslavov pavlin at icir.org
Mon Jul 3 16:47:39 PDT 2006


> Please consider the attached patch for inclusion.
> 
> Patch prevents an unreachable code crash in file rtrmgr/config_operators.cc
> method operator_to_str(...).
> 
> Patch modifies file rtrmgr/template_base_command.cc, method
> AllowOperatorsCommand::verify_variables(...), that is shallower in the call
> stack from where the crash occurs, to return false when the ConfigOperator is
> OP_NONE, signaling that the configuration node is not valid and preventing the
> execution from reaching the point of crash.

Marat,

Could you send the traceback stack from the coredump and
instructions how to reproduce the crash.

It looks like probably there is another problem somewhere else, and
applying this patch might mask that problem.

Thanks,
Pavlin



More information about the Xorp-hackers mailing list