[Xorp-hackers] Patch to add method SlaveConfigTreeNode::set_segname(...)

[Marat Nepomnyashy]

Hi Pavlin,

This method is intended for setting or changing the name of a newly created 
multi-node.  After creating them, I either set the value if it is a regular 
node, or the name if it is a multi-node.  Multi-nodes being added  that have 
not yet been committed can also have their name changed without having to 
recreate their child nodes.

-- Marat

----- Original Message ----- 
From: "Pavlin Radoslavov" <pavlin@icir.org>
To: "Marat Nepomnyashy" <marat@vyatta.com>
Cc: "Pavlin Radoslavov" <pavlin@icir.org>; <xorp-hackers@xorp.org>
Sent: Thursday, March 09, 2006 6:02 PM
Subject: Re: [Xorp-hackers] Patch to add method 
SlaveConfigTreeNode::set_segname(...)


>> Please consider the attached patch file for integration into XORP.  It
>> adds a convenience method SlaveConfigTreeNode::set_segname(...) to
>> /rtrmgr/slave_conf_tree_node.hh
>>
>> I'm using this method to set the name of a multi-node
>> SlaveConfigTreeNode after I create it.
>
> Marat,
>
> Why is the segname of a child allowed to change?
> It should be assigned when the node is created and shouldn't change
> after that.
> If the only time you need to set the segname is when you create the
> node, then it should be added as an argument to the appropriate
> constructor.
>
> Pavlin
> _______________________________________________
> Xorp-hackers mailing list
> Xorp-hackers@icir.org
> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers