[Xorp-hackers] Possible fix for XORP bug 603

Pavlin Radoslavov pavlin at icir.org
Mon May 1 14:46:09 PDT 2006


> > Just don't do it please :)
> > 
> > * Global variables are bad and should be avoid unless there is no
> >   other solution.
> > 
> > * The patch introduces an "interesting" dependency: the libcli
> >   library becomes dependent on the xorpsh/rtrmgr code.
> > 
> > * The real problem was somewhere else and the bogus command-line
> >   completion for the "show ospf4" command was a side effect of that
> >   problem. This problem is now fixed in CVS.
> >   See XORP Bugzilla entry #603 for details:
> >   http://www.xorp.org/bugzilla/show_bug.cgi?id=603
> 
> The fix to ospfv2.cmds fixes the specific case, but unfortunately
> not the general case.
> 
> Template entries of the form
> 
> cmd opt1 opt2 {
> }
> 
> where both opt1 and opt2 must be specified end up with "cmd opt1"
> being marked as valid in help, even though it's not executable.

Indeed.
The problem is now fixed in CVS:

1.66      +34 -10;  commitid: e8ed44567dd27ea6; xorp/rtrmgr/op_commands.cc

> There are also issues with configuration templates; I'll need to come
> up with specific examples for both.

Yes please.

Thanks,
Pavlin



More information about the Xorp-hackers mailing list