[Xorp-hackers] Patch for TCP over XRL fixes + libcomm api changes

Tim Schooley t.schooley at cs.ucl.ac.uk
Mon Mar 26 11:29:23 PDT 2007


Hi all,

Please find attached a patch for the current Xorp CVS root, with the 
following notable changes:

- TCP over XRL
     - Added a few new functions to the TCP socket{4,6} XRL interfaces:
       tcp_listen and {tcp,udp}_open. These allow more atomic operations
       for socket setup.
     - Finished off the TCP relay code within fea/xrl_socket_*, and
       added test code for it (see fea/test_xrl_sockets4_tcp.*). Updated
       Jamfile and Makefile.am accordingly.
- libcomm
     - Modified the libcomm api, found in libcomm/comm_api.h. Binding a
       socket with comm_bind_tcp no longer implicitly call listen. This
       is now done explicitly in comm_listen. All code affected by this
       change within the Xorp source tree has also been updated.

The patch has been tested on Linux (2.6), and FreeBSD 6.1-RELEASE.

To apply the patch, place it in the root directory of the Xorp source, 
patch with -p0, chmod 755 fea/test_xrl_sockets4_tcp.sh, bootstrap, 
configure, and compile. The patch can also be found at 
http://midget.evilbyte.org/fea_xrl_socket_tcp_patch_03-26-07.diff

I welcome all comments/concerns/criticism! And if anyone could test this 
on windows, I'd be most grateful.

Once I get CVS access, I should be committing this code to the 
repository, along with any required changes that might be pointed out. I 
should imagine a fair number of changes will be needed in 3rd party code 
that uses libcomm, although the changes will be tiny.

Kind regards,

Tim
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fea_xrl_socket_tcp_patch_03-26-07.diff
Url: http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-hackers/attachments/20070326/54b7ffa1/attachment-0001.ksh 


More information about the Xorp-hackers mailing list