[Xorp-hackers] Some patches for various things.

Ben Greear greearb at candelatech.com
Thu Oct 4 08:36:13 PDT 2007


Pavlin Radoslavov wrote:
> Ben Greear <greearb at candelatech.com> wrote:
>
>   
>> Here are some more small patches.  At some time during the last
>> few weeks I added these to try to work around problems related to
>> dynamically adding/deleting interfaces & ospf configuration.  It's
>> possible subsequent fixes from Xorp developers have made these un-needed.
>>
>>
>> Treat a duplicate remove as OK instead of an error.
>> This fixed some problem with reloading config files...
>>
>> RCS file: /cvs/xorp/fea/iftree.cc,v
>> retrieving revision 1.51
>> diff -u -r1.51 iftree.cc
>> --- fea/iftree.cc	27 Sep 2007 00:33:33 -0000	1.51
>> +++ fea/iftree.cc	3 Oct 2007 23:08:13 -0000
>> @@ -1079,7 +1079,7 @@
>>       IfTreeAddr4* ap = find_addr(addr);
>>
>>       if (ap == NULL)
>> -	return (XORP_ERROR);
>> +	return XORP_OK; // Already deleted it seems... (XORP_ERROR);
>>       ap->mark(DELETED);
>>       return (XORP_OK);
>>   }
>>     
>
> This is a question of semantics. Currently, trying to delete an IfTree
> item (interface, vif and IP address) that doesn't exist is
> considered an error. Some of the usage of this is to capture
> errors/bugs elsewhere in the code.
>
> Could you send instructions how to replicate the problem with
> reloading config files. Only then we can debug the issue and see
> whether the real problem is somewhere else or whether it really
> requires change of semantics.
> Yes, there were some recent fixes to the FEA regarding modifying the
> interface configuration, but there are no guarantees they actually
> addressed the problem you had seen before.
>   
Ok, I'll back this out and re-run my tests to see if it still errors out.
>
> The reason the log message has the format "+line file" is that you
> can cut-and-paste and open directly the file in an editor like emacs
>   
Ok, no problem.  I didn't realize there was a use for the format..
>
> Could you provide an example when the "file:line" format can be
> useful (apart of probably looking more aesthetic :) )
>   
The current format makes my eyes bleed :)

Thanks,
Ben


-- 
Ben Greear <greearb at candelatech.com> 
Candela Technologies Inc  http://www.candelatech.com




More information about the Xorp-hackers mailing list