[Xorp-hackers] Update FEA patch for one-socket per descriptor.

[Pavlin Radoslavov]

Ben Greear <greearb at candelatech.com> wrote:

> An updated patch is attached.  This patch also includes
> logic to clean up multicast bindings on interface removal
> and code to set the rx buffer for the tx-only socket very
> small.

Now that we have the pif_index optimized search in place, what are
the performance numbers with and without the "one socket per
interface" patch?

> The multicast changes fix a race in interface removal
> (iface is removed before OSPF notices and removes the
> multicast binds, and since the iface is gone, fea can no
> longer run the unbind logic.)  This is probably less
> critical when running one socket per iface, since the
> entire socket will already be cleaned up.

Is this a race that is in the vanilla FEA?
If yes, what is the sequence of events/commands we can use to
reproduce it?

In any case, as discussed previously, please create a Bugzilla entry
and add your patch to it.
There will be more refactoring in the FEA, so during that
refactoring your patch can be considered as well.

Thanks,
Pavlin