[Xorp-hackers] PIM-SM4: Cand-RP and Cand-BSR Inconsistency

[Pavlin Radoslavov]

Samuel Lucas Vaz de Mello <samuellucas at datacom.ind.br> wrote:

> Pavlin Radoslavov wrote:
> > 
> > Fixed in CVS. Note that the problem was deeper: it could be
> > triggered even if the user tried to update the PIM Bootstrap
> > configuration at runtime via xorpsh.
> > 
> 
> Pavlin,
> 
> Is there any reason to not set _bsr_addr and _bsr_priority in BsrZone::update_config_bsr_zone() ?

Fields _bsr_addr and _bsr_priority are suppose to be the state for
the Elected BSR. They matter in the set of so called "active"
BsrZone entries, but are not used in the "configured" BsrZone
entries.

There was a bug in old code re. how the state from the "configured"
BsrZone was propagated to the "active" BsrZone.
That bug was exposed my previous change.

I just committed a fix to CVS, so please try it and let me know if
you still have this or some other issue:

Revision  Changes                              Path
1.56      +3 -3;  commitid: ec3e4902630a41a7;  xorp/pim/pim_bsr.cc


Thanks,
Pavlin

> Using your patch, the address is set correctly in the configured zone but as soon as the configured zone becomes Active it has no LocalAddress:
> 
> samuellucas at erdinger> show pim bootstrap 
> Active zones:
> BSR             Pri LocalAddress    Pri State           Timeout SZTimeout
> 0.0.0.0           0 0.0.0.0           0 Pending             120        -1
> Expiring zones:
> BSR             Pri LocalAddress    Pri State           Timeout SZTimeout
> Configured zones:
> BSR             Pri LocalAddress    Pri State           Timeout SZTimeout
> 0.0.0.0           0 10.1.3.11         1 Init                 -1        -1
> 
> samuellucas at erdinger> show pim bootstrap 
> Active zones:
> BSR             Pri LocalAddress    Pri State           Timeout SZTimeout
> 0.0.0.0           0 0.0.0.0           0 Elected               4        -1
> Expiring zones:
> BSR             Pri LocalAddress    Pri State           Timeout SZTimeout
> Configured zones:
> BSR             Pri LocalAddress    Pri State           Timeout SZTimeout
> 0.0.0.0           0 10.1.3.11         1 Init                 -1        -1
> 
> It seems that the active zone takes address and priority from the _bsr_addr and _bsr_priority instead of _my_bsr_addr and _my_bsr_priority.
> 
> I've tested here updating _bsr_addr and _bsr_priority in update_config_bsr_zone and it seems to work it out.
> 
> For configured zones, there is any situation when the _bsr_addr/_bsr_priority would be different of _my_bsr_addr/_my_bsr_priority ?
> 
> 
> Thank you,
> 
>  - Samuel
> 
> 
> _______________________________________________
> Xorp-hackers mailing list
> Xorp-hackers at icir.org
> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers