[Xorp-hackers] Omitting XrlDB from Router Manager
Bruce Simpson
bms at incunabulum.net
Thu Nov 26 20:42:33 PST 2009
Ben Greear wrote:
> Bruce Simpson wrote:
>> Ben Greear wrote:
>>>>
>>>> * The rtrmgr/xrldb.cc is the only place in the whole system where
>>>> the '*.xrls' files are parsed and used. They are used only to
>>>> validate the syntax and structure of potential XRL method calls.
>>>> * It would mean that there is no up-front validation of the XRLs,
>>>> but in practice, this validation step is probably only of interest
>>>> to people developing XORP, to catch problems with template files.
>>>> * It's probably best folded under a compile-time #define for
>>>> developer use.
> It can't hurt, but I didn't do any performance tests specifically for
> this change. It does seem to function fine,
> however.
I've committed a slightly different patch, as r11598 on SVN trunk.
It does much the same thing, and doesn't install the *.xrls files in a
production image. It also shows how to implement these knobs at the
top-level SConstruct and push them down to where they're needed in C++ land.
Thanks for your patch!
regards,
BMS
More information about the Xorp-hackers
mailing list