[Xorp-hackers] PATCH: Logging improvements, fix artificial deal for xorpsh commit.
Ben Greear
greearb at candelatech.com
Mon Oct 5 15:58:33 PDT 2009
The attached patch has these improvements:
1) Fix logging & tracing to show micro-seconds, greatly aids debugging performance issues.
2) Change some pass-by-value string arguments to const string& in router-mgr. This will improve
performance and a small bit of memory usage.
3) Remove 1 second timeout in 'commit' path. At best, the timeout might have worked around
a race condition, but I can see no reason to leave it in. I tested with it set to zero
timeout and things work fine. This makes commits last around 200ms instead of 1.2ms, which is
a big improvement when scripting xorp.
Thanks,
Ben
--
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc http://www.candelatech.com
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: logging_commit_timeout.patch
Url: http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-hackers/attachments/20091005/b39b9a69/attachment.ksh
More information about the Xorp-hackers
mailing list