[Xorp-hackers] Building without strip enabled?

J.T. Conklin jtc at acorntoolworks.com
Wed Sep 30 07:21:33 PDT 2009


jtc at acorntoolworks.com (J.T. Conklin) writes:
> Ben Greear <greearb at candelatech.com> writes:
>> It seems the upstream code won't build without stripping.  The
>> patch below allows me to have this work as I expected:
>>
>> scons strip=no install
>
> Can you try updating to the most recent SConstruct? There used to be
> problems with boolean command line arguments like strip, but I fixed
> that on 9/15 in checkin 11546.
>
> env['strip'] is now set by a Variable, so should always have the 
> boolean value True or False.

However, upon further review, I discovered that the conditionals in
InstallProgram and InstallLibrary were checking whether 'strip' was
in the SCons environment (which it always was), rather than it's 
value.  I've just checked in a fix (11559).

    --jtc

-- 
J.T. Conklin



More information about the Xorp-hackers mailing list