[Xorp-hackers] VRRP error

[Li Zhao]

The problem is not those asserts. The problem is that VrrpPacket instance
is used multiple times, so each time before another packet is sent, the _data
in VrrpPacket should resize to default which is VRRP_MAX_PACKET_SIZE.
I updated vrrp.cc, vrrp_packet.h, vrrp_packet.cc and that seems better now.

I will post the change later. 

--- On Fri, 2/26/10, Ben Greear <greearb at candelatech.com> wrote:

> From: Ben Greear <greearb at candelatech.com>
> Subject: Re: [Xorp-hackers] VRRP error
> To: "Li Zhao" <lizhaous2000 at yahoo.com>
> Cc: "Eric S. Johnson" <esj at cs.fiu.edu>, xorp-hackers at icir.org
> Date: Friday, February 26, 2010, 4:59 PM
> On 02/26/2010 01:01 PM, Li Zhao
> wrote:
> > Actually the configuration is very simple to reproduce
> the problem on Linux.
> 
> I tried starting this on my system, and get an assertion.
> 
> I ran it with:
> /usr/local/xorp/bin/xorp_rtrmgr -b /root/xorp_vrrp.conf
> 
> The config file is exactly as you posted.
> 
> [ 2010/02/26 13:53:35 WARNING xorp_fea FEA ] Clearing
> iftree: copy of user-config
> [ 2010/02/26 13:53:36  FATAL xorp_vrrp:13019 VRRP
> vrrp_packet.cc:173 finalize ] Assertion (_data.size() ==
> _data.capacity() && _data.size() ==
> VRRP_MAX_PACKET_SIZE) failed
> [ 2010/02/26 13:53:36  ERROR xorp_rtrmgr:12925 RTRMGR
> module_manager.cc:764 done_cb ] Command
> "/usr/local/xorp/vrrp/xorp_vrrp": terminated with signal 6.
> 
> I ran it again with the latest code (mostly changes Eric
> has been testing), and
> now it crashes:
> 
> [ 2010/02/26 13:57:34 WARNING xorp_fea XrlFeaTarget ]
> Handling method for ifmgr/0.1/create_mac failed: XrlCmdError
> 102 Command failed Cannot add MAC address 0:0:5e:0:1:64 on
> interface eth1: MAC already added
> [ 2010/02/26 13:57:34  FATAL xorp_vrrp:14729 VRRP
> vrrp_target.cc:362 xrl_cb ] XRL error: 102 Command failed
> Cannot add MAC address 0:0:5e:0:1:64 on interface eth1: MAC
> already added
> [ 2010/02/26 13:57:34  ERROR xorp_rtrmgr:14644 RTRMGR
> module_manager.cc:764 done_cb ] Command
> "/usr/local/xorp/vrrp/xorp_vrrp": terminated with signal 6.
> 
> 
> Looks like it's time to remove some asserts :P
> 
> 
> Thanks,
> Ben
> 
> -- Ben Greear <greearb at candelatech.com>
> Candela Technologies Inc  http://www.candelatech.com
> 
>