From noreply at github.com  Fri Jul  1 13:55:53 2011
From: noreply at github.com (noreply at github.com)
Date: Fri, 1 Jul 2011 13:55:53 -0700
Subject: [Xorp-hackers] [greearb/xorp.ct] 935dda: Fix compile warnings on
	Ubuntu 11.
Message-ID: <20110701205553.221174260D@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct

  Commit: 935dda7f68c39a58c5bd1934923f02556050b52a
      https://github.com/greearb/xorp.ct/commit/935dda7f68c39a58c5bd1934923f02556050b52a
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-01 (Fri, 01 Jul 2011)

  Changed paths:
    M xorp/rib/rib.cc

  Log Message:
  -----------
  Fix compile warnings on Ubuntu 11.

There may be more problems...it compiles fine for me on
Fedora, so I just fixed the errors you reported.

Reported-by: doi at criepi.denken.or.jp
Signed-off-by: Ben Greear <greearb at candelatech.com>



From 43026437 at qq.com  Mon Jul  4 20:41:52 2011
From: 43026437 at qq.com (=?ISO-8859-1?B?d3hoNTg1?=)
Date: Tue, 5 Jul 2011 11:41:52 +0800
Subject: [Xorp-hackers] future xorp   advice
Message-ID: <tencent_715F05D92049D8A92263E9D9@qq.com>

xorp have a lot of bug,most function is available unavailable.future work fix this bug,it is necessitous.below is my test.
 static route  ok
rip    un-tested
ospf   unavailable
bgp    un-tested
firewall  unavailable
vrrp  unavailable
PIM-SM  un-tested
 future xorp DHCP NAT QOS is important for user.
  think for xorp-hackers's work.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-hackers/attachments/20110705/88cbdc38/attachment.html 

From 43026437 at qq.com  Mon Jul  4 20:48:46 2011
From: 43026437 at qq.com (=?ISO-8859-1?B?d3hoNTg1?=)
Date: Tue, 5 Jul 2011 11:48:46 +0800
Subject: [Xorp-hackers] future xorp   advice
Message-ID: <tencent_74B0CABA78BA372909F106CD@qq.com>

xorp have a lot of bug,most function is available unavailable.future work fix this bug,it is necessitous.below is my test.
 static route  ok
rip    un-tested
ospf   unavailable
bgp    un-tested
firewall  unavailable
vrrp  unavailable
PIM-SM  un-tested
 future xorp DHCP NAT QOS is important for user.
  think for xorp-hackers's work.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-hackers/attachments/20110705/e9210f0e/attachment.html 

From greearb at candelatech.com  Tue Jul  5 09:26:38 2011
From: greearb at candelatech.com (Ben Greear)
Date: Tue, 05 Jul 2011 09:26:38 -0700
Subject: [Xorp-hackers] future xorp   advice
In-Reply-To: <tencent_715F05D92049D8A92263E9D9@qq.com>
References: <tencent_715F05D92049D8A92263E9D9@qq.com>
Message-ID: <4E133B3E.7070106@candelatech.com>

On 07/04/2011 08:41 PM, wxh585 wrote:
> xorp have a lot of bug,most function is available unavailable.future work fix this bug,it is necessitous.below is my test.
> static route ok
> rip un-tested
> ospf unavailable
> bgp un-tested
> firewall unavailable
> vrrp unavailable
> PIM-SM un-tested
> future xorp DHCP NAT QOS is important for user.
> think for xorp-hackers's work.

Well, it works better for me.

We've tested OSPF, RIP, PIM-SM, and BGP successfully.

We have also used VRRP, but only connected to other Xorp
routers and only on Linux.  So, it may have issues talking
to other systems.

In general, Xorp can be difficult to properly configure,
but if you configure it properly, it can work.

Thanks,
Ben

>
>
>
> _______________________________________________
> Xorp-hackers mailing list
> Xorp-hackers at icir.org
> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


From noreply at github.com  Wed Jul  6 09:21:28 2011
From: noreply at github.com (noreply at github.com)
Date: Wed, 6 Jul 2011 09:21:28 -0700
Subject: [Xorp-hackers] [greearb/xorp.ct] 186478: fea: All platforms we care
	about support strerror...
Message-ID: <20110706162128.2E40F42030@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct

  Commit: 186478320324ebfd0bd9a4f1c8b8d7e957b56583
      https://github.com/greearb/xorp.ct/commit/186478320324ebfd0bd9a4f1c8b8d7e957b56583
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-06 (Wed, 06 Jul 2011)

  Changed paths:
    M xorp/fea/data_plane/io/io_ip_socket.cc

  Log Message:
  -----------
  fea:  All platforms we care about support strerror.

Also, register for interface events on Windows too.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 2371b7c96ce167955241ab54952d94d0daf729c0
      https://github.com/greearb/xorp.ct/commit/2371b7c96ce167955241ab54952d94d0daf729c0
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-06 (Wed, 06 Jul 2011)

  Changed paths:
    M xorp/fea/data_plane/io/io_ip_socket.cc
  M xorp/libxorp/xorp_osdep_end.h

  Log Message:
  -----------
  libxorp/fea:  Add XSTRERROR macro to provide cross-platform strerror

This should print out better error messages on Windows.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 0ad0397435f018ba2e44db6330acb95c5b532c52
      https://github.com/greearb/xorp.ct/commit/0ad0397435f018ba2e44db6330acb95c5b532c52
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-06 (Wed, 06 Jul 2011)

  Changed paths:
    M xorp/fea/data_plane/io/io_ip_socket.cc
  M xorp/libxorp/xorp_osdep_end.h
  M xorp/rib/rib.cc

  Log Message:
  -----------
  Merge ../xorp.ct.github


  Commit: 9dcd3a376fea17c0433266bd8e57c371f278bcba
      https://github.com/greearb/xorp.ct/commit/9dcd3a376fea17c0433266bd8e57c371f278bcba
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-06 (Wed, 06 Jul 2011)

  Changed paths:
    M xorp/libxipc/finder.cc

  Log Message:
  -----------
  xrl:  Only warn if trying to register duplicate class-watch.

I'm not sure why the user is seeing this error, but it would
not appear critical.  So, if watch is already there, then just
print warning and return success.

Signed-off-by: Ben Greear <greearb at candelatech.com>


Compare: https://github.com/greearb/xorp.ct/compare/935dda7...9dcd3a3


From noreply at github.com  Wed Jul  6 10:23:47 2011
From: noreply at github.com (noreply at github.com)
Date: Wed, 6 Jul 2011 10:23:47 -0700
Subject: [Xorp-hackers] [greearb/xorp.ct] 9a9a9e: scons: Fix suggested
	install commands for Ubuntu 1...
Message-ID: <20110706172347.EC812424C2@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct

  Commit: 9a9a9e8fe1d57bbfa359ca69c971cafe9403c750
      https://github.com/greearb/xorp.ct/commit/9a9a9e8fe1d57bbfa359ca69c971cafe9403c750
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-06 (Wed, 06 Jul 2011)

  Changed paths:
    M xorp/site_scons/config/allconfig.py

  Log Message:
  -----------
  scons: Fix suggested install commands for Ubuntu 11.04

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 81533b82a8f05b493181ff351cab530119bf0caa
      https://github.com/greearb/xorp.ct/commit/81533b82a8f05b493181ff351cab530119bf0caa
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-06 (Wed, 06 Jul 2011)

  Changed paths:
    M xorp/site_scons/config/allconfig.py

  Log Message:
  -----------
  scons/firewall:  Fix up kernel header modification msg.

Later kernels changed the argument type, so update notes
accordingly.

Signed-off-by: Ben Greear <greearb at candelatech.com>


Compare: https://github.com/greearb/xorp.ct/compare/9dcd3a3...81533b8


From greearb at candelatech.com  Wed Jul  6 11:22:31 2011
From: greearb at candelatech.com (Ben Greear)
Date: Wed, 06 Jul 2011 11:22:31 -0700
Subject: [Xorp-hackers] Where can I get the raw packet?
In-Reply-To: <EA1D5A7F-3EAC-4A73-8D26-D3AB9E52C598@criepi.denken.or.jp>
References: <EA1D5A7F-3EAC-4A73-8D26-D3AB9E52C598@criepi.denken.or.jp>
Message-ID: <4E14A7E7.40703@candelatech.com>

On 06/29/2011 10:21 PM, ?? ?? wrote:
> I am a Japanese xorp user and a newbie xorp hacker :).
>
> Now, I test a OSPF routing on xorp 1.8.3 with a simple network.
>
> (Linux box A, ubuntu 11.04, OSPF)<---->  (Linux box B, ubuntu 11.04, OSPF)
>
> At first, I try to understand the packet flow inside xorp.
> So, I read the source code fea/data_plane/io/io_ip_socket.cc
> I guessed that the routine proto_socket_read() receives the raw packets.
> Although I can capture OSPF related packets (Hello, DB, LSA) in proto_socket_read() on Linux box A, I cannot capture the other packets (ping packets or ARP) when I send ping packets from Linux box B to Linux box A .
> Also I guess that xorp has another routine to receive raw packets and filters the raw packets and send to  proto_socket_read().
>
> Please suggest me the routine which receives the raw packet at first.
> I would like to understand the packet flow from first.

Raw packets come into the FEA process in fea/data_plane/io/io_ip_socket.cc

There are some other files in that directory that can also receive/send
packets.

Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


From noreply at github.com  Wed Jul  6 11:39:35 2011
From: noreply at github.com (noreply at github.com)
Date: Wed, 6 Jul 2011 11:39:35 -0700
Subject: [Xorp-hackers] [greearb/xorp.ct] f76571: fea: Use XSTRERROR instead
	of strerror(errno).
Message-ID: <20110706183935.82E3A42308@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct

  Commit: f765710dba739250459848e6194261283959bc6a
      https://github.com/greearb/xorp.ct/commit/f765710dba739250459848e6194261283959bc6a
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-06 (Wed, 06 Jul 2011)

  Changed paths:
    M xorp/fea/data_plane/io/io_tcpudp_socket.cc

  Log Message:
  -----------
  fea:  Use XSTRERROR instead of strerror(errno).

Should give better error messages on Windows.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: a042707d7923141c6d1544d45a8560420db52217
      https://github.com/greearb/xorp.ct/commit/a042707d7923141c6d1544d45a8560420db52217
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-06 (Wed, 06 Jul 2011)

  Changed paths:
    M xorp/contrib/olsr/topology.cc

  Log Message:
  -----------
  olsr:  Fix topology search.

The code would find and set 'is_found = true' on an entry that really
didn't exist. The modification now does a more precise check of the entry.

Original patch provided by:
Philip Hugg <phugg at crc.ca>

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 5f85cb0aeaf36f7d35639e61fa5c9d6216188b67
      https://github.com/greearb/xorp.ct/commit/5f85cb0aeaf36f7d35639e61fa5c9d6216188b67
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-06 (Wed, 06 Jul 2011)

  Changed paths:
    M xorp/contrib/olsr/topology.cc

  Log Message:
  -----------
  olsr:  Fix code relating to RFC section 9.5

This was an RFC fix. This seemed to have been forgotten during implementation.
See RFC section 9.5, paragraphs 2 and 3.

Original patch from:
Philip Hugg <phugg at crc.ca>

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 741b50581a075fc792930d2671c0f7ebc771d7e5
      https://github.com/greearb/xorp.ct/commit/741b50581a075fc792930d2671c0f7ebc771d7e5
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-06 (Wed, 06 Jul 2011)

  Changed paths:
    M xorp/site_scons/config/allconfig.py

  Log Message:
  -----------
  Merge branch 'master' of github.com:greearb/xorp.ct


Compare: https://github.com/greearb/xorp.ct/compare/81533b8...741b505


From greearb at candelatech.com  Wed Jul  6 11:40:26 2011
From: greearb at candelatech.com (Ben Greear)
Date: Wed, 06 Jul 2011 11:40:26 -0700
Subject: [Xorp-hackers] Some fixes to OLSR (topology.cc)
In-Reply-To: <4DF7A48C.1050007@crc.ca>
References: <4DF66C89.9090806@crc.ca> <4DF678C1.5060206@candelatech.com>
	<4DF75809.4080000@crc.ca> <4DF78C5D.7000700@candelatech.com>
	<4DF7A48C.1050007@crc.ca>
Message-ID: <4E14AC1A.9030208@candelatech.com>

On 06/14/2011 11:12 AM, Philip Hugg wrote:
> On 14/06/2011 12:29 PM, Ben Greear wrote:
>> On 06/14/2011 05:46 AM, Philip Hugg wrote:
>>
>>> I've included file 'topology.cc.patch'. Generated by
>>> 'diff -uEw modified original > topology.cc.patch'.
>>> Is this OK?
>>
>> You should put the original first to generate a proper patch,
>> but I can fix that manually in this case.
>>
>> If you remember, can you describe what this fix fixes?
>>
>> Thanks,
>> Ben
>>
>>
> Ben,
>
> Sorry about the patch file.
>
> The modifications generally fixes and stabilizes the entries in the
> OLSR's topology information base.
>
> Fix 1- File -> topology.cc, method-> update_tc_entry(...).
> This was a programmatic fix. The code would find and set 'is_found =
> true' on an entry that really
> didn't exist. The modification now does a more precise check of the entry.
>
> Fix 2- method -> apply_tc_ansn(...)
> This was an RFC fix. This seemed to have been forgotten during
> implementation. See RFC section 9.5,
> paragraphs 2 and 3.
>
> I hope this helps!

Thanks for the patches.  I committed these and pushed them
upstream.

Thanks,
Ben

> Phil.
>


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


From noreply at github.com  Wed Jul  6 14:28:00 2011
From: noreply at github.com (noreply at github.com)
Date: Wed, 6 Jul 2011 14:28:00 -0700
Subject: [Xorp-hackers] [greearb/xorp.ct] 089f2a: Added helper classes for
	async responses.
Message-ID: <20110706212800.C8655424C5@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct

  Commit: 089f2abe50b09a4a0351a65e6ccd59e1570a6a94
      https://github.com/greearb/xorp.ct/commit/089f2abe50b09a4a0351a65e6ccd59e1570a6a94
  Author: Steven Simpson <ss at comp.lancs.ac.uk>
  Date:   2011-07-06 (Wed, 06 Jul 2011)

  Changed paths:
    M xorp/xrl/scripts/tgt-gen

  Log Message:
  -----------
  Added helper classes for async responses.

* Renamed generated callback function type *CB to *RF (for Response
  Function).

* tgt-gen creates *CB class (constructed from *RF) which offers
  respond(out-args) and fail(error) methods mapping onto *RF calls,
  and retains ->dispatch method for compatibility.  The name *CB
  continues to be used in method signatures (like each async_*
  function), so the new *CB class replaces the old *CB typedef.

* tgt-gen also generates *Rsp class as argument-holding version of
  *CB.  Not used in any generated signatures, but available to user.

Signed-off-by: Steven Simpson <ss at comp.lancs.ac.uk>



From greearb at candelatech.com  Wed Jul  6 14:27:57 2011
From: greearb at candelatech.com (Ben Greear)
Date: Wed, 06 Jul 2011 14:27:57 -0700
Subject: [Xorp-hackers] [PATCH] Added helper classes for async responses.
In-Reply-To: <1307438199-2388-1-git-send-email-ss@comp.lancs.ac.uk>
References: <4DECBD72.5070604@comp.lancs.ac.uk>
	<1307438199-2388-1-git-send-email-ss@comp.lancs.ac.uk>
Message-ID: <4E14D35D.3050800@candelatech.com>

On 06/07/2011 02:16 AM, ss at comp.lancs.ac.uk wrote:
> From: Steven Simpson<ss at comp.lancs.ac.uk>
>
> * Renamed generated callback function type *CB to *RF (for Response
>    Function).
>
> * tgt-gen creates *CB class (constructed from *RF) which offers
>    respond(out-args) and fail(error) methods mapping onto *RF calls,
>    and retains ->dispatch method for compatibility.  The name *CB
>    continues to be used in method signatures (like each async_*
>    function), so the new *CB class replaces the old *CB typedef.
>
> * tgt-gen also generates *Rsp class as argument-holding version of
>    *CB.  Not used in any generated signatures, but available to user.
>
> Signed-off-by: Steven Simpson<ss at comp.lancs.ac.uk>

Thanks for the patch.  I have pushed this upstream.

Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


From noreply at github.com  Wed Jul  6 17:43:30 2011
From: noreply at github.com (noreply at github.com)
Date: Wed, 6 Jul 2011 17:43:30 -0700
Subject: [Xorp-hackers] [greearb/xorp.ct] 990a9d: Fix build on windows.
Message-ID: <20110707004330.332534249A@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct

  Commit: 990a9dfbde3d2beb28d48d61c51bc623fa73a4ae
      https://github.com/greearb/xorp.ct/commit/990a9dfbde3d2beb28d48d61c51bc623fa73a4ae
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-06 (Wed, 06 Jul 2011)

  Changed paths:
    M xorp/libxorp/xorp_osdep_end.h

  Log Message:
  -----------
  Fix build on windows.

Just broke it a few commits ago.

Signed-off-by: Ben Greear <greearb at candelatech.com>



From noreply at github.com  Thu Jul  7 13:56:50 2011
From: noreply at github.com (noreply at github.com)
Date: Thu, 7 Jul 2011 13:56:50 -0700
Subject: [Xorp-hackers] [greearb/xorp.ct] 88a1e2: fea: Whitespace cleanup.
Message-ID: <20110707205649.EE900423E6@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct

  Commit: 88a1e20fe7da36bb805657f346736f8dd6a6e849
      https://github.com/greearb/xorp.ct/commit/88a1e20fe7da36bb805657f346736f8dd6a6e849
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-07 (Thu, 07 Jul 2011)

  Changed paths:
    M xorp/fea/data_plane/io/io_ip_socket.cc
  M xorp/fea/data_plane/io/io_tcpudp_socket.cc

  Log Message:
  -----------
  fea:  Whitespace cleanup.

Signed-off-by: Ben Greear <greearb at candelatech.com>



From jose.spam at netvisao.pt  Sat Jul 23 06:27:30 2011
From: jose.spam at netvisao.pt (Jose Manuel dos Santos Calhariz)
Date: Sat, 23 Jul 2011 14:27:30 +0100
Subject: [Xorp-hackers] Compiling xorp 1.8.3 for Debian using g++-4.6
Message-ID: <20110723132730.GA32689@calhariz.com>


I am packaging xorp 1.8.3 for Debian.  The default compiler is now g++
v4.6.  This compiler is more stricter than previous versions.

This g++ have one new warnings:

  -Wunused-but-set-variable

This warning when used with -Werror causes a fail to build.  The 
position on Debian is to fix the problems on the source code instead
of using the flag -Wno-error=unused-but-set-variable for disabling the
warning. 

I am asking if this problem is solved in the git repository or if will
be fixed in the near future.  Maybe this is a simple fix and is enough
to comment out the affected variables. 

That's 21 warnings, follow the list of messages for reference:

cli/cli_client.cc:1352:9: warning: variable 'syntax_error_offset_prev' set but not used [-Wunused-but-set-variable]
pim/pim_mrt_mfc.cc:473:13: warning: variable 'pim_mre_wc' set but not used [-Wunused-but-set-variable]
pim/pim_proto_assert.cc:80:14: warning: variable 'group_addr_reserved_flags' set but not used [-Wunused-but-set-variable]
pim/pim_proto_join_prune.cc:87:13: warning: variable 'group_addr_reserved_flags' set but not used [-Wunused-but-set-variable]
pim/pim_proto_join_prune_message.cc:344:13: warning: variable 'source_mask_len' set but not used [-Wunused-but-set-variable]
pim/pim_proto_register_stop.cc:78:13: warning: variable 'group_addr_reserved_flags' set but not used [-Wunused-but-set-variable]
rib/tools/show_distances.cc:439:8: warning: variable 'do_run' set but not used [-Wunused-but-set-variable]
rib/tools/show_routes.cc:810:8: warning: variable 'do_run' set but not used [-Wunused-but-set-variable]
rib/register_server.cc:134:10: warning: variable 'new_queue' set but not used [-Wunused-but-set-variable]
rib/rt_tab_origin.cc:186:23: warning: variable 'dt' set but not used [-Wunused-but-set-variable]
rib/rt_tab_origin.cc:186:23: warning: variable 'dt' set but not used [-Wunused-but-set-variable]
contrib/olsr/face_manager.cc:324:23: warning: variable 'faceid' set but not used [-Wunused-but-set-variable]
contrib/olsr/message.cc:288:10: warning: variable 'haslq' set but not used [-Wunused-but-set-variable]
bgp/route_table_decision.cc:387:6: warning: variable 'result' set but not used [-Wunused-but-set-variable]
bgp/route_table_decision.cc:387:6: warning: variable 'result' set but not used [-Wunused-but-set-variable]
bgp/route_table_ribin.cc:176:4: warning: variable 'nexthop' set but not used [-Wunused-but-set-variable]
bgp/route_table_ribin.cc:176:4: warning: variable 'nexthop' set but not used [-Wunused-but-set-variable]
ospf/peer.cc:4860:7: warning: variable 'found' set but not used [-Wunused-but-set-variable]
ospf/peer.cc:4861:7: warning: variable 'partial' set but not used [-Wunused-but-set-variable]
ospf/peer.cc:4860:7: warning: variable 'found' set but not used [-Wunused-but-set-variable]
ospf/peer.cc:4861:7: warning: variable 'partial' set but not used [-Wunused-but-set-variable]


     Jose Calhariz


-- 
--
	Mostre-me um homem que n?o beba e eu lhe provarei que ele e
	parte camelo.
		-- W. C. Fields


From greearb at candelatech.com  Sat Jul 23 10:28:52 2011
From: greearb at candelatech.com (Ben Greear)
Date: Sat, 23 Jul 2011 10:28:52 -0700
Subject: [Xorp-hackers] Compiling xorp 1.8.3 for Debian using g++-4.6
In-Reply-To: <20110723132730.GA32689@calhariz.com>
References: <20110723132730.GA32689@calhariz.com>
Message-ID: <4E2B04D4.508@candelatech.com>

On 07/23/2011 06:27 AM, Jose Manuel dos Santos Calhariz wrote:
>
> I am packaging xorp 1.8.3 for Debian.  The default compiler is now g++
> v4.6.  This compiler is more stricter than previous versions.
>
> This g++ have one new warnings:
>
>    -Wunused-but-set-variable
>
> This warning when used with -Werror causes a fail to build.  The
> position on Debian is to fix the problems on the source code instead
> of using the flag -Wno-error=unused-but-set-variable for disabling the
> warning.
>
> I am asking if this problem is solved in the git repository or if will
> be fixed in the near future.  Maybe this is a simple fix and is enough
> to comment out the affected variables.

Some may be solved in git, and if not, patches are welcome.

Thanks,
Ben

>
> That's 21 warnings, follow the list of messages for reference:
>
> cli/cli_client.cc:1352:9: warning: variable 'syntax_error_offset_prev' set but not used [-Wunused-but-set-variable]
> pim/pim_mrt_mfc.cc:473:13: warning: variable 'pim_mre_wc' set but not used [-Wunused-but-set-variable]
> pim/pim_proto_assert.cc:80:14: warning: variable 'group_addr_reserved_flags' set but not used [-Wunused-but-set-variable]
> pim/pim_proto_join_prune.cc:87:13: warning: variable 'group_addr_reserved_flags' set but not used [-Wunused-but-set-variable]
> pim/pim_proto_join_prune_message.cc:344:13: warning: variable 'source_mask_len' set but not used [-Wunused-but-set-variable]
> pim/pim_proto_register_stop.cc:78:13: warning: variable 'group_addr_reserved_flags' set but not used [-Wunused-but-set-variable]
> rib/tools/show_distances.cc:439:8: warning: variable 'do_run' set but not used [-Wunused-but-set-variable]
> rib/tools/show_routes.cc:810:8: warning: variable 'do_run' set but not used [-Wunused-but-set-variable]
> rib/register_server.cc:134:10: warning: variable 'new_queue' set but not used [-Wunused-but-set-variable]
> rib/rt_tab_origin.cc:186:23: warning: variable 'dt' set but not used [-Wunused-but-set-variable]
> rib/rt_tab_origin.cc:186:23: warning: variable 'dt' set but not used [-Wunused-but-set-variable]
> contrib/olsr/face_manager.cc:324:23: warning: variable 'faceid' set but not used [-Wunused-but-set-variable]
> contrib/olsr/message.cc:288:10: warning: variable 'haslq' set but not used [-Wunused-but-set-variable]
> bgp/route_table_decision.cc:387:6: warning: variable 'result' set but not used [-Wunused-but-set-variable]
> bgp/route_table_decision.cc:387:6: warning: variable 'result' set but not used [-Wunused-but-set-variable]
> bgp/route_table_ribin.cc:176:4: warning: variable 'nexthop' set but not used [-Wunused-but-set-variable]
> bgp/route_table_ribin.cc:176:4: warning: variable 'nexthop' set but not used [-Wunused-but-set-variable]
> ospf/peer.cc:4860:7: warning: variable 'found' set but not used [-Wunused-but-set-variable]
> ospf/peer.cc:4861:7: warning: variable 'partial' set but not used [-Wunused-but-set-variable]
> ospf/peer.cc:4860:7: warning: variable 'found' set but not used [-Wunused-but-set-variable]
> ospf/peer.cc:4861:7: warning: variable 'partial' set but not used [-Wunused-but-set-variable]
>
>
>       Jose Calhariz
>
>


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


From jose.spam at netvisao.pt  Sun Jul 24 15:02:34 2011
From: jose.spam at netvisao.pt (Jose Manuel dos Santos Calhariz)
Date: Sun, 24 Jul 2011 23:02:34 +0100
Subject: [Xorp-hackers] Compiling xorp 1.8.3 for Debian using g++-4.6
In-Reply-To: <4E2B04D4.508@candelatech.com>
References: <20110723132730.GA32689@calhariz.com>
	<4E2B04D4.508@candelatech.com>
Message-ID: <20110724220234.GA11883@calhariz.com>

On Sat, Jul 23, 2011 at 10:28:52AM -0700, Ben Greear wrote:
> On 07/23/2011 06:27 AM, Jose Manuel dos Santos Calhariz wrote:
> >
> >I am packaging xorp 1.8.3 for Debian.  The default compiler is now g++
> >v4.6.  This compiler is more stricter than previous versions.
> >
> >This g++ have one new warnings:
> >
> >   -Wunused-but-set-variable
> >
> >This warning when used with -Werror causes a fail to build.  The
> >position on Debian is to fix the problems on the source code instead
> >of using the flag -Wno-error=unused-but-set-variable for disabling the
> >warning.
> >
> >I am asking if this problem is solved in the git repository or if will
> >be fixed in the near future.  Maybe this is a simple fix and is enough
> >to comment out the affected variables.
> 
> Some may be solved in git, and if not, patches are welcome.

Here goes a draft of the patches.  This page explains the warning and
how to solve it http://lists.fedoraproject.org/pipermail/devel/2011-February/148523.html

For solving the errors, I have used various strategies:

 - Looks to be old forgotten code, so I commented the variable
 definition.

 - Variable and the the code looks to do nothing, so I
 commented everything.

 - The variable is not used because of a #ifdef, so I put the
 same #ifdef around the variable.

 - The variable is not used because of a macro, so I used
 "__attribute__((__unused__))" in the definition of it.

 - The function that calculates the value of the variable may have
side effects, so I used "__attribute__((__unused__))"

I am not familiar with the xorp code and my c++ skills are very rusty,
so most probably I missed something.  I looked into git hub, but the
code looked to be the same in the affected areas.

In attach follows a tar file with the patches.  The resulting code
compiles, but I have not run the compiled binary.

    Jose Calhariz

> 
> Thanks,
> Ben
> 

-- 
--

Volto atr?s, sim. Com o erro n?o h? compromisso

--Juscelino Kubitschek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ftbfs_gcc-4.6.tar
Type: application/x-tar
Size: 20480 bytes
Desc: not available
Url : http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-hackers/attachments/20110724/1af2856c/attachment-0001.tar 

From jose.spam at netvisao.pt  Mon Jul 25 10:05:42 2011
From: jose.spam at netvisao.pt (Jose Manuel dos Santos Calhariz)
Date: Mon, 25 Jul 2011 18:05:42 +0100
Subject: [Xorp-hackers] Compiling xorp 1.8.3 for Debian using g++-4.6
In-Reply-To: <20110724220234.GA11883@calhariz.com>
References: <20110723132730.GA32689@calhariz.com>
	<4E2B04D4.508@candelatech.com>
	<20110724220234.GA11883@calhariz.com>
Message-ID: <20110725170542.GA11579@calhariz.com>

On Sun, Jul 24, 2011 at 11:02:34PM +0100, Jose Manuel dos Santos Calhariz wrote:
> On Sat, Jul 23, 2011 at 10:28:52AM -0700, Ben Greear wrote:
> > On 07/23/2011 06:27 AM, Jose Manuel dos Santos Calhariz wrote:
> > >
> > >I am packaging xorp 1.8.3 for Debian.  The default compiler is now g++
> > >v4.6.  This compiler is more stricter than previous versions.
> > >
> > >This g++ have one new warnings:
> > >
> > >   -Wunused-but-set-variable
> > >
> > >This warning when used with -Werror causes a fail to build.  The
> > >position on Debian is to fix the problems on the source code instead
> > >of using the flag -Wno-error=unused-but-set-variable for disabling the
> > >warning.
> > >
> > >I am asking if this problem is solved in the git repository or if will
> > >be fixed in the near future.  Maybe this is a simple fix and is enough
> > >to comment out the affected variables.
> > 
> > Some may be solved in git, and if not, patches are welcome.
> 
> Here goes a draft of the patches.  This page explains the warning and
> how to solve it http://lists.fedoraproject.org/pipermail/devel/2011-February/148523.html
> 
> For solving the errors, I have used various strategies:
> 
>  - Looks to be old forgotten code, so I commented the variable
>  definition.
> 
>  - Variable and the the code looks to do nothing, so I
>  commented everything.
> 
>  - The variable is not used because of a #ifdef, so I put the
>  same #ifdef around the variable.
> 
>  - The variable is not used because of a macro, so I used
>  "__attribute__((__unused__))" in the definition of it.
> 
>  - The function that calculates the value of the variable may have
> side effects, so I used "__attribute__((__unused__))"
> 
> I am not familiar with the xorp code and my c++ skills are very rusty,
> so most probably I missed something.  I looked into git hub, but the
> code looked to be the same in the affected areas.
> 
> In attach follows a tar file with the patches.  The resulting code
> compiles, but I have not run the compiled binary.

I missed a warning/error on file contrib/olsr/face_manager.cc.  Here
goes an update to one of the patches.

> 
>     Jose Calhariz
> 
> > 
> > Thanks,
> > Ben
> > 
> 

     Jose Calhariz

-- 
--

Capoeira que ? bom, n?o cai; e se um dia ele cai, cai bem

--Vinicius de Moraes
-------------- next part --------------
Index: xorp-1.8.3-sid-gcc-4.6/contrib/olsr/message.cc
===================================================================
--- xorp-1.8.3-sid-gcc-4.6.orig/contrib/olsr/message.cc	2011-07-25 14:42:34.000000000 +0000
+++ xorp-1.8.3-sid-gcc-4.6/contrib/olsr/message.cc	2011-07-25 14:43:15.000000000 +0000
@@ -285,7 +285,10 @@ HelloMessage::encode(uint8_t* buf, size_
     embed_8(&buf[offset], willingness());		// willingness
     offset += sizeof(uint8_t);
 
+    // Debian FTBFS 625437 
+#ifdef DETAILED_DEBUG
     bool haslq = false;
+#endif
 
     // link tuples
     LinkCode thislc;
@@ -295,8 +298,8 @@ HelloMessage::encode(uint8_t* buf, size_
 	if (ii == _links.begin() || (*ii).first != thislc) {
 	    thislc = (*ii).first;   // The link code of the new tuple
 
-	    haslq = lai.has_etx();
 #ifdef DETAILED_DEBUG
+	    haslq = lai.has_etx();
 	    // Invariant: ETX measurements MUST be present in
 	    // an LQ HELLO message, and MUST NOT be present in a
 	    // legacy HELLO message.
Index: xorp-1.8.3-sid-gcc-4.6/contrib/olsr/face_manager.cc
===================================================================
--- xorp-1.8.3-sid-gcc-4.6.orig/contrib/olsr/face_manager.cc	2011-07-25 15:26:16.000000000 +0000
+++ xorp-1.8.3-sid-gcc-4.6/contrib/olsr/face_manager.cc	2011-07-25 15:26:58.000000000 +0000
@@ -321,9 +321,11 @@ FaceManager::activate_face(const string&
 {
     debug_msg("Interface %s Vif %s\n", interface.c_str(), vif.c_str());
 
-    OlsrTypes::FaceID faceid;
+    // Debian FTBFS 625437
+    // OlsrTypes::FaceID faceid;
     try {
-	faceid = get_faceid(interface, vif);
+	// Debian FTBFS 625437
+	/* faceid = */ get_faceid(interface, vif);
     } catch(...) {
 	return false;
     }

From greearb at candelatech.com  Mon Jul 25 10:07:52 2011
From: greearb at candelatech.com (Ben Greear)
Date: Mon, 25 Jul 2011 10:07:52 -0700
Subject: [Xorp-hackers] Compiling xorp 1.8.3 for Debian using g++-4.6
In-Reply-To: <20110725170542.GA11579@calhariz.com>
References: <20110723132730.GA32689@calhariz.com>
	<4E2B04D4.508@candelatech.com>
	<20110724220234.GA11883@calhariz.com>
	<20110725170542.GA11579@calhariz.com>
Message-ID: <4E2DA2E8.9000406@candelatech.com>

On 07/25/2011 10:05 AM, Jose Manuel dos Santos Calhariz wrote:
> On Sun, Jul 24, 2011 at 11:02:34PM +0100, Jose Manuel dos Santos Calhariz wrote:
>> On Sat, Jul 23, 2011 at 10:28:52AM -0700, Ben Greear wrote:
>>> On 07/23/2011 06:27 AM, Jose Manuel dos Santos Calhariz wrote:
>>>>
>>>> I am packaging xorp 1.8.3 for Debian.  The default compiler is now g++
>>>> v4.6.  This compiler is more stricter than previous versions.
>>>>
>>>> This g++ have one new warnings:
>>>>
>>>>    -Wunused-but-set-variable
>>>>
>>>> This warning when used with -Werror causes a fail to build.  The
>>>> position on Debian is to fix the problems on the source code instead
>>>> of using the flag -Wno-error=unused-but-set-variable for disabling the
>>>> warning.
>>>>
>>>> I am asking if this problem is solved in the git repository or if will
>>>> be fixed in the near future.  Maybe this is a simple fix and is enough
>>>> to comment out the affected variables.
>>>
>>> Some may be solved in git, and if not, patches are welcome.
>>
>> Here goes a draft of the patches.  This page explains the warning and
>> how to solve it http://lists.fedoraproject.org/pipermail/devel/2011-February/148523.html
>>
>> For solving the errors, I have used various strategies:
>>
>>   - Looks to be old forgotten code, so I commented the variable
>>   definition.
>>
>>   - Variable and the the code looks to do nothing, so I
>>   commented everything.
>>
>>   - The variable is not used because of a #ifdef, so I put the
>>   same #ifdef around the variable.
>>
>>   - The variable is not used because of a macro, so I used
>>   "__attribute__((__unused__))" in the definition of it.
>>
>>   - The function that calculates the value of the variable may have
>> side effects, so I used "__attribute__((__unused__))"
>>
>> I am not familiar with the xorp code and my c++ skills are very rusty,
>> so most probably I missed something.  I looked into git hub, but the
>> code looked to be the same in the affected areas.
>>
>> In attach follows a tar file with the patches.  The resulting code
>> compiles, but I have not run the compiled binary.
>
> I missed a warning/error on file contrib/olsr/face_manager.cc.  Here
> goes an update to one of the patches.

Thanks for these.  It will probably be a day or two before I can review
and apply them, but I'll try to get on it quickly.

Thanks,
Ben

>
>>
>>      Jose Calhariz
>>
>>>
>>> Thanks,
>>> Ben
>>>
>>
>
>       Jose Calhariz
>


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


From noreply at github.com  Mon Jul 25 11:23:52 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 25 Jul 2011 11:23:52 -0700
Subject: [Xorp-hackers] [greearb/xorp.ct] 8c4c75: bgp: Compile fixes for gcc
	4.6
Message-ID: <20110725182352.E4D29424AA@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct

  Commit: 8c4c750d3834ea3e05f5ee0b00f8f4035696c473
      https://github.com/greearb/xorp.ct/commit/8c4c750d3834ea3e05f5ee0b00f8f4035696c473
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-25 (Mon, 25 Jul 2011)

  Changed paths:
    M xorp/bgp/route_table_decision.cc
  M xorp/bgp/route_table_ribin.cc

  Log Message:
  -----------
  bgp:  Compile fixes for gcc 4.6

Original patch by:
Jose Manuel dos Santos Calhariz <jose.spam at netvisao.pt>

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 755ecb821bf41b310cda92eb651bc600ec24834e
      https://github.com/greearb/xorp.ct/commit/755ecb821bf41b310cda92eb651bc600ec24834e
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-25 (Mon, 25 Jul 2011)

  Changed paths:
    M xorp/cli/cli_client.cc

  Log Message:
  -----------
  cli:  Compile fixes for gcc 4.6

Original patch by:
Jose Manuel dos Santos Calhariz <jose.spam at netvisao.pt>

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: ce3302bba093b77ab77c2b7c3b985f60387dd4bf
      https://github.com/greearb/xorp.ct/commit/ce3302bba093b77ab77c2b7c3b985f60387dd4bf
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-25 (Mon, 25 Jul 2011)

  Changed paths:
    M xorp/contrib/olsr/face_manager.cc
  M xorp/contrib/olsr/message.cc

  Log Message:
  -----------
  olsr:  Compile fixes for gcc 4.6

Original patch by:
Jose Manuel dos Santos Calhariz <jose.spam at netvisao.pt>

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 2115df35657b28f60bff17c2c31531eebc261571
      https://github.com/greearb/xorp.ct/commit/2115df35657b28f60bff17c2c31531eebc261571
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-25 (Mon, 25 Jul 2011)

  Changed paths:
    M xorp/ospf/peer.cc

  Log Message:
  -----------
  ospf:  Compile fixes for gcc 4.6

Original patch by:
Jose Manuel dos Santos Calhariz <jose.spam at netvisao.pt>

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: fa334a90576b2067aead7f49a404230b63b202e8
      https://github.com/greearb/xorp.ct/commit/fa334a90576b2067aead7f49a404230b63b202e8
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-25 (Mon, 25 Jul 2011)

  Changed paths:
    M xorp/pim/pim_mrt_mfc.cc
  M xorp/pim/pim_proto_assert.cc
  M xorp/pim/pim_proto_join_prune.cc
  M xorp/pim/pim_proto_join_prune_message.cc
  M xorp/pim/pim_proto_register_stop.cc

  Log Message:
  -----------
  pim:  Compile fixes for gcc 4.6

Original patch by:
Jose Manuel dos Santos Calhariz <jose.spam at netvisao.pt>

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: a003c5332e21d5ab8b6953ee46880d2bfa1fad73
      https://github.com/greearb/xorp.ct/commit/a003c5332e21d5ab8b6953ee46880d2bfa1fad73
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-07-25 (Mon, 25 Jul 2011)

  Changed paths:
    M xorp/rib/register_server.cc
  M xorp/rib/rt_tab_origin.cc
  M xorp/rib/tools/show_distances.cc
  M xorp/rib/tools/show_routes.cc

  Log Message:
  -----------
  rib:  Compile fixes for 4.6

Original patch by:
Jose Manuel dos Santos Calhariz <jose.spam at netvisao.pt>

Signed-off-by: Ben Greear <greearb at candelatech.com>


Compare: https://github.com/greearb/xorp.ct/compare/88a1e20...a003c53


From greearb at candelatech.com  Mon Jul 25 11:25:04 2011
From: greearb at candelatech.com (Ben Greear)
Date: Mon, 25 Jul 2011 11:25:04 -0700
Subject: [Xorp-hackers] Compiling xorp 1.8.3 for Debian using g++-4.6
In-Reply-To: <4E2DA2E8.9000406@candelatech.com>
References: <20110723132730.GA32689@calhariz.com>	<4E2B04D4.508@candelatech.com>	<20110724220234.GA11883@calhariz.com>	<20110725170542.GA11579@calhariz.com>
	<4E2DA2E8.9000406@candelatech.com>
Message-ID: <4E2DB500.5050301@candelatech.com>

On 07/25/2011 10:07 AM, Ben Greear wrote:
> On 07/25/2011 10:05 AM, Jose Manuel dos Santos Calhariz wrote:
>> On Sun, Jul 24, 2011 at 11:02:34PM +0100, Jose Manuel dos Santos Calhariz wrote:
>>> On Sat, Jul 23, 2011 at 10:28:52AM -0700, Ben Greear wrote:
>>>> On 07/23/2011 06:27 AM, Jose Manuel dos Santos Calhariz wrote:
>>>>>
>>>>> I am packaging xorp 1.8.3 for Debian.  The default compiler is now g++
>>>>> v4.6.  This compiler is more stricter than previous versions.
>>>>>
>>>>> This g++ have one new warnings:
>>>>>
>>>>>     -Wunused-but-set-variable
>>>>>
>>>>> This warning when used with -Werror causes a fail to build.  The
>>>>> position on Debian is to fix the problems on the source code instead
>>>>> of using the flag -Wno-error=unused-but-set-variable for disabling the
>>>>> warning.
>>>>>
>>>>> I am asking if this problem is solved in the git repository or if will
>>>>> be fixed in the near future.  Maybe this is a simple fix and is enough
>>>>> to comment out the affected variables.
>>>>
>>>> Some may be solved in git, and if not, patches are welcome.
>>>
>>> Here goes a draft of the patches.  This page explains the warning and
>>> how to solve it http://lists.fedoraproject.org/pipermail/devel/2011-February/148523.html
>>>
>>> For solving the errors, I have used various strategies:
>>>
>>>    - Looks to be old forgotten code, so I commented the variable
>>>    definition.
>>>
>>>    - Variable and the the code looks to do nothing, so I
>>>    commented everything.
>>>
>>>    - The variable is not used because of a #ifdef, so I put the
>>>    same #ifdef around the variable.
>>>
>>>    - The variable is not used because of a macro, so I used
>>>    "__attribute__((__unused__))" in the definition of it.
>>>
>>>    - The function that calculates the value of the variable may have
>>> side effects, so I used "__attribute__((__unused__))"
>>>
>>> I am not familiar with the xorp code and my c++ skills are very rusty,
>>> so most probably I missed something.  I looked into git hub, but the
>>> code looked to be the same in the affected areas.
>>>
>>> In attach follows a tar file with the patches.  The resulting code
>>> compiles, but I have not run the compiled binary.
>>
>> I missed a warning/error on file contrib/olsr/face_manager.cc.  Here
>> goes an update to one of the patches.
>
> Thanks for these.  It will probably be a day or two before I can review
> and apply them, but I'll try to get on it quickly.

Ok, I found some time...

I just pushed modified versions of these patches to github.  Please see
if that builds for you, and if not, please send me the compile warnings/errors.

Thanks,
Ben


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


From jose.spam at netvisao.pt  Mon Jul 25 16:26:56 2011
From: jose.spam at netvisao.pt (Jose Manuel dos Santos Calhariz)
Date: Tue, 26 Jul 2011 00:26:56 +0100
Subject: [Xorp-hackers] Fix a typo in man page xorpsh.1
Message-ID: <20110725232656.GA14008@calhariz.com>

Thank you for you quick analisys of my proposed fix for compiling xorp
on g++ v4.6.  I have incorporated most of you changes on the fix for
the Debian package.

There is a small typo in the manage of xorpsh, that is fixed on the
Debian package but on git.  I should have sent this patch long time ago.
Could you please apply the following patch?

    TIA
Jose Calhariz


===================================================================
--- xorpsh.1    (revision 187)
+++ xorpsh.1    (revision 192)
@@ -31,7 +31,7 @@
 be permitted to make changes to the running router configuration, that user
 needs to be in the Unix group \fBxorp\fR.
 .PP
-The Debian package installation automaticall sets up both a xorp user
+The Debian package installation automatically sets up both a xorp user
 and a xorp group to which this user belongs. However, any user can run the
 \fBxorpsh\fR command unless locally restricted by the
 administrator.
@@ -65,3 +65,4 @@
 please see \fB/usr/share/doc/xorp/copyright\fP.

 .\" created by instant / docbook-to-man, Sat 25 Aug 2007, 02:37
+.\" manually edit for fixing a typo / Jose Calhariz, Mon 25 Jul 2011, 22:42
Index: xorpsh.sgml
===================================================================
--- xorpsh.sgml (revision 187)
+++ xorpsh.sgml (revision 192)
@@ -4,7 +4,7 @@
   <!ENTITY dhfirstname "<firstname>Javier</firstname>">
   <!ENTITY dhsurname   "<surname>Fernandez-Sanguino</surname>">
   <!-- Please adjust the date whenever revising the manpage. -->
-  <!ENTITY dhdate      "<date>August 24th, 2007</date>">
+  <!ENTITY dhdate      "<date>July 25th, 2011</date>">
   <!ENTITY dhsection   "<manvolnum>1</manvolnum>">
   <!ENTITY dhemail     "<email>jfs at debian.org</email>">
   <!ENTITY dhusername  "Javier Fernandez-Sanguino">
@@ -87,7 +87,7 @@
     be permitted to make changes to the running router configuration, that user
     needs to be in the Unix group <command>xorp</command>.</para>

-    <para>The Debian package installation automaticall sets up both a xorp user
+    <para>The Debian package installation automatically sets up both a xorp user
     and a xorp group to which this user belongs. However, any user can run the
     <command>&dhcmd;</command> command unless locally restricted by the
     administrator.</para>


-- 
--

Capoeira que ? bom, n?o cai; e se um dia ele cai, cai bem

--Vinicius de Moraes


From jose.spam at netvisao.pt  Tue Jul 26 02:23:03 2011
From: jose.spam at netvisao.pt (Jose Manuel dos Santos Calhariz)
Date: Tue, 26 Jul 2011 10:23:03 +0100
Subject: [Xorp-hackers] Compiling xorp 1.8.3 for Debian using g++-4.6
In-Reply-To: <4E2DB500.5050301@candelatech.com>
References: <20110723132730.GA32689@calhariz.com>
	<4E2B04D4.508@candelatech.com>
	<20110724220234.GA11883@calhariz.com>
	<20110725170542.GA11579@calhariz.com>
	<4E2DA2E8.9000406@candelatech.com>
	<4E2DB500.5050301@candelatech.com>
Message-ID: <20110726092303.GA26037@calhariz.com>

On Mon, Jul 25, 2011 at 11:25:04AM -0700, Ben Greear wrote:
> On 07/25/2011 10:07 AM, Ben Greear wrote:
> >On 07/25/2011 10:05 AM, Jose Manuel dos Santos Calhariz wrote:
> >>On Sun, Jul 24, 2011 at 11:02:34PM +0100, Jose Manuel dos Santos Calhariz wrote:
> >>>On Sat, Jul 23, 2011 at 10:28:52AM -0700, Ben Greear wrote:
> >>>>On 07/23/2011 06:27 AM, Jose Manuel dos Santos Calhariz wrote:
> >>>>>
> >>>>>I am packaging xorp 1.8.3 for Debian.  The default compiler is now g++
> >>>>>v4.6.  This compiler is more stricter than previous versions.
> >>>>>
> >>>>>This g++ have one new warnings:
> >>>>>
> >>>>>    -Wunused-but-set-variable
> >>>>>
> >>>>>This warning when used with -Werror causes a fail to build.  The
> >>>>>position on Debian is to fix the problems on the source code instead
> >>>>>of using the flag -Wno-error=unused-but-set-variable for disabling the
> >>>>>warning.
> >>>>>
> >>>>>I am asking if this problem is solved in the git repository or if will
> >>>>>be fixed in the near future.  Maybe this is a simple fix and is enough
> >>>>>to comment out the affected variables.
> >>>>
> >>>>Some may be solved in git, and if not, patches are welcome.
> >>>
> >>>Here goes a draft of the patches.  This page explains the warning and
> >>>how to solve it http://lists.fedoraproject.org/pipermail/devel/2011-February/148523.html
> >>>
> >>>For solving the errors, I have used various strategies:
> >>>
> >>>   - Looks to be old forgotten code, so I commented the variable
> >>>   definition.
> >>>
> >>>   - Variable and the the code looks to do nothing, so I
> >>>   commented everything.
> >>>
> >>>   - The variable is not used because of a #ifdef, so I put the
> >>>   same #ifdef around the variable.
> >>>
> >>>   - The variable is not used because of a macro, so I used
> >>>   "__attribute__((__unused__))" in the definition of it.
> >>>
> >>>   - The function that calculates the value of the variable may have
> >>>side effects, so I used "__attribute__((__unused__))"
> >>>
> >>>I am not familiar with the xorp code and my c++ skills are very rusty,
> >>>so most probably I missed something.  I looked into git hub, but the
> >>>code looked to be the same in the affected areas.
> >>>
> >>>In attach follows a tar file with the patches.  The resulting code
> >>>compiles, but I have not run the compiled binary.
> >>
> >>I missed a warning/error on file contrib/olsr/face_manager.cc.  Here
> >>goes an update to one of the patches.
> >
> >Thanks for these.  It will probably be a day or two before I can review
> >and apply them, but I'll try to get on it quickly.
> 
> Ok, I found some time...
> 
> I just pushed modified versions of these patches to github.  Please see
> if that builds for you, and if not, please send me the compile
> warnings/errors.

I have looked into your patches and updated my patches for xorp 1.8.3.
They are similar now.  My patches have more comments for
documentation.  For helping if someone else needs to updated the
Debian package before the next xorp release.

The xorp compiles and runs "scons check" with g++ 4.4 on Debian stable
and g++ 4.6 on unstable.

Thank you for your prompt review.

> 
> Thanks,
> Ben
> 
> 

     Jose Calhariz

-- 
--

Por tr?s de toda fortuna h? um crime

--Honor? de Balzac