[Xorp-hackers] Some fixes to OLSR (topology.cc)

[Ben Greear]

On 06/14/2011 11:12 AM, Philip Hugg wrote:
> On 14/06/2011 12:29 PM, Ben Greear wrote:
>> On 06/14/2011 05:46 AM, Philip Hugg wrote:
>>
>>> I've included file 'topology.cc.patch'. Generated by
>>> 'diff -uEw modified original > topology.cc.patch'.
>>> Is this OK?
>>
>> You should put the original first to generate a proper patch,
>> but I can fix that manually in this case.
>>
>> If you remember, can you describe what this fix fixes?
>>
>> Thanks,
>> Ben
>>
>>
> Ben,
>
> Sorry about the patch file.
>
> The modifications generally fixes and stabilizes the entries in the
> OLSR's topology information base.
>
> Fix 1- File -> topology.cc, method-> update_tc_entry(...).
> This was a programmatic fix. The code would find and set 'is_found =
> true' on an entry that really
> didn't exist. The modification now does a more precise check of the entry.
>
> Fix 2- method -> apply_tc_ansn(...)
> This was an RFC fix. This seemed to have been forgotten during
> implementation. See RFC section 9.5,
> paragraphs 2 and 3.
>
> I hope this helps!

Thanks for the patches.  I committed these and pushed them
upstream.

Thanks,
Ben

> Phil.
>


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com