[Xorp-hackers] [greearb/xorp.ct] 350e78: Simplifying (a)synchronous conditional compilation...

[noreply at github.com]

Branch: refs/heads/master
Home:   https://github.com/greearb/xorp.ct

Commit: 350e78bdb86f58f0bc46cc4f0548c0ec598b732c
    https://github.com/greearb/xorp.ct/commit/350e78bdb86f58f0bc46cc4f0548c0ec598b732c
Author: Steven Simpson <ss at comp.lancs.ac.uk>
Date:   2011-03-31 (Thu, 31 Mar 2011)

Changed paths:
  M xorp/libxipc/finder_client.cc
  M xorp/libxipc/finder_client.hh
  M xorp/libxipc/finder_client_xrl_target.cc
  M xorp/libxipc/finder_client_xrl_target.hh
  M xorp/libxipc/finder_messenger.cc
  M xorp/libxipc/finder_messenger.hh
  M xorp/libxipc/xrl_cmd_map.hh
  M xorp/libxipc/xrl_dispatcher.cc
  M xorp/libxipc/xrl_dispatcher.hh
  M xorp/libxipc/xrl_pf_stcp.cc
  M xorp/libxipc/xrl_router.cc
  M xorp/libxipc/xrl_router.hh

Log Message:
-----------
Simplifying (a)synchronous conditional compilation:

* XrlDispatcher is unconditionally asynchronous - all its conditional
  macros and typedefs are dropped.  Where XrlRouter derives from it,
  it is also unconditionally asynchronous.

* Many callback functions, that were conditionally added in order to
  interface with asynchronous dispatchers and command maps, are now
  compiled unconditionally.

* FinderClient's dispatch_tunneled_xrl uses XrlDispatcher's
  asynchronous interface, but ignores the results as its synchronous
  version always did, so its own synchronous interface is now
  presented unconditionally, obviating the inelegant
  XRL_CMD_OPT_CALLBACK macro.

* FinderClientXrlTarget is reverted to its fully synchronous form, as
  it can now use FinderClient's unconditionally synchronous interface.

* Synchronous code in FinderMessengerBase::dispatch_xrl uses (now
  unconditionally compiled) callback required for asynchronous
  version.

* Re-organized conditional command-map typedefs to make callback type
  unconditional.

Signed-off-by: Steven Simpson <ss at comp.lancs.ac.uk>