[Xorp-hackers] [greearb/xorp.ct] 794ab6: event-loop: Remove dead code, make sure win-dispa...

noreply at github.com noreply at github.com
Wed Sep 7 14:49:59 PDT 2011


  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct

  Commit: 794ab62774ae03baa93d1914dadc9bd313d5bb90
      https://github.com/greearb/xorp.ct/commit/794ab62774ae03baa93d1914dadc9bd313d5bb90
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-09-07 (Wed, 07 Sep 2011)

  Changed paths:
    M xorp/libxorp/eventloop.cc
  M xorp/libxorp/eventloop.hh
  M xorp/libxorp/timeval.cc
  M xorp/libxorp/timeval.hh
  M xorp/libxorp/win_dispatcher.cc
  M xorp/libxorp/win_dispatcher.hh

  Log Message:
  -----------
  event-loop:  Remove dead code, make sure win-dispatcher handles all events.

Remove aggressiveness and some #if 0 priority code from event loop.
Neither is a good idea in my mind...the aggressiveness was playing dangerous
tricks just to save a gettimeofday call, and the prioritization could cause
priority inversion locks as implemented.

Update win-dispatcher to make sure to process all descriptors that have events
on them each time we do a wait-and-dispatch.  This should increase fairness
on heavily loaded systems.

Add debug logic to eventloop to print out cases where things take longer than
expected.  Need more debugging in this area to find out exactly what is
causing the slowdowns...

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: b167b0d1e600f9ad440b2b5cdf2818a7a65bc4fc
      https://github.com/greearb/xorp.ct/commit/b167b0d1e600f9ad440b2b5cdf2818a7a65bc4fc
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-09-07 (Wed, 07 Sep 2011)

  Changed paths:
    M xorp/libxorp/debug.h
  M xorp/libxorp/eventloop.cc
  M xorp/libxorp/eventloop.hh
  M xorp/libxorp/win_dispatcher.cc

  Log Message:
  -----------
  event-loop:  Make environ-trace object generic, warn of slow win-dispatcher callbacks.

Signed-off-by: Ben Greear <greearb at candelatech.com>


Compare: https://github.com/greearb/xorp.ct/compare/c258fd4...b167b0d



More information about the Xorp-hackers mailing list