[Xorp-hackers] [PATCH] Support for IEEE754 binary64 format in XRLs

[Ben Greear]

On 09/13/2011 11:14 AM, Joe Coco wrote:
> That got me as far as here:
>
> libcomm/comm_sock.c: In function 'comm_sock_bind4':
> libcomm/comm_sock.c:302:28: error: 'u_char' undeclared (first use in this function)

I'm trying to hack through these now...

Ben

> libcomm/comm_sock.c:302:28: note: each undeclared identifier is reported only once for each function it appears in
> libcomm/comm_sock.c:302:35: error: expected ';' before 'family'
> libcomm/comm_sock.c: In function 'comm_sock_bind6':
> libcomm/comm_sock.c:342:30: error: 'u_char' undeclared (first use in this function)
> libcomm/comm_sock.c:342:37: error: expected ';' before 'family'
> libcomm/comm_sock.c: In function 'comm_sock_connect4':
> libcomm/comm_sock.c:584:28: error: 'u_char' undeclared (first use in this function)
> libcomm/comm_sock.c:584:35: error: expected ';' before 'family'
> libcomm/comm_sock.c: In function 'comm_sock_connect6':
> libcomm/comm_sock.c:640:30: error: 'u_char' undeclared (first use in this function)
> libcomm/comm_sock.c:640:37: error: expected ';' before 'family'
> libcomm/comm_sock.c: In function 'comm_set_loopback':
> libcomm/comm_sock.c:981:2: error: 'u_char' undeclared (first use in this function)
> libcomm/comm_sock.c:981:9: error: expected ';' before 'loop'
> libcomm/comm_sock.c:984:10: error: 'loop' undeclared (first use in this function)
> libcomm/comm_sock.c: In function 'comm_set_multicast_ttl':
> libcomm/comm_sock.c:1167:2: error: 'u_char' undeclared (first use in this function)
> libcomm/comm_sock.c:1167:9: error: expected ';' before 'ip_multicast_ttl'
> libcomm/comm_sock.c:1170:10: error: 'ip_multicast_ttl' undeclared (first use in this function)
> libcomm/comm_sock.c: In function 'comm_set_bindtodevice':
> libcomm/comm_sock.c:1298:21: error: 'IFNAMSIZ' undeclared (first use in this function)
>
> -----Original Message-----
> From: Ben Greear [mailto:greearb at candelatech.com]
> Sent: Tuesday, September 13, 2011 1:51 PM
> To: Joe Coco
> Cc: Steven Simpson; xorp-hackers at icir.org
> Subject: Re: [Xorp-hackers] [PATCH] Support for IEEE754 binary64 format in XRLs
>
> On 09/13/2011 09:48 AM, Joe Coco wrote:
>> Explodes on one of my systems as well.  Errors are identical.  32bit, linux 2.6.32, glibc 2.3, Pentium4.
>
> Mine will compile that file if I pass -std=c99 to the gcc options.  I'll try adding that globally and see if that works elsewhere as well...
>
> Anyone see any problems with using that?
>
> Thanks,
> Ben
>
>>
>> -- Joe
>>
>> -----Original Message-----
>> From: xorp-hackers-bounces at icir.org
>> [mailto:xorp-hackers-bounces at icir.org] On Behalf Of Ben Greear
>> Sent: Tuesday, September 13, 2011 12:29 PM
>> To: Steven Simpson
>> Cc: xorp-hackers at icir.org
>> Subject: Re: [Xorp-hackers] [PATCH] Support for IEEE754 binary64
>> format in XRLs
>>
>> On 09/13/2011 09:21 AM, Steven Simpson wrote:
>>> On 13/09/11 17:14, Ben Greear wrote:
>>>> ./libxipc/xrl_atom.hh: In constructor ‘XrlAtom::XrlAtom(const
>>>> fp64_t&)’:
>>>> ./libxipc/xrl_atom.hh:336: warning: converting to ‘uint64_t’
>>>> from ‘const double’
>>>
>>> D'oh!
>>>
>>>         // fp64 constructors
>>>         explicit XrlAtom(const fp64_t&     value)
>>> 	: _type(xrlatom_fp64), _have_data(true), _own(true), _u64val(value)
>>> {}
>>>
>>> That _u64val should, of course, be _fp64val!
>>
>> I figured that...but then it blows up again:
>>
>> Maybe something funky with how math.h works on this system...
>>
>> cc1: warnings being treated as errors
>> libxipc/fp64serial.c: In function ‘fp64enc’:
>> libxipc/fp64serial.c:58: warning: implicit declaration of function ‘fpclassify’
>> libxipc/fp64serial.c:58: warning: nested extern declaration of ‘fpclassify’
>> libxipc/fp64serial.c:63: error: ‘FP_ZERO’ undeclared (first use in
>> this function)
>> libxipc/fp64serial.c:63: error: (Each undeclared identifier is
>> reported only once
>> libxipc/fp64serial.c:63: error: for each function it appears in.)
>> libxipc/fp64serial.c:64: warning: implicit declaration of function ‘signbit’
>> libxipc/fp64serial.c:69: error: ‘FP_INFINITE’ undeclared (first use in
>> this function)
>> libxipc/fp64serial.c:75: error: ‘FP_NAN’ undeclared (first use in this
>> function)
>> libxipc/fp64serial.c:81: error: ‘FP_SUBNORMAL’ undeclared (first use
>> in this function)
>> libxipc/fp64serial.c:82: error: ‘FP_NORMAL’ undeclared (first use in
>> this function)
>> libxipc/fp64serial.c: In function ‘fp64dec’:
>> libxipc/fp64serial.c:151: error: ‘INFINITY’ undeclared (first use in
>> this function)
>> libxipc/fp64serial.c:152: error: ‘NAN’ undeclared (first use in this
>> function)
>> scons: *** [obj/i686-pc-linux-gnu/libxipc/fp64serial.os] Error 1
>> scons: building terminated because of errors.
>>
>>>
>>> Sorry!
>>>
>>> _______________________________________________
>>> Xorp-hackers mailing list
>>> Xorp-hackers at icir.org
>>> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers
>>
>>
>> --
>> Ben Greear<greearb at candelatech.com>
>> Candela Technologies Inc  http://www.candelatech.com
>>
>> _______________________________________________
>> Xorp-hackers mailing list
>> Xorp-hackers at icir.org
>> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers
>
>
> --
> Ben Greear<greearb at candelatech.com>
> Candela Technologies Inc  http://www.candelatech.com
>


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com