[Xorp-hackers] [greearb/xorp.ct] 7801b0: pim: Add some memory debugging.

[noreply at github.com]

  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct

  Commit: 7801b00f7c2f4d068fc40a68e4c973b9d61c3b2a
      https://github.com/greearb/xorp.ct/commit/7801b00f7c2f4d068fc40a68e4c973b9d61c3b2a
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-09-19 (Mon, 19 Sep 2011)

  Changed paths:
    M xorp/libxorp/service.hh
  M xorp/pim/pim_mre.cc
  M xorp/pim/pim_mre.hh
  M xorp/pim/pim_mrt.cc
  M xorp/pim/pim_mrt.hh
  M xorp/pim/pim_proto.h

  Log Message:
  -----------
  pim: Add some memory debugging.

I'm seeing crashes in PimMre when accessing _pim_mrt.
Perhaps something I caused recently, but also possibly
some old bugs that are now more visible...

Add some memory debugging logic to help track it down.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 7d29e8e05dc2625cc8f9cf6d1a14108b8cbb40ff
      https://github.com/greearb/xorp.ct/commit/7d29e8e05dc2625cc8f9cf6d1a14108b8cbb40ff
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-09-19 (Mon, 19 Sep 2011)

  Changed paths:
    M xorp/ospf/packet.hh
  M xorp/ospf/peer.hh

  Log Message:
  -----------
  ospf:  Initialize some variables.

This fixes some warnings found by valgrind.  Probably not
a serious problem, however.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: b7feb06bab16ec61680d7d568e5b9dfce83af610
      https://github.com/greearb/xorp.ct/commit/b7feb06bab16ec61680d7d568e5b9dfce83af610
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-09-19 (Mon, 19 Sep 2011)

  Changed paths:
    M xorp/libxorp/eventloop.cc
  M xorp/libxorp/eventloop.hh
  M xorp/libxorp/run_command.hh
  M xorp/libxorp/timer.cc
  M xorp/libxorp/timer.hh

  Log Message:
  -----------
  libxorp:  Allow un-registering timers.

This can help objects clean up their timers when they
are being destructed.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 2a15d7bddb7a0f2ddd8385ab5f6c814e85dcfdac
      https://github.com/greearb/xorp.ct/commit/2a15d7bddb7a0f2ddd8385ab5f6c814e85dcfdac
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-09-19 (Mon, 19 Sep 2011)

  Changed paths:
    M xorp/mrt/mrt.hh

  Log Message:
  -----------
  mrt:  Initialize iterators to know values.

Noticed this while looking for another bug.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 0f1a000766845de8964cd2a9e06094628e7af41e
      https://github.com/greearb/xorp.ct/commit/0f1a000766845de8964cd2a9e06094628e7af41e
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-09-19 (Mon, 19 Sep 2011)

  Changed paths:
    M xorp/rib/protocol.hh
  M xorp/rib/rib.cc
  M xorp/rib/rib.hh

  Log Message:
  -----------
  rib:  Fix memory leak in rib.

This probably only happens on teardown..found with valgrind.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 3405bb487a052c305fba84d7ea62afadc383c614
      https://github.com/greearb/xorp.ct/commit/3405bb487a052c305fba84d7ea62afadc383c614
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-09-19 (Mon, 19 Sep 2011)

  Changed paths:
    M xorp/pim/pim_bsr.hh
  M xorp/pim/pim_mre.cc
  M xorp/pim/pim_mre.hh
  M xorp/pim/pim_node.cc

  Log Message:
  -----------
  pim:  Fix recently added bugs.

There were two bugs in the code I recently added to pim.  First, the
order of variables in PimMre is vital:  You have to initialize pim_mrt
before you can init some of the others (which use _pim_mrt).

The DELETE_BUFFER call needs a check for null.

Also, re-ordered the class so that all the data members were
private so that it is easier to see data v/s methods in
the header file.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 519c22cce6551bf298d6a67f0c210c9d81a467d0
      https://github.com/greearb/xorp.ct/commit/519c22cce6551bf298d6a67f0c210c9d81a467d0
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-09-19 (Mon, 19 Sep 2011)

  Changed paths:
    M xorp/rtrmgr/module_manager.cc
  M xorp/rtrmgr/module_manager.hh
  M xorp/rtrmgr/task.cc
  M xorp/rtrmgr/task.hh
  M xorp/rtrmgr/xorp_client.cc
  M xorp/rtrmgr/xorp_client.hh

  Log Message:
  -----------
  rtrmgr:  Remove some timers in destructors.

While running under valgrind, I found some errors that appeared to
be timers firing after their objects were deleted.  Explicitly
clean up any timers in some of the destructors.

Signed-off-by: Ben Greear <greearb at candelatech.com>


Compare: https://github.com/greearb/xorp.ct/compare/aa3da4a...519c22c