[Xorp-hackers] [greearb/xorp.ct] f1c7c8: fea: Re-arrange netlink parsing logic.

noreply at github.com noreply at github.com
Fri Sep 23 14:26:03 PDT 2011


  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct

  Commit: f1c7c8cfc27cc6168b5ad38528ae443507a771bd
      https://github.com/greearb/xorp.ct/commit/f1c7c8cfc27cc6168b5ad38528ae443507a771bd
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-09-23 (Fri, 23 Sep 2011)

  Changed paths:
    M xorp/fea/data_plane/control_socket/netlink_socket_utilities.cc
  M xorp/fea/data_plane/control_socket/netlink_socket_utilities.hh
  M xorp/fea/data_plane/ifconfig/SConscript
  M xorp/fea/data_plane/ifconfig/ifconfig_get_netlink_socket.cc
  R xorp/fea/data_plane/ifconfig/ifconfig_parse_netlink_socket.cc

  Log Message:
  -----------
  fea:  Re-arrange netlink parsing logic.

Move static methods into NlmUtils file, ifconfig_get_netlink_socket
method from ifconfig_parse_nelink_socket to ifconfig_get_netlink_socket.cc

Should make it easier to find the code in question.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: efeec217311c0327c594b4b1ce1a07d395c40618
      https://github.com/greearb/xorp.ct/commit/efeec217311c0327c594b4b1ce1a07d395c40618
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-09-23 (Fri, 23 Sep 2011)

  Changed paths:
    M xorp/fea/data_plane/control_socket/netlink_socket_utilities.cc

  Log Message:
  -----------
  fea:  Fix GRE tunnel IP addresses on Linux.

The old code used the 'link-level' IP address, ie the IP
that GRE is using underneath, as one of the GRE interface's
IP addresses.  I see no reason to do this, and it appears to
mess up multicast over GRE tunnels.

Since there were two addresses, it was a bit of a race as to which
one won, which might be why sometimes multicast over GRE
somewhat worked.

Reported-by: J G Miller <miller at yoyo.ORG>
Signed-off-by: Ben Greear <greearb at candelatech.com>


Compare: https://github.com/greearb/xorp.ct/compare/d827185...efeec21



More information about the Xorp-hackers mailing list