[Xorp-hackers] [PATCH 1/3] SConstruct fixes

[Ben Greear]

On 09/27/2011 04:30 AM, Igor Maravic wrote:
> Signed-off-by: Igor Maravic<igorm at etf.rs>
> ---
> :100644 100644 955e743... 9f5dd79... M	xorp/SConstruct
>   xorp/SConstruct |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/xorp/SConstruct b/xorp/SConstruct
> index 955e743..9f5dd79 100644
> --- a/xorp/SConstruct
> +++ b/xorp/SConstruct
> @@ -713,7 +713,7 @@ if not env['optimize'] == 'override':
>                    'highest': '-O3',
>                    'size': '-Os' }
>       bigoflag = bigodict[env['optimize']]
> -    if not env['optimize'] == 'no':
> +    if not env['optimize'] == 'override':
>           env.AppendUnique(CFLAGS = [ bigoflag ])
>           env.AppendUnique(CXXFLAGS = [ bigoflag ])

Can that check ever be false?  I think it cannot.  And if it cannot,
then I do not want to apply this patch.

The reason I suggested adding none is if someone wants to use the
compiler default and not use any -O option (which supports the
current optimize=no behaviour in case someone finds that useful).

Thanks,
Ben


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com