[Xorp-hackers] [greearb/xorp.ct] cd5913: xlog: Simplify xlog framework.

[noreply at github.com]

  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct

  Commit: cd59132234942330d01af1686a0cfa17d7787a53
      https://github.com/greearb/xorp.ct/commit/cd59132234942330d01af1686a0cfa17d7787a53
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-09-29 (Thu, 29 Sep 2011)

  Changed paths:
    M xorp/libxorp/xlog.c
  M xorp/libxorp/xlog.h
  M xorp/rtrmgr/module_manager.cc

  Log Message:
  -----------
  xlog: Simplify xlog framework.

Try to check levels in the macros,
before calling any functions.  This should keep us
from evaluating all of the foo.str().c_str() logic
in un-used tracing code.

Remove un-used locking code in xlog.*

Remove macro-generated functions..they are not
needed at all.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 6a8b70cb6ed5e8a737cce546ae281608a6ffe75c
      https://github.com/greearb/xorp.ct/commit/6a8b70cb6ed5e8a737cce546ae281608a6ffe75c
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-09-30 (Fri, 30 Sep 2011)

  Changed paths:
    M xorp/ospf/peer.cc

  Log Message:
  -----------
  ospf:  Remove some overly verbose trace debugging.

This just spammed logs with info that wasn't much use.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 1a954c6b31fef1d31f3a0e9f1ef431adf460d431
      https://github.com/greearb/xorp.ct/commit/1a954c6b31fef1d31f3a0e9f1ef431adf460d431
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-09-30 (Fri, 30 Sep 2011)

  Changed paths:
    M xorp/ospf/xorp_ospfv2.cc

  Log Message:
  -----------
  ospf:  Set trace logging verbosity to high.

This causes file:line numbers to be printed in the tracing
messages, which is a big help for debugging.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 5eb7467144b4a17244179bf0fe7d279f163c3031
      https://github.com/greearb/xorp.ct/commit/5eb7467144b4a17244179bf0fe7d279f163c3031
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-09-30 (Fri, 30 Sep 2011)

  Changed paths:
    M xorp/ospf/peer.cc
  M xorp/ospf/peer.hh

  Log Message:
  -----------
  ospf:  Fix bad lsa retransmit timer bug.

A user reported very slow OSPF convergence times when
xorp was connected to a larger OSPF network.  The root
cause is that the LSA retransmit timer could get in a state
where it rarely if ever fired due to it being constantly
reset whenever an LSA arrived.

It would eventually go to Full when all of the LSAs were
(re)flooded to it, but this could take many minutes.

The fix is to not restart the timer if it is already running.

This bug appears to be quite old.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 0598d01ff03f2ab5d71b2b79cf366e565e85c998
      https://github.com/greearb/xorp.ct/commit/0598d01ff03f2ab5d71b2b79cf366e565e85c998
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2011-09-30 (Fri, 30 Sep 2011)

  Changed paths:
    M xorp/ospf/peer.cc

  Log Message:
  -----------
  ospf:  Improve some debugging messages.

This proved helpful when tracking down the OSPF retransmit
timer bug.

Signed-off-by: Ben Greear <greearb at candelatech.com>


Compare: https://github.com/greearb/xorp.ct/compare/8ca3b19...0598d01