[Xorp-hackers] [greearb/xorp.ct] 9c9053: fea: Remove const-ness from netlink objects.

GitHub noreply at github.com
Tue Jun 5 20:44:35 PDT 2012


  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct
  Commit: 9c9053ff92ba66697747fb24c5f238dfb157a3db
      https://github.com/greearb/xorp.ct/commit/9c9053ff92ba66697747fb24c5f238dfb157a3db
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-06-05 (Tue, 05 Jun 2012)

  Changed paths:
    M xorp/fea/data_plane/control_socket/netlink_socket.cc
    M xorp/fea/data_plane/control_socket/netlink_socket.hh
    M xorp/fea/data_plane/control_socket/netlink_socket_utilities.cc
    M xorp/fea/data_plane/control_socket/netlink_socket_utilities.hh
    M xorp/fea/data_plane/control_socket/windows_rtm_pipe.hh
    M xorp/fea/data_plane/fibconfig/fibconfig_entry_get_netlink_socket.cc
    M xorp/fea/data_plane/fibconfig/fibconfig_entry_get_netlink_socket.hh
    M xorp/fea/data_plane/fibconfig/fibconfig_entry_observer_dummy.cc
    M xorp/fea/data_plane/fibconfig/fibconfig_entry_observer_dummy.hh
    M xorp/fea/data_plane/fibconfig/fibconfig_entry_observer_iphelper.cc
    M xorp/fea/data_plane/fibconfig/fibconfig_entry_observer_iphelper.hh
    M xorp/fea/data_plane/fibconfig/fibconfig_entry_observer_netlink_socket.cc
    M xorp/fea/data_plane/fibconfig/fibconfig_entry_observer_netlink_socket.hh
    M xorp/fea/data_plane/fibconfig/fibconfig_table_get_netlink_socket.hh
    M xorp/fea/data_plane/fibconfig/fibconfig_table_observer_dummy.cc
    M xorp/fea/data_plane/fibconfig/fibconfig_table_observer_dummy.hh
    M xorp/fea/data_plane/fibconfig/fibconfig_table_observer_iphelper.cc
    M xorp/fea/data_plane/fibconfig/fibconfig_table_observer_iphelper.hh
    M xorp/fea/data_plane/fibconfig/fibconfig_table_observer_netlink_socket.cc
    M xorp/fea/data_plane/fibconfig/fibconfig_table_observer_netlink_socket.hh
    M xorp/fea/data_plane/fibconfig/fibconfig_table_observer_rtmv2.cc
    M xorp/fea/data_plane/fibconfig/fibconfig_table_observer_rtmv2.hh
    M xorp/fea/data_plane/fibconfig/fibconfig_table_parse_netlink_socket.cc
    M xorp/fea/data_plane/ifconfig/ifconfig_get_netlink_socket.cc
    M xorp/fea/data_plane/ifconfig/ifconfig_get_netlink_socket.hh
    M xorp/fea/data_plane/ifconfig/ifconfig_observer_dummy.cc
    M xorp/fea/data_plane/ifconfig/ifconfig_observer_dummy.hh
    M xorp/fea/data_plane/ifconfig/ifconfig_observer_iphelper.cc
    M xorp/fea/data_plane/ifconfig/ifconfig_observer_iphelper.hh
    M xorp/fea/data_plane/ifconfig/ifconfig_observer_netlink_socket.cc
    M xorp/fea/data_plane/ifconfig/ifconfig_observer_netlink_socket.hh
    M xorp/fea/fibconfig_entry_observer.hh
    M xorp/fea/fibconfig_table_observer.hh
    M xorp/fea/ifconfig_observer.hh
    M xorp/libxorp/utils.hh

  Log Message:
  -----------
  fea:  Remove const-ness from netlink objects.

The truth is, netlink API doesn't take const arguments,
so it was all being cast away down in the code that
mattered.  This wouldn't compile on F17, so just remove
it all and make it non-const.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: d856e1232fcf7dd916c671bf7403dbe2b2270c01
      https://github.com/greearb/xorp.ct/commit/d856e1232fcf7dd916c671bf7403dbe2b2270c01
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-06-05 (Tue, 05 Jun 2012)

  Changed paths:
    M xorp/bgp/path_attribute.cc
    M xorp/bgp/path_attribute.hh
    M xorp/bgp/update_attrib.hh

  Log Message:
  -----------
  bgp: Fix const related warnings.

These errors caused build failures on Fedora 17.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: ca3909053cbe294e45edf7fde44979e008b7c08f
      https://github.com/greearb/xorp.ct/commit/ca3909053cbe294e45edf7fde44979e008b7c08f
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-06-05 (Tue, 05 Jun 2012)

  Changed paths:
    M xorp/fea/mfea_mrouter.cc

  Log Message:
  -----------
  mfea:  Fix compilation errors on Fedora 17.

The latest compiler did not like assigning a reference
to a member of a packed struct.  Use pointers instead.

Signed-off-by: Ben Greear <greearb at candelatech.com>


Compare: https://github.com/greearb/xorp.ct/compare/1359103...ca39090


More information about the Xorp-hackers mailing list