[Xorp-hackers] [greearb/xorp.ct] e62f66: trivial: ws fixes

GitHub noreply at github.com
Thu Jun 14 10:39:42 PDT 2012


  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct
  Commit: e62f66e1d3efeda0991f653c7f84d10725debfee
      https://github.com/greearb/xorp.ct/commit/e62f66e1d3efeda0991f653c7f84d10725debfee
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/SConstruct
    M xorp/fea/data_plane/control_socket/netlink_socket.cc
    M xorp/fea/data_plane/control_socket/netlink_socket.hh
    M xorp/fea/data_plane/control_socket/netlink_socket_utilities.cc
    M xorp/fea/data_plane/control_socket/netlink_socket_utilities.hh
    M xorp/fea/data_plane/ifconfig/ifconfig_get_netlink_socket.cc
    M xorp/fea/data_plane/ifconfig/ifconfig_get_netlink_socket.hh
    M xorp/fea/data_plane/ifconfig/ifconfig_parse_getifaddrs.cc
    M xorp/fea/data_plane/ifconfig/ifconfig_set_netlink_socket.cc
    M xorp/fea/data_plane/ifconfig/ifconfig_set_netlink_socket.hh
    M xorp/fea/ifconfig_transaction.hh
    M xorp/fea/iftree.cc
    M xorp/fea/iftree.hh
    M xorp/fea/libfeaclient_bridge.cc
    M xorp/fea/tools/show_interfaces.cc
    M xorp/fea/xrl_fea_target.cc
    M xorp/fea/xrl_fea_target.hh
    M xorp/libfeaclient/ifmgr_atoms.cc
    M xorp/libfeaclient/ifmgr_atoms.hh
    M xorp/libfeaclient/ifmgr_cmd_queue.cc
    M xorp/libfeaclient/ifmgr_cmds.hh
    M xorp/libfeaclient/ifmgr_xrl_mirror.cc
    M xorp/libfeaclient/tests/test_local_copy.cc
    M xorp/libfeaclient/tests/test_remote_copy.cc
    M xorp/libxorp/exceptions.cc
    M xorp/libxorp/exceptions.hh
    M xorp/libxorp/nexthop.cc
    M xorp/libxorp/nexthop.hh
    M xorp/libxorp/tests/test_callback.cc
    M xorp/libxorp/tests/test_vif.cc
    M xorp/libxorp/trie.hh
    M xorp/libxorp/vif.cc
    M xorp/libxorp/vif.hh
    M xorp/policy/common/element.cc
    M xorp/rib/parser.cc
    M xorp/rib/parser_xrl_cmds.hh
    M xorp/rib/protocol.hh
    M xorp/rib/redist_policy.hh
    M xorp/rib/redist_xrl.cc
    M xorp/rib/redist_xrl.hh
    M xorp/rib/rib.cc
    M xorp/rib/rib.hh
    M xorp/rib/route.cc
    M xorp/rib/route.hh
    M xorp/rib/rt_tab_base.cc
    M xorp/rib/rt_tab_base.hh
    M xorp/rib/rt_tab_deletion.cc
    M xorp/rib/rt_tab_deletion.hh
    M xorp/rib/rt_tab_extint.cc
    M xorp/rib/rt_tab_extint.hh
    M xorp/rib/rt_tab_log.cc
    M xorp/rib/rt_tab_log.hh
    M xorp/rib/rt_tab_merged.cc
    M xorp/rib/rt_tab_merged.hh
    M xorp/rib/rt_tab_origin.cc
    M xorp/rib/rt_tab_origin.hh
    M xorp/rib/rt_tab_pol_conn.hh
    M xorp/rib/rt_tab_pol_redist.hh
    M xorp/rib/rt_tab_redist.cc
    M xorp/rib/rt_tab_redist.hh
    M xorp/rib/rt_tab_register.cc
    M xorp/rib/rt_tab_register.hh
    M xorp/rib/tests/dummy_register_server.cc
    M xorp/rib/tests/dummy_register_server.hh
    M xorp/rib/tests/rt_tab_expect.cc
    M xorp/rib/tests/rt_tab_expect.hh
    M xorp/rib/tests/test_deletion.cc
    M xorp/rib/tests/test_redist.cc
    M xorp/rib/tests/test_register.cc
    M xorp/rib/tests/test_register_xrls.cc
    M xorp/rib/tests/test_rib_direct.cc
    M xorp/rib/tests/test_rib_xrls.cc
    M xorp/rib/vifmanager.cc
    M xorp/rip/tools/show_peer_stats.cc

  Log Message:
  -----------
  trivial: ws fixes

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 96b99f18b4be9cb6b6b3605108fa098d66ae3e42
      https://github.com/greearb/xorp.ct/commit/96b99f18b4be9cb6b6b3605108fa098d66ae3e42
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/libxorp/trie.hh

  Log Message:
  -----------
  xorp: libxorp: Add operator* and operator-> to Trie iterators

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 29128b7991e73fd19fa390ef992a39350f6521d0
      https://github.com/greearb/xorp.ct/commit/29128b7991e73fd19fa390ef992a39350f6521d0
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/libxorp/trie.hh

  Log Message:
  -----------
  xorp: libxorp: Add empty() function to Trie

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 84b22b60db3921d72887394624fc95e04a9f21cd
      https://github.com/greearb/xorp.ct/commit/84b22b60db3921d72887394624fc95e04a9f21cd
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/rib/rt_tab_extint.cc
    M xorp/rib/rt_tab_extint.hh

  Log Message:
  -----------
  xorp: rib: Make lookup_next_by_igp_parent() more efficient

We now pass the iterator from where it should look for next route
instead of looping through all the routes to find it.

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 0cdf6144124e46fafecf94215e1626e600744a3d
      https://github.com/greearb/xorp.ct/commit/0cdf6144124e46fafecf94215e1626e600744a3d
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/rib/rt_tab_redist.cc

  Log Message:
  -----------
  xorp: rib: NO_LAST_NET needs not to be specialized

Same code is valid for IPv6 and IPv4 class

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 87e71fc8cc369814ee0135982db9ef2785b0322f
      https://github.com/greearb/xorp.ct/commit/87e71fc8cc369814ee0135982db9ef2785b0322f
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/rib/rt_tab_redist.cc
    M xorp/rib/rt_tab_redist.hh

  Log Message:
  -----------
  xorp: rib: Pretify the usage of RedistNetCmp<A> operator()

Defined static member of RedistNetCmp<A> so the usage of operator() would
be more intuitive.

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 2325c9229859bbe64bc57e7f5469589cfdd6cb18
      https://github.com/greearb/xorp.ct/commit/2325c9229859bbe64bc57e7f5469589cfdd6cb18
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/SConstruct
    M xorp/rib/tests/SConscript
    M xorp/rib/tests/dummy_register_server.hh
    M xorp/rib/tests/test_register_xrls.cc
    M xorp/rib/tests/test_rib_direct.cc
    M xorp/rib/tests/test_rib_xrls.cc

  Log Message:
  -----------
  xorp: rib: Enable compiling of rib tests

Tests are compiled to the {$builddir}/rib/tests
Files commands, test_rib_xrls.sh and
test_rib_direct.sh are copied to that directory also.

They are going to be compiled only if test building is enabled via
scons command line.

Added new enviroment 'builddir' to the SCons. It represents
string representation of build directory.
I needed it so the files could be copied to apropriate dir.

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 554a546a9e6d857ce5ecf96c76e226436ef26436
      https://github.com/greearb/xorp.ct/commit/554a546a9e6d857ce5ecf96c76e226436ef26436
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/rib/tests/test_rib_direct.cc

  Log Message:
  -----------
  xorp: rib: tests: RIB should be initialized before it's used

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: cb035f7ec622df0dfdfb177b3e4cd5d41c4aaece
      https://github.com/greearb/xorp.ct/commit/cb035f7ec622df0dfdfb177b3e4cd5d41c4aaece
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/rib/parser_xrl_cmds.hh

  Log Message:
  -----------
  xorp: rib: Print if command has succeded instead of printing integer

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: d33b346c8ccf9b3a0ba2386ea6ca3c3079faada1
      https://github.com/greearb/xorp.ct/commit/d33b346c8ccf9b3a0ba2386ea6ca3c3079faada1
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/rib/parser.cc

  Log Message:
  -----------
  xorp: rib: Remove unneeded printf in Uint32ArgumentParser::parse

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: c869d77767f5b1acd9c5add736d67f9a4a842b57
      https://github.com/greearb/xorp.ct/commit/c869d77767f5b1acd9c5add736d67f9a4a842b57
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/rib/tests/test_register.cc

  Log Message:
  -----------
  xorp: rib: tests: Minor fixes to function test_route_range

Release RouteRange obtained with route_range_lookup,
and prevent memory leak.

Print that we expected error, when the expected error ocures.

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 757d6c82310e57b1586923930065654ec547635d
      https://github.com/greearb/xorp.ct/commit/757d6c82310e57b1586923930065654ec547635d
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/rib/xrl_target.cc

  Log Message:
  -----------
  xorp: rib: Use const map when iterating through admin_distances

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: f01e1b8631fe6e0074550f3b8e145a90c798e0c9
      https://github.com/greearb/xorp.ct/commit/f01e1b8631fe6e0074550f3b8e145a90c798e0c9
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/rib/rib.cc
    M xorp/rib/rib.hh

  Log Message:
  -----------
  xorp: rib: Add function for finding vif by name

Added function find_vif(const string&) to avoid unnecessary
repetition in code

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 47b6afb5eb7f0e7f727b96103c987036cd86e900
      https://github.com/greearb/xorp.ct/commit/47b6afb5eb7f0e7f727b96103c987036cd86e900
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/rib/rib_manager.hh

  Log Message:
  -----------
  xorp: rib: Add const getters for uribs and mribs

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 39241062a4c5e023ebac06471eb2918fc94fd0d8
      https://github.com/greearb/xorp.ct/commit/39241062a4c5e023ebac06471eb2918fc94fd0d8
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/libxorp/range.hh

  Log Message:
  -----------
  xorp: libxorp: Added missing constructors to derived classes of Range

Constructors with two arguments, and one argument were missing
from derived classes.

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 5bc27b1c5922bc92df558239a09210647dca29c2
      https://github.com/greearb/xorp.ct/commit/5bc27b1c5922bc92df558239a09210647dca29c2
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/libxorp/nexthop.cc
    M xorp/libxorp/nexthop.hh

  Log Message:
  -----------
  xorp: libxorp: Make printing of Nexthop strings simpler

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 15880f541311f668cdf87fa6867a59bfa8ef67f1
      https://github.com/greearb/xorp.ct/commit/15880f541311f668cdf87fa6867a59bfa8ef67f1
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/rib/route.hh

  Log Message:
  -----------
  xorp: rib: Use explicit inlining instead of explicit

This makes code more readable.

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: ca06dac68f92a4221118f1d9bf0a92d5b42df1f4
      https://github.com/greearb/xorp.ct/commit/ca06dac68f92a4221118f1d9bf0a92d5b42df1f4
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-06-14 (Thu, 14 Jun 2012)

  Changed paths:
    M xorp/rib/route.hh

  Log Message:
  -----------
  xorp: rib: _igp_parent and _egp_parent doesn't need to be mutable members

This members doesn't need to be mutable in ResolvedIPRouteEntry class.

Signed-off-by: Igor Maravic <igorm at etf.rs>


Compare: https://github.com/greearb/xorp.ct/compare/5f57d9ca2a61...ca06dac68f92


More information about the Xorp-hackers mailing list