[Xorp-hackers] [greearb/xorp.ct] f720db: ospf: Fix full-state timer logic.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct
  Commit: f720db3712462fca67e6c868ea12350b3ee27dc4
      https://github.com/greearb/xorp.ct/commit/f720db3712462fca67e6c868ea12350b3ee27dc4
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-03-13 (Tue, 13 Mar 2012)

  Changed paths:
    M xorp/ospf/peer.cc

  Log Message:
  -----------
  ospf:  Fix full-state timer logic.

Original patch & problem diagnosis is by
Markus Zehnder <markus.xorp at gmail.com>

In OSPF, the timer which should fire after 5 seconds and trigger
a retransmission of unacknowledged LSA Updates is never restarted.
After the timer has once fired, it is never (re)started again.

The code which checks if the timer is still running is buggy. It
always returns true after the timer wrapper object was once created.

Introduced with another bugfix from 1.8.3 to 1.8.6

Signed-off-by: Ben Greear <greearb at candelatech.com>