[Xorp-hackers] Yes: "if [ -d" Re: [PATCH] windows: mingw cross compiler : build xorp_win32.zip : win32_pkg.bash 1) libstdc++-6.dll 2) change order exit errors 3) update notes mingw32 packages 4) add URLs /w32api/include/routprot.h 51: error: 'IP_LOCAL_BINDING'

[Victor Miasnikov]

Hi!

> I also fixed up your check for file existence.


 Thanks!

> I think it should be -f instead of -d (-d is for directory, right??).


 Yes . . .

Sorry -- "-f" is my "copy-paste" error :-(

 for history ;-) log only diff-for-diff :
==
--- ..\2012-03-13 12-31\0001-windows-mingw-cross-compiler-build-xorp_win32.zip-wi.patch Tue Mar 13 12:31:29 2012
+++ 0001-windows-mingw-cross-compiler-build-xorp_win32.zip-wi.patch Wed Mar 14 11:07:51 2012
@@ -93,7 +93,7 @@
  cp /usr/i686-pc-mingw32/sys-root/mingw/bin/libgcc_s_sjlj-1.dll /usr/local/xorp/sbin/ || exit 5
  cp /usr/i686-pc-mingw32/sys-root/mingw/bin/libgnurx-0.dll /usr/local/xorp/sbin/ || exit 6
 +cp /usr/i686-pc-mingw32/sys-root/mingw/bin/libcrypto-10.dll /usr/local/xorp/sbin/ || exit 7
-+if [ -d /usr/i686-pc-mingw32/sys-root/mingw/bin/libstdc++-6.dll ] ; then
++if [ -f /usr/i686-pc-mingw32/sys-root/mingw/bin/libstdc++-6.dll ] ; then
 + (
 + cp /usr/i686-pc-mingw32/sys-root/mingw/bin/libstdc++-6.dll /usr/local/xorp/sbin/ || exit 8
 + )
==


> Please test that it works for you in a clean build.


 Ok


Best regards, Victor Miasnikov
Blog:  http://vvm.blog.tut.by/

P.S.


> Thanks,

No problem :-)


> The change has been committed.

 Thanks!

>> windows: mingw cross compiler : build xorp_win32.zip : win32_pkg.bash
>Please make the patch title shorter in the future.


 Ok



----- Original Message ----- 
From: "Ben Greear"
To: "Victor Miasnikov"
Cc: xorp-hackers
Sent: Tuesday, March 13, 2012 7:30 PM
Subject: Re: [PATCH] windows: mingw cross compiler : build xorp_win32.zip : win32_pkg.bash 1) libstdc++-6.dll 2) change 
order exit errors 3) update notes mingw32 packages 4) add URLs /w32api/include/routprot.h 51: error: 'IP_LOCAL_BINDING'

On 03/13/2012 03:20 AM, Victor Miasnikov wrote:
> From: Victor Miasnikov <vvm at tut.by>
>
> windows: mingw cross compiler : build xorp_win32.zip : win32_pkg.bash

Please make the patch title shorter in the future.

I also fixed up your check for file existence.  I think it should
be -f instead of -d (-d is for directory, right??).

The change has been committed.  Please test that it works
for you in a clean build.

Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com
--