[Xorp-hackers] [PATCH] use RRAS only if environment variable XORP_USE_RRAS is set

Victor Miasnikov vvm at tut.by
Fri Mar 16 09:04:04 PDT 2012


From: Victor Miasnikov <vvm at tut.by>

use RRAS only if environment variable XORP_USE_RRAS is set

 I.e. not-developers can be work with XORP on Windows comps with RRAS component
( RRAS very often not configure as _router_ ,
usual it simply installed by other MS software )

 Who want use feature "xorprtm dll" / "RTMv2"
-- simply set XORP_USE_RRAS=y

Signed-off-by: Victor Miasnikov <vvm at tut.by>
---
 .../control_socket/windows_rras_support.cc         |   22 ++++++++++++++++++++
 1 files changed, 22 insertions(+), 0 deletions(-)

diff --git a/xorp/fea/data_plane/control_socket/windows_rras_support.cc 
b/xorp/fea/data_plane/control_socket/windows_rras_support.cc
index 23332d5..cfdd92f 100644
--- a/xorp/fea/data_plane/control_socket/windows_rras_support.cc
+++ b/xorp/fea/data_plane/control_socket/windows_rras_support.cc
@@ -50,6 +50,28 @@ WinSupport::is_rras_running()
     bool is_installed = false;
     bool is_running = false;

+    //
+    // If environment variable XORP_USE_RRAS is not set ,
+    //  then disable feature "xorprtm dll" / "RTMv2"
+    //
+    // I.e. not-developers can be work with XORP on Windows comps with RRAS component
+    // ( RRAS very often not configure as _router_ , usual it simply installed by other MS software )
+    //
+    // Who want use feature "xorprtm dll" / "RTMv2" -- simply set XORP_USE_RRAS=y
+    //
+    //   See:
+    //
+    // http://mailman.icsi.berkeley.edu/pipermail/xorp-hackers/2012-March/003315.html
+    // http://mailman.icsi.berkeley.edu/pipermail/xorp-hackers/2012-March/003317.html
+    //
+    //
+    // TODO: XXX: do feature "xorprtm dll" / "RTMv2" worked stable
+    //
+    const char* pf = getenv("XORP_USE_RRAS");
+    if (pf == NULL) {
+        return (is_running && is_installed);
+    }
+
     SC_HANDLE h_scm = OpenSCManager(NULL, NULL, GENERIC_READ);
     if (h_scm != NULL) {
      SC_HANDLE h_rras = OpenService(h_scm, RRAS_SERVICE_NAME, GENERIC_READ);
-- 
1.7.9.msysgit.0





More information about the Xorp-hackers mailing list