[Xorp-hackers] [greearb/xorp.ct] 639cd2: Fix OSPFv6 route cost.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct
  Commit: 639cd2bdcb4f80af3e5ce82e36771ba84b4a3d69
      https://github.com/greearb/xorp.ct/commit/639cd2bdcb4f80af3e5ce82e36771ba84b4a3d69
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-05-14 (Mon, 14 May 2012)

  Changed paths:
    M xorp/ospf/area_router.cc
    M xorp/ospf/peer.cc
    M xorp/ospf/peer.hh
    M xorp/ospf/peer_manager.cc

  Log Message:
  -----------
  Fix OSPFv6 route cost.

Original patch by: Eric S. Johnson <esj at cs.fiu.edu>
I had to apply it by hand due to conflicts, hopefully
didn't miss anything.

>From the email description:

I kinda decided it is a bug. Everybody else doing V6 ospf seems
to send metrics with Intra-Area prefix LSA, and everybody else
seems to want to see them to give a cost to a link.

(everybody else == cisco and quagga

Here is a patch a worked up that seems to let xorp
"do the right thing".

I left in the sending of /128 interface prefix along with
the /64 network prefix becuase I have no "virtual links" nor
experience with them. I kinda think that those /128's should be
advertised ONLY on virtual links and certainly not on broadcast
networks... But haven't worked that out yet.

Patch is against a git pull on 4-29-2012 but applies clean to
1.8.5 also.

C++ is not my native language, and  I am not certain on some OSPF3
things still, so I would appreciate some feedback.

Thoughts?

Anyone out there acutally trying to use xorp ospf6 besides me?

E

esj at cs.fiu.edu said:
> I started playing vith ospf for v6 recently. I have noticed an
> oddity. I am curious if I have something miss-configured  or I have
> found a bug.
> OSPFv3 for ipv6 has a couple new link-state adv types.  The one I am
> running into interoperability issues with is  the Intra-area prefix
> type.
> It appears that xorp is sending these out with a cost of zero. No
> matter what the config file cost setting is.
> This causes all the other ospf3 impelmentations it talks to (well,
> ok, cisco IOS and quagga are the only ones I have tested) to count
> the cost to that network as zero.
> xorp sends the ole fashioned router lsa's with the appropriate
> costs.  But not the new fangled intra-area prefix costs.
> xorp also seems to send a /128 IA prefix LSA with the address of
> the interface also with metric of 0. This doesn't impact things as
> much as the network prefixs being 0, but seems odd too.
> I have verified with wireshark that it is sending the IA prefix
> lsa's with cost 0.

Signed-off-by: Ben Greear <greearb at candelatech.com>