From igorm at etf.rs  Mon Oct  1 01:12:55 2012
From: igorm at etf.rs (=?ISO-8859-2?Q?Igor_Maravi=E6?=)
Date: Mon, 1 Oct 2012 10:12:55 +0200
Subject: [Xorp-hackers] [PATCH 00/15] Add new operators for changing
	metric in policy code
In-Reply-To: <CAFdo_mVD=yqj2jb9Xfxy7oS7m=bMH1LkKo9RBZ-np-6NZBrLoA@mail.gmail.com>
References: <igorm@etf.rs> <1346412841-31507-1-git-send-email-igorm@etf.rs>
	<50464C84.2030508@candelatech.com>
	<CAFdo_mVD=yqj2jb9Xfxy7oS7m=bMH1LkKo9RBZ-np-6NZBrLoA@mail.gmail.com>
Message-ID: <CAFdo_mXEFbaTXmoQXDYsJK=Nvs7q+yKh=9u=qAzBYLvaSq5fVA@mail.gmail.com>

Ben,
I've just returned from my vacation.
BR
Igor

2012/9/13 Igor Maravi? <igorm at etf.rs>:
> Ben,
> I'm going on vacation this Saturday, and I'm going to be out of my
> office for two weeks.
> You can wait up with patches, if you wish, until I come back.
> BR
> Igor
>
> 2012/9/4 Ben Greear <greearb at candelatech.com>:
>> On 08/31/2012 04:33 AM, igorm at etf.rs wrote:
>>>
>>> From: Igor Maravic <igorm at etf.rs>
>>>
>>> Hi,
>>>
>>> As suggested by Phil, I've added new operators for changing metric in
>>> policy code.
>>> New operators are *=, /=, <<=, >>=, &=, |= and ^=.
>>>
>>> I didn't have the time to test it thouroughly, so any volunteers to test
>>> the code are welcome. :)
>>>
>>> In the first patch I've added new patern for one line comments.
>>> Everything after %% is considered a comment.
>>>
>>> In the last patch I've hacked RIP so the routes that have metric >
>>> RIP_INFINITY would be pushed through the EXPORT filter. I've tested it, and
>>> it works. Unfortunatelly I'm not 100% sure if this hack is ok.
>>>
>>> All other patches should be fine!
>>
>>
>> Just FYI, I haven't forgotten about these yet...and the previous patches
>> for the xorp protocol plugin feature set.
>>
>> But, it will be a bit longer before I get to this..need to make sure
>> I have the multicast fixes I've been working on all working properly
>> first.
>>
>> I think after all of the pending patches are in, I'll start
>> thinking about doing a release...
>>
>> Thanks,
>> Ben
>>
>> --
>> Ben Greear <greearb at candelatech.com>
>> Candela Technologies Inc  http://www.candelatech.com
>>


From noreply at github.com  Mon Oct  8 11:53:27 2012
From: noreply at github.com (GitHub)
Date: Mon, 08 Oct 2012 11:53:27 -0700
Subject: [Xorp-hackers] [greearb/xorp.ct] d4a845: rib: Fix some 'scons
	check' bugs.
Message-ID: <50732127d79c4_188c19a9aec2072c@sh3.rs.github.com.mail>

  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct
  Commit: d4a84540267d80b84e36efeec222463fdf0bbafe
      https://github.com/greearb/xorp.ct/commit/d4a84540267d80b84e36efeec222463fdf0bbafe
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-10-08 (Mon, 08 Oct 2012)

  Changed paths:
    M xorp/rib/tests/test_deletion.cc
    M xorp/rib/tests/test_redist.cc

  Log Message:
  -----------
  rib:  Fix some 'scons check' bugs.

This fixes some compile bugs introduced with the recent
rib changes.

Signed-off-by: <greearb at candelatech.com>




From noreply at github.com  Mon Oct  8 14:28:11 2012
From: noreply at github.com (GitHub)
Date: Mon, 08 Oct 2012 14:28:11 -0700
Subject: [Xorp-hackers] [greearb/xorp.ct] c62769: xorp:rtrmgr: Add patern
 for one line comment
Message-ID: <5073456b8d602_54631c18ae48103b@sh2.rs.github.com.mail>

  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct
  Commit: c6276945e318b3416f8c3667e07f67738924c282
      https://github.com/greearb/xorp.ct/commit/c6276945e318b3416f8c3667e07f67738924c282
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-08 (Mon, 08 Oct 2012)

  Changed paths:
    M xorp/rtrmgr/boot.ll
    M xorp/rtrmgr/op_commands.ll
    M xorp/rtrmgr/template.ll

  Log Message:
  -----------
  xorp:rtrmgr: Add patern for one line comment

Everything in a line, that is behind %% is considered a comment.

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 32c787272c6b36a72308a93371cdf96ad33ca3fa
      https://github.com/greearb/xorp.ct/commit/32c787272c6b36a72308a93371cdf96ad33ca3fa
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-08 (Mon, 08 Oct 2012)

  Changed paths:
    R xorp/policy/backend/backend.y
    A xorp/policy/backend/backend.yy

  Log Message:
  -----------
  xorp: policy:backend: Rename backend.y to backend.yy

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 64dd22b72b7e0299799e9fdeb8efe50925095b2c
      https://github.com/greearb/xorp.ct/commit/64dd22b72b7e0299799e9fdeb8efe50925095b2c
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-08 (Mon, 08 Oct 2012)

  Changed paths:
    R xorp/policy/backend/backend.l
    A xorp/policy/backend/backend.ll

  Log Message:
  -----------
  xorp:policy:backend: Rename backend.l to backend.ll

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 9ab53c75c28653d6b3328694b1d7f7747a9b992c
      https://github.com/greearb/xorp.ct/commit/9ab53c75c28653d6b3328694b1d7f7747a9b992c
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-08 (Mon, 08 Oct 2012)

  Changed paths:
    R xorp/policy/policy.l
    A xorp/policy/policy.ll

  Log Message:
  -----------
  xorp: policy: REname policy.l to policy.ll

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 7d373cee4d06d56aa32726bf6776a16c9434be15
      https://github.com/greearb/xorp.ct/commit/7d373cee4d06d56aa32726bf6776a16c9434be15
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-08 (Mon, 08 Oct 2012)

  Changed paths:
    R xorp/policy/policy.y
    A xorp/policy/policy.yy

  Log Message:
  -----------
  xorp:policy: Rename policy.y to policy.yy

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: fc3c0e37555038682473f8141ae11796db3ac936
      https://github.com/greearb/xorp.ct/commit/fc3c0e37555038682473f8141ae11796db3ac936
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-08 (Mon, 08 Oct 2012)

  Changed paths:
    M xorp/policy/SConscript

  Log Message:
  -----------
  xorp: policy: Automaticly build lex and yacc fails from policy.ll and policy.yy

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: a44c9ac84768ffd8f8bab7b28489b1ca89b28b44
      https://github.com/greearb/xorp.ct/commit/a44c9ac84768ffd8f8bab7b28489b1ca89b28b44
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-08 (Mon, 08 Oct 2012)

  Changed paths:
    M xorp/policy/backend/SConscript

  Log Message:
  -----------
  xorp:policy:backend: Automaticly build lex and yacc files from backend.{ll,yy}

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 107633aecd174c2cb0ece2690c90468c998fcc86
      https://github.com/greearb/xorp.ct/commit/107633aecd174c2cb0ece2690c90468c998fcc86
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-08 (Mon, 08 Oct 2012)

  Changed paths:
    R xorp/policy/backend/lex.yy_policy_backend_parser.cc

  Log Message:
  -----------
  Remove lex.yy_policy_backend_parser.cc

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 051863c492f0e403286609fa306833ac52f91911
      https://github.com/greearb/xorp.ct/commit/051863c492f0e403286609fa306833ac52f91911
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-08 (Mon, 08 Oct 2012)

  Changed paths:
    R xorp/policy/backend/yacc.yy_policy_backend_parser.cc

  Log Message:
  -----------
  Remove yacc.yy_policy_backend_parser.cc

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 0ce289c58ef1808e1e0f6182a62c74f9b845f9c7
      https://github.com/greearb/xorp.ct/commit/0ce289c58ef1808e1e0f6182a62c74f9b845f9c7
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-08 (Mon, 08 Oct 2012)

  Changed paths:
    R xorp/policy/backend/yacc.yy_policy_backend_parser.cc.h

  Log Message:
  -----------
  Remove yacc.yy_policy_backend_parser.cc.h

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 74bcc8103d42b29acb8d5d19340af67147414775
      https://github.com/greearb/xorp.ct/commit/74bcc8103d42b29acb8d5d19340af67147414775
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-08 (Mon, 08 Oct 2012)

  Changed paths:
    R xorp/policy/lex.yy_policy_parser.cc

  Log Message:
  -----------
  Remove lex.yy_policy_parser.cc

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 2ac5fe0b94ab2fffdd2746f374891f3721ea072e
      https://github.com/greearb/xorp.ct/commit/2ac5fe0b94ab2fffdd2746f374891f3721ea072e
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-08 (Mon, 08 Oct 2012)

  Changed paths:
    R xorp/policy/yacc.yy_policy_parser.cc

  Log Message:
  -----------
  Remove yacc.yy_policy_parser.cc

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: ffa3dff82a149f5ebe35bb14f789e5ea0567e63f
      https://github.com/greearb/xorp.ct/commit/ffa3dff82a149f5ebe35bb14f789e5ea0567e63f
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-08 (Mon, 08 Oct 2012)

  Changed paths:
    R xorp/policy/yacc.yy_policy_parser.cc.h

  Log Message:
  -----------
  Remove yacc.yy_policy_parser.cc.h

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: e041d5e242aecce5e7f145af00ff79105a0fc923
      https://github.com/greearb/xorp.ct/commit/e041d5e242aecce5e7f145af00ff79105a0fc923
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-08 (Mon, 08 Oct 2012)

  Changed paths:
    M xorp/etc/templates/bgp.tp
    M xorp/etc/templates/ospfv2.tp
    M xorp/etc/templates/ospfv3.tp
    M xorp/etc/templates/policy.tp
    M xorp/etc/templates/rip.tp
    M xorp/etc/templates/ripng.tp
    M xorp/policy/backend/backend.ll
    M xorp/policy/backend/backend.yy
    M xorp/policy/common/operator.cc
    M xorp/policy/common/operator.hh
    M xorp/policy/common/operator_base.hh
    M xorp/policy/common/register_operations.cc
    M xorp/policy/policy.ll
    M xorp/policy/policy.yy
    M xorp/rtrmgr/boot.ll
    M xorp/rtrmgr/config_operators.cc
    M xorp/rtrmgr/config_operators.hh

  Log Message:
  -----------
  xorp: Add new operators

Add operators *, /, <<, >>, &, |, ^, *=, /=, <<=, >>=, &=, |= and ^=.

Operators *=, /=, <<=, >>=, &=, |= and ^= are added to policy metric semantics.

Signed-off-by: Igor Maravic <igorm at etf.rs>


  Commit: 0803201aee8e63e9f7d1bc67b60a553cab762f76
      https://github.com/greearb/xorp.ct/commit/0803201aee8e63e9f7d1bc67b60a553cab762f76
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-08 (Mon, 08 Oct 2012)

  Changed paths:
    M xorp/rip/output.hh
    M xorp/rip/output_table.cc
    M xorp/rip/output_updates.cc
    M xorp/rip/route_db.cc
    M xorp/rip/route_db.hh

  Log Message:
  -----------
  xorp: rip: Force RIP to do EXPORT filtering when the route comes

Also, don't check if metric is larger then RIP_INFINITY, before the route passes through the policy filters.
EXPORT and IMPORT filter, could posibly change metric and make it smaller then RIP_INFINITY.

After the route passes through the EXPORT filter, or if it doesn't pass IMPORT or EXPORT_SOURCEMATCH filters,
check the route cost. If it's larger then RIP_INFINITY set it to ROUTE_INFINITY.

Don't run EXPORT filter when the outgoing packet is sent, because route is pushed through the EXPORT filter when it comes to RIP.

Signed-off-by: Igor Maravic <igorm at etf.rs>


Compare: https://github.com/greearb/xorp.ct/compare/d4a84540267d...0803201aee8e

From greearb at candelatech.com  Mon Oct  8 16:05:29 2012
From: greearb at candelatech.com (Ben Greear)
Date: Mon, 08 Oct 2012 16:05:29 -0700
Subject: [Xorp-hackers] [PATCH 00/15] Add new operators for changing
 metric in policy code
In-Reply-To: <CAFdo_mXEFbaTXmoQXDYsJK=Nvs7q+yKh=9u=qAzBYLvaSq5fVA@mail.gmail.com>
References: <igorm@etf.rs> <1346412841-31507-1-git-send-email-igorm@etf.rs>
	<50464C84.2030508@candelatech.com>
	<CAFdo_mVD=yqj2jb9Xfxy7oS7m=bMH1LkKo9RBZ-np-6NZBrLoA@mail.gmail.com>
	<CAFdo_mXEFbaTXmoQXDYsJK=Nvs7q+yKh=9u=qAzBYLvaSq5fVA@mail.gmail.com>
Message-ID: <50735C39.6010607@candelatech.com>

On 10/01/2012 01:12 AM, Igor Maravi? wrote:
> Ben,
> I've just returned from my vacation.
> BR
> Igor

I pushed the 15 patches.  Seems it breaks the 'scons check' on Fedora 8 and the BSD
machine:

http://dmz2.candelatech.com:8010/waterfall

Don't worry about 'clang', it always fails.

Thanks,
Ben

>
> 2012/9/13 Igor Maravi? <igorm at etf.rs>:
>> Ben,
>> I'm going on vacation this Saturday, and I'm going to be out of my
>> office for two weeks.
>> You can wait up with patches, if you wish, until I come back.
>> BR
>> Igor
>>
>> 2012/9/4 Ben Greear <greearb at candelatech.com>:
>>> On 08/31/2012 04:33 AM, igorm at etf.rs wrote:
>>>>
>>>> From: Igor Maravic <igorm at etf.rs>
>>>>
>>>> Hi,
>>>>
>>>> As suggested by Phil, I've added new operators for changing metric in
>>>> policy code.
>>>> New operators are *=, /=, <<=, >>=, &=, |= and ^=.
>>>>
>>>> I didn't have the time to test it thouroughly, so any volunteers to test
>>>> the code are welcome. :)
>>>>
>>>> In the first patch I've added new patern for one line comments.
>>>> Everything after %% is considered a comment.
>>>>
>>>> In the last patch I've hacked RIP so the routes that have metric >
>>>> RIP_INFINITY would be pushed through the EXPORT filter. I've tested it, and
>>>> it works. Unfortunatelly I'm not 100% sure if this hack is ok.
>>>>
>>>> All other patches should be fine!
>>>
>>>
>>> Just FYI, I haven't forgotten about these yet...and the previous patches
>>> for the xorp protocol plugin feature set.
>>>
>>> But, it will be a bit longer before I get to this..need to make sure
>>> I have the multicast fixes I've been working on all working properly
>>> first.
>>>
>>> I think after all of the pending patches are in, I'll start
>>> thinking about doing a release...
>>>
>>> Thanks,
>>> Ben
>>>
>>> --
>>> Ben Greear <greearb at candelatech.com>
>>> Candela Technologies Inc  http://www.candelatech.com
>>>


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


From igorm at etf.rs  Tue Oct  9 02:49:30 2012
From: igorm at etf.rs (=?ISO-8859-2?Q?Igor_Maravi=E6?=)
Date: Tue, 9 Oct 2012 11:49:30 +0200
Subject: [Xorp-hackers] [PATCH 00/15] Add new operators for changing
	metric in policy code
In-Reply-To: <50735C39.6010607@candelatech.com>
References: <igorm@etf.rs> <1346412841-31507-1-git-send-email-igorm@etf.rs>
	<50464C84.2030508@candelatech.com>
	<CAFdo_mVD=yqj2jb9Xfxy7oS7m=bMH1LkKo9RBZ-np-6NZBrLoA@mail.gmail.com>
	<CAFdo_mXEFbaTXmoQXDYsJK=Nvs7q+yKh=9u=qAzBYLvaSq5fVA@mail.gmail.com>
	<50735C39.6010607@candelatech.com>
Message-ID: <CAFdo_mVAQW2288pjf505nprwV5G-reyRb7UWhEWw=23CzJS=yA@mail.gmail.com>

I'm sending for BSD. I forgot to remove YYSTYPE...
For Fedora it fails compiling because of some comparison between
signed and unsigned integer inside function yy_get_next_buffer(). It
seems like lex problem.
Maybe to suppres all warnings?
BR
Igor

2012/10/9 Ben Greear <greearb at candelatech.com>:
> On 10/01/2012 01:12 AM, Igor Maravi? wrote:
>>
>> Ben,
>> I've just returned from my vacation.
>> BR
>> Igor
>
>
> I pushed the 15 patches.  Seems it breaks the 'scons check' on Fedora 8 and
> the BSD
> machine:
>
> http://dmz2.candelatech.com:8010/waterfall
>
> Don't worry about 'clang', it always fails.
>
> Thanks,
> Ben
>
>
>>
>> 2012/9/13 Igor Maravi? <igorm at etf.rs>:
>>>
>>> Ben,
>>> I'm going on vacation this Saturday, and I'm going to be out of my
>>> office for two weeks.
>>> You can wait up with patches, if you wish, until I come back.
>>> BR
>>> Igor
>>>
>>> 2012/9/4 Ben Greear <greearb at candelatech.com>:
>>>>
>>>> On 08/31/2012 04:33 AM, igorm at etf.rs wrote:
>>>>>
>>>>>
>>>>> From: Igor Maravic <igorm at etf.rs>
>>>>>
>>>>> Hi,
>>>>>
>>>>> As suggested by Phil, I've added new operators for changing metric in
>>>>> policy code.
>>>>> New operators are *=, /=, <<=, >>=, &=, |= and ^=.
>>>>>
>>>>> I didn't have the time to test it thouroughly, so any volunteers to
>>>>> test
>>>>> the code are welcome. :)
>>>>>
>>>>> In the first patch I've added new patern for one line comments.
>>>>> Everything after %% is considered a comment.
>>>>>
>>>>> In the last patch I've hacked RIP so the routes that have metric >
>>>>> RIP_INFINITY would be pushed through the EXPORT filter. I've tested it,
>>>>> and
>>>>> it works. Unfortunatelly I'm not 100% sure if this hack is ok.
>>>>>
>>>>> All other patches should be fine!
>>>>
>>>>
>>>>
>>>> Just FYI, I haven't forgotten about these yet...and the previous patches
>>>> for the xorp protocol plugin feature set.
>>>>
>>>> But, it will be a bit longer before I get to this..need to make sure
>>>> I have the multicast fixes I've been working on all working properly
>>>> first.
>>>>
>>>> I think after all of the pending patches are in, I'll start
>>>> thinking about doing a release...
>>>>
>>>> Thanks,
>>>> Ben
>>>>
>>>> --
>>>> Ben Greear <greearb at candelatech.com>
>>>> Candela Technologies Inc  http://www.candelatech.com
>>>>
>
>
> --
> Ben Greear <greearb at candelatech.com>
> Candela Technologies Inc  http://www.candelatech.com
>


From igorm at etf.rs  Tue Oct  9 02:49:36 2012
From: igorm at etf.rs (igorm at etf.rs)
Date: Tue,  9 Oct 2012 11:49:36 +0200
Subject: [Xorp-hackers] [PATCH] xorp: policy: backend: Fix for BSD
In-Reply-To: <igorm@etf.rs>
References: <igorm@etf.rs>
Message-ID: <1349776177-8328-1-git-send-email-igorm@etf.rs>

From: Igor Maravic <igorm at etf.rs>

Remove unneeded YYSTYPE declaration.

Signed-off-by: Igor Maravic <igorm at etf.rs>
---
 xorp/policy/backend/backend.ll |    1 -
 1 file changed, 1 deletion(-)

diff --git a/xorp/policy/backend/backend.ll b/xorp/policy/backend/backend.ll
index e369ff7..efd8c61 100644
--- a/xorp/policy/backend/backend.ll
+++ b/xorp/policy/backend/backend.ll
@@ -8,7 +8,6 @@
 #include "policy/backend/policy_backend_parser.hh"
 
 #if defined(NEED_LEX_H_HACK)
-extern YYSTYPE tpltlval;
 #include "y.policy_backend_parser_tab.cc.h"
 #else
 #include "y.policy_backend_parser_tab.hh"
-- 
1.7.9.5


From noreply at github.com  Tue Oct  9 07:35:43 2012
From: noreply at github.com (GitHub)
Date: Tue, 09 Oct 2012 07:35:43 -0700
Subject: [Xorp-hackers] [greearb/xorp.ct] c22920: xorp: policy: backend: Fix
	for BSD
Message-ID: <5074363fda83c_62b61a7eae46425a@sh3.rs.github.com.mail>

  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct
  Commit: c229205a5e69d553cf5422838fb049034fba9db5
      https://github.com/greearb/xorp.ct/commit/c229205a5e69d553cf5422838fb049034fba9db5
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-09 (Tue, 09 Oct 2012)

  Changed paths:
    M xorp/policy/backend/backend.ll

  Log Message:
  -----------
  xorp: policy: backend: Fix for BSD

Remove unneeded YYSTYPE declaration.

Signed-off-by: Igor Maravic <igorm at etf.rs>




From greearb at candelatech.com  Tue Oct  9 07:36:41 2012
From: greearb at candelatech.com (Ben Greear)
Date: Tue, 09 Oct 2012 07:36:41 -0700
Subject: [Xorp-hackers] [PATCH 00/15] Add new operators for changing
 metric in policy code
In-Reply-To: <CAFdo_mVAQW2288pjf505nprwV5G-reyRb7UWhEWw=23CzJS=yA@mail.gmail.com>
References: <igorm@etf.rs> <1346412841-31507-1-git-send-email-igorm@etf.rs>
	<50464C84.2030508@candelatech.com>
	<CAFdo_mVD=yqj2jb9Xfxy7oS7m=bMH1LkKo9RBZ-np-6NZBrLoA@mail.gmail.com>
	<CAFdo_mXEFbaTXmoQXDYsJK=Nvs7q+yKh=9u=qAzBYLvaSq5fVA@mail.gmail.com>
	<50735C39.6010607@candelatech.com>
	<CAFdo_mVAQW2288pjf505nprwV5G-reyRb7UWhEWw=23CzJS=yA@mail.gmail.com>
Message-ID: <50743679.9020100@candelatech.com>

On 10/09/2012 02:49 AM, Igor Maravi? wrote:
> I'm sending for BSD. I forgot to remove YYSTYPE...
> For Fedora it fails compiling because of some comparison between
> signed and unsigned integer inside function yy_get_next_buffer(). It
> seems like lex problem.
> Maybe to suppres all warnings?

I could probably just turn off -Werr..will give that a try when
I get a chance.

Thanks,
Ben

> BR
> Igor
>
> 2012/10/9 Ben Greear <greearb at candelatech.com>:
>> On 10/01/2012 01:12 AM, Igor Maravi? wrote:
>>>
>>> Ben,
>>> I've just returned from my vacation.
>>> BR
>>> Igor
>>
>>
>> I pushed the 15 patches.  Seems it breaks the 'scons check' on Fedora 8 and
>> the BSD
>> machine:
>>
>> http://dmz2.candelatech.com:8010/waterfall
>>
>> Don't worry about 'clang', it always fails.
>>
>> Thanks,
>> Ben
>>
>>
>>>
>>> 2012/9/13 Igor Maravi? <igorm at etf.rs>:
>>>>
>>>> Ben,
>>>> I'm going on vacation this Saturday, and I'm going to be out of my
>>>> office for two weeks.
>>>> You can wait up with patches, if you wish, until I come back.
>>>> BR
>>>> Igor
>>>>
>>>> 2012/9/4 Ben Greear <greearb at candelatech.com>:
>>>>>
>>>>> On 08/31/2012 04:33 AM, igorm at etf.rs wrote:
>>>>>>
>>>>>>
>>>>>> From: Igor Maravic <igorm at etf.rs>
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> As suggested by Phil, I've added new operators for changing metric in
>>>>>> policy code.
>>>>>> New operators are *=, /=, <<=, >>=, &=, |= and ^=.
>>>>>>
>>>>>> I didn't have the time to test it thouroughly, so any volunteers to
>>>>>> test
>>>>>> the code are welcome. :)
>>>>>>
>>>>>> In the first patch I've added new patern for one line comments.
>>>>>> Everything after %% is considered a comment.
>>>>>>
>>>>>> In the last patch I've hacked RIP so the routes that have metric >
>>>>>> RIP_INFINITY would be pushed through the EXPORT filter. I've tested it,
>>>>>> and
>>>>>> it works. Unfortunatelly I'm not 100% sure if this hack is ok.
>>>>>>
>>>>>> All other patches should be fine!
>>>>>
>>>>>
>>>>>
>>>>> Just FYI, I haven't forgotten about these yet...and the previous patches
>>>>> for the xorp protocol plugin feature set.
>>>>>
>>>>> But, it will be a bit longer before I get to this..need to make sure
>>>>> I have the multicast fixes I've been working on all working properly
>>>>> first.
>>>>>
>>>>> I think after all of the pending patches are in, I'll start
>>>>> thinking about doing a release...
>>>>>
>>>>> Thanks,
>>>>> Ben
>>>>>
>>>>> --
>>>>> Ben Greear <greearb at candelatech.com>
>>>>> Candela Technologies Inc  http://www.candelatech.com
>>>>>
>>
>>
>> --
>> Ben Greear <greearb at candelatech.com>
>> Candela Technologies Inc  http://www.candelatech.com
>>


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com



From igorm at etf.rs  Wed Oct 10 00:58:38 2012
From: igorm at etf.rs (igorm at etf.rs)
Date: Wed, 10 Oct 2012 09:58:38 +0200
Subject: [Xorp-hackers] [PATCH] xorp: policy: Fix for BSD
In-Reply-To: <igorm@etf.rs>
References: <igorm@etf.rs>
Message-ID: <1349855918-3049-1-git-send-email-igorm@etf.rs>

From: Igor Maravic <igorm at etf.rs>

Remove unneeded YYSTYPE declaration.

Signed-off-by: Igor Maravic <igorm at etf.rs>
---
 xorp/policy/policy.ll |    1 -
 1 file changed, 1 deletion(-)

diff --git a/xorp/policy/policy.ll b/xorp/policy/policy.ll
index 05e61f0..e12842c 100644
--- a/xorp/policy/policy.ll
+++ b/xorp/policy/policy.ll
@@ -10,7 +10,6 @@
 #include "policy/policy_parser.hh"
 
 #if defined(NEED_LEX_H_HACK)
-extern YYSTYPE tpltlval;
 #include "y.policy_parser_tab.cc.h"
 #else
 #include "y.policy_parser_tab.hh"
-- 
1.7.9.5


From igorm at etf.rs  Wed Oct 10 00:59:33 2012
From: igorm at etf.rs (=?ISO-8859-2?Q?Igor_Maravi=E6?=)
Date: Wed, 10 Oct 2012 09:59:33 +0200
Subject: [Xorp-hackers] [PATCH 00/15] Add new operators for changing
	metric in policy code
In-Reply-To: <50743679.9020100@candelatech.com>
References: <igorm@etf.rs> <1346412841-31507-1-git-send-email-igorm@etf.rs>
	<50464C84.2030508@candelatech.com>
	<CAFdo_mVD=yqj2jb9Xfxy7oS7m=bMH1LkKo9RBZ-np-6NZBrLoA@mail.gmail.com>
	<CAFdo_mXEFbaTXmoQXDYsJK=Nvs7q+yKh=9u=qAzBYLvaSq5fVA@mail.gmail.com>
	<50735C39.6010607@candelatech.com>
	<CAFdo_mVAQW2288pjf505nprwV5G-reyRb7UWhEWw=23CzJS=yA@mail.gmail.com>
	<50743679.9020100@candelatech.com>
Message-ID: <CAFdo_mU1ec2EEPS7ojN_k3Uh=h0ur9_Y313A0k2Z-Ftu7pr3MQ@mail.gmail.com>

I've sent you another fix for BSD.
BR
Igor


From noreply at github.com  Thu Oct 11 14:05:50 2012
From: noreply at github.com (GitHub)
Date: Thu, 11 Oct 2012 14:05:50 -0700
Subject: [Xorp-hackers] [greearb/xorp.ct] 19d2db: xorp: policy: Fix for BSD
Message-ID: <507734ae58b3c_357f17daaf4223da@sh3.rs.github.com.mail>

  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct
  Commit: 19d2db7b9be25c55fd6fd13094a9a63b017c80ad
      https://github.com/greearb/xorp.ct/commit/19d2db7b9be25c55fd6fd13094a9a63b017c80ad
  Author: Igor Maravic <igorm at etf.rs>
  Date:   2012-10-11 (Thu, 11 Oct 2012)

  Changed paths:
    M xorp/policy/policy.ll

  Log Message:
  -----------
  xorp: policy: Fix for BSD

Remove unneeded YYSTYPE declaration.

Signed-off-by: Igor Maravic <igorm at etf.rs>




From greearb at candelatech.com  Mon Oct 22 10:23:15 2012
From: greearb at candelatech.com (Ben Greear)
Date: Mon, 22 Oct 2012 10:23:15 -0700
Subject: [Xorp-hackers] [PATCH 00/15] Add new operators for changing
 metric in policy code
In-Reply-To: <CAFdo_mVAQW2288pjf505nprwV5G-reyRb7UWhEWw=23CzJS=yA@mail.gmail.com>
References: <igorm@etf.rs> <1346412841-31507-1-git-send-email-igorm@etf.rs>
	<50464C84.2030508@candelatech.com>
	<CAFdo_mVD=yqj2jb9Xfxy7oS7m=bMH1LkKo9RBZ-np-6NZBrLoA@mail.gmail.com>
	<CAFdo_mXEFbaTXmoQXDYsJK=Nvs7q+yKh=9u=qAzBYLvaSq5fVA@mail.gmail.com>
	<50735C39.6010607@candelatech.com>
	<CAFdo_mVAQW2288pjf505nprwV5G-reyRb7UWhEWw=23CzJS=yA@mail.gmail.com>
Message-ID: <50858103.3050205@candelatech.com>

On 10/09/2012 02:49 AM, Igor Maravi? wrote:
> I'm sending for BSD. I forgot to remove YYSTYPE...
> For Fedora it fails compiling because of some comparison between
> signed and unsigned integer inside function yy_get_next_buffer(). It
> seems like lex problem.
> Maybe to suppres all warnings?

Can you check the latest build failure and see if you can send
a patch for it?

Seems we added some specific hackery for this type of thing last
time we poked at lex/yacc stuff, so can probably just copy
that.

I'm pretty swamped with work right now, so it will probably be a while
until I get to this myself...

http://dmz2.candelatech.com:8010/builders/v-freebsd-32/builds/132/steps/shell_2/logs/stdio

Thanks,
Ben

> BR
> Igor
>
> 2012/10/9 Ben Greear <greearb at candelatech.com>:
>> On 10/01/2012 01:12 AM, Igor Maravi? wrote:
>>>
>>> Ben,
>>> I've just returned from my vacation.
>>> BR
>>> Igor
>>
>>
>> I pushed the 15 patches.  Seems it breaks the 'scons check' on Fedora 8 and
>> the BSD
>> machine:
>>
>> http://dmz2.candelatech.com:8010/waterfall
>>
>> Don't worry about 'clang', it always fails.
>>
>> Thanks,
>> Ben
>>
>>
>>>
>>> 2012/9/13 Igor Maravi? <igorm at etf.rs>:
>>>>
>>>> Ben,
>>>> I'm going on vacation this Saturday, and I'm going to be out of my
>>>> office for two weeks.
>>>> You can wait up with patches, if you wish, until I come back.
>>>> BR
>>>> Igor
>>>>
>>>> 2012/9/4 Ben Greear <greearb at candelatech.com>:
>>>>>
>>>>> On 08/31/2012 04:33 AM, igorm at etf.rs wrote:
>>>>>>
>>>>>>
>>>>>> From: Igor Maravic <igorm at etf.rs>
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> As suggested by Phil, I've added new operators for changing metric in
>>>>>> policy code.
>>>>>> New operators are *=, /=, <<=, >>=, &=, |= and ^=.
>>>>>>
>>>>>> I didn't have the time to test it thouroughly, so any volunteers to
>>>>>> test
>>>>>> the code are welcome. :)
>>>>>>
>>>>>> In the first patch I've added new patern for one line comments.
>>>>>> Everything after %% is considered a comment.
>>>>>>
>>>>>> In the last patch I've hacked RIP so the routes that have metric >
>>>>>> RIP_INFINITY would be pushed through the EXPORT filter. I've tested it,
>>>>>> and
>>>>>> it works. Unfortunatelly I'm not 100% sure if this hack is ok.
>>>>>>
>>>>>> All other patches should be fine!
>>>>>
>>>>>
>>>>>
>>>>> Just FYI, I haven't forgotten about these yet...and the previous patches
>>>>> for the xorp protocol plugin feature set.
>>>>>
>>>>> But, it will be a bit longer before I get to this..need to make sure
>>>>> I have the multicast fixes I've been working on all working properly
>>>>> first.
>>>>>
>>>>> I think after all of the pending patches are in, I'll start
>>>>> thinking about doing a release...
>>>>>
>>>>> Thanks,
>>>>> Ben
>>>>>
>>>>> --
>>>>> Ben Greear <greearb at candelatech.com>
>>>>> Candela Technologies Inc  http://www.candelatech.com
>>>>>
>>
>>
>> --
>> Ben Greear <greearb at candelatech.com>
>> Candela Technologies Inc  http://www.candelatech.com
>>


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


From igorm at etf.rs  Tue Oct 23 00:36:17 2012
From: igorm at etf.rs (=?ISO-8859-2?Q?Igor_Maravi=E6?=)
Date: Tue, 23 Oct 2012 09:36:17 +0200
Subject: [Xorp-hackers] [PATCH 00/15] Add new operators for changing
	metric in policy code
In-Reply-To: <50858103.3050205@candelatech.com>
References: <igorm@etf.rs> <1346412841-31507-1-git-send-email-igorm@etf.rs>
	<50464C84.2030508@candelatech.com>
	<CAFdo_mVD=yqj2jb9Xfxy7oS7m=bMH1LkKo9RBZ-np-6NZBrLoA@mail.gmail.com>
	<CAFdo_mXEFbaTXmoQXDYsJK=Nvs7q+yKh=9u=qAzBYLvaSq5fVA@mail.gmail.com>
	<50735C39.6010607@candelatech.com>
	<CAFdo_mVAQW2288pjf505nprwV5G-reyRb7UWhEWw=23CzJS=yA@mail.gmail.com>
	<50858103.3050205@candelatech.com>
Message-ID: <CAFdo_mX4OUQzBED5fCK9Kat+R6eMw6+4FVAq9LC0OFNRSne9Lg@mail.gmail.com>

Try to enable LEX_HACK when building tests.
It compiles when the LEX_HACK is enabled
(http://dmz2.candelatech.com:8010/builders/v-freebsd-32/builds/132/steps/shell_1/logs/stdio).

BR
Igor

2012/10/22 Ben Greear <greearb at candelatech.com>:
> On 10/09/2012 02:49 AM, Igor Maravi? wrote:
>>
>> I'm sending for BSD. I forgot to remove YYSTYPE...
>> For Fedora it fails compiling because of some comparison between
>> signed and unsigned integer inside function yy_get_next_buffer(). It
>> seems like lex problem.
>> Maybe to suppres all warnings?
>
>
> Can you check the latest build failure and see if you can send
> a patch for it?
>
> Seems we added some specific hackery for this type of thing last
> time we poked at lex/yacc stuff, so can probably just copy
> that.
>
> I'm pretty swamped with work right now, so it will probably be a while
> until I get to this myself...
>
> http://dmz2.candelatech.com:8010/builders/v-freebsd-32/builds/132/steps/shell_2/logs/stdio
>
> Thanks,
> Ben
>
>
>> BR
>> Igor
>>
>> 2012/10/9 Ben Greear <greearb at candelatech.com>:
>>>
>>> On 10/01/2012 01:12 AM, Igor Maravi? wrote:
>>>>
>>>>
>>>> Ben,
>>>> I've just returned from my vacation.
>>>> BR
>>>> Igor
>>>
>>>
>>>
>>> I pushed the 15 patches.  Seems it breaks the 'scons check' on Fedora 8
>>> and
>>> the BSD
>>> machine:
>>>
>>> http://dmz2.candelatech.com:8010/waterfall
>>>
>>> Don't worry about 'clang', it always fails.
>>>
>>> Thanks,
>>> Ben
>>>
>>>
>>>>
>>>> 2012/9/13 Igor Maravi? <igorm at etf.rs>:
>>>>>
>>>>>
>>>>> Ben,
>>>>> I'm going on vacation this Saturday, and I'm going to be out of my
>>>>> office for two weeks.
>>>>> You can wait up with patches, if you wish, until I come back.
>>>>> BR
>>>>> Igor
>>>>>
>>>>> 2012/9/4 Ben Greear <greearb at candelatech.com>:
>>>>>>
>>>>>>
>>>>>> On 08/31/2012 04:33 AM, igorm at etf.rs wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> From: Igor Maravic <igorm at etf.rs>
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> As suggested by Phil, I've added new operators for changing metric in
>>>>>>> policy code.
>>>>>>> New operators are *=, /=, <<=, >>=, &=, |= and ^=.
>>>>>>>
>>>>>>> I didn't have the time to test it thouroughly, so any volunteers to
>>>>>>> test
>>>>>>> the code are welcome. :)
>>>>>>>
>>>>>>> In the first patch I've added new patern for one line comments.
>>>>>>> Everything after %% is considered a comment.
>>>>>>>
>>>>>>> In the last patch I've hacked RIP so the routes that have metric >
>>>>>>> RIP_INFINITY would be pushed through the EXPORT filter. I've tested
>>>>>>> it,
>>>>>>> and
>>>>>>> it works. Unfortunatelly I'm not 100% sure if this hack is ok.
>>>>>>>
>>>>>>> All other patches should be fine!
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> Just FYI, I haven't forgotten about these yet...and the previous
>>>>>> patches
>>>>>> for the xorp protocol plugin feature set.
>>>>>>
>>>>>> But, it will be a bit longer before I get to this..need to make sure
>>>>>> I have the multicast fixes I've been working on all working properly
>>>>>> first.
>>>>>>
>>>>>> I think after all of the pending patches are in, I'll start
>>>>>> thinking about doing a release...
>>>>>>
>>>>>> Thanks,
>>>>>> Ben
>>>>>>
>>>>>> --
>>>>>> Ben Greear <greearb at candelatech.com>
>>>>>> Candela Technologies Inc  http://www.candelatech.com
>>>>>>
>>>
>>>
>>> --
>>> Ben Greear <greearb at candelatech.com>
>>> Candela Technologies Inc  http://www.candelatech.com
>>>
>
>
> --
> Ben Greear <greearb at candelatech.com>
> Candela Technologies Inc  http://www.candelatech.com
>