[Xorp-hackers] [PATCH 00/15] Add new operators for changing metric in policy code

Igor Maravić igorm at etf.rs
Tue Oct 23 00:36:17 PDT 2012


Try to enable LEX_HACK when building tests.
It compiles when the LEX_HACK is enabled
(http://dmz2.candelatech.com:8010/builders/v-freebsd-32/builds/132/steps/shell_1/logs/stdio).

BR
Igor

2012/10/22 Ben Greear <greearb at candelatech.com>:
> On 10/09/2012 02:49 AM, Igor Maravić wrote:
>>
>> I'm sending for BSD. I forgot to remove YYSTYPE...
>> For Fedora it fails compiling because of some comparison between
>> signed and unsigned integer inside function yy_get_next_buffer(). It
>> seems like lex problem.
>> Maybe to suppres all warnings?
>
>
> Can you check the latest build failure and see if you can send
> a patch for it?
>
> Seems we added some specific hackery for this type of thing last
> time we poked at lex/yacc stuff, so can probably just copy
> that.
>
> I'm pretty swamped with work right now, so it will probably be a while
> until I get to this myself...
>
> http://dmz2.candelatech.com:8010/builders/v-freebsd-32/builds/132/steps/shell_2/logs/stdio
>
> Thanks,
> Ben
>
>
>> BR
>> Igor
>>
>> 2012/10/9 Ben Greear <greearb at candelatech.com>:
>>>
>>> On 10/01/2012 01:12 AM, Igor Maravić wrote:
>>>>
>>>>
>>>> Ben,
>>>> I've just returned from my vacation.
>>>> BR
>>>> Igor
>>>
>>>
>>>
>>> I pushed the 15 patches.  Seems it breaks the 'scons check' on Fedora 8
>>> and
>>> the BSD
>>> machine:
>>>
>>> http://dmz2.candelatech.com:8010/waterfall
>>>
>>> Don't worry about 'clang', it always fails.
>>>
>>> Thanks,
>>> Ben
>>>
>>>
>>>>
>>>> 2012/9/13 Igor Maravić <igorm at etf.rs>:
>>>>>
>>>>>
>>>>> Ben,
>>>>> I'm going on vacation this Saturday, and I'm going to be out of my
>>>>> office for two weeks.
>>>>> You can wait up with patches, if you wish, until I come back.
>>>>> BR
>>>>> Igor
>>>>>
>>>>> 2012/9/4 Ben Greear <greearb at candelatech.com>:
>>>>>>
>>>>>>
>>>>>> On 08/31/2012 04:33 AM, igorm at etf.rs wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> From: Igor Maravic <igorm at etf.rs>
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> As suggested by Phil, I've added new operators for changing metric in
>>>>>>> policy code.
>>>>>>> New operators are *=, /=, <<=, >>=, &=, |= and ^=.
>>>>>>>
>>>>>>> I didn't have the time to test it thouroughly, so any volunteers to
>>>>>>> test
>>>>>>> the code are welcome. :)
>>>>>>>
>>>>>>> In the first patch I've added new patern for one line comments.
>>>>>>> Everything after %% is considered a comment.
>>>>>>>
>>>>>>> In the last patch I've hacked RIP so the routes that have metric >
>>>>>>> RIP_INFINITY would be pushed through the EXPORT filter. I've tested
>>>>>>> it,
>>>>>>> and
>>>>>>> it works. Unfortunatelly I'm not 100% sure if this hack is ok.
>>>>>>>
>>>>>>> All other patches should be fine!
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> Just FYI, I haven't forgotten about these yet...and the previous
>>>>>> patches
>>>>>> for the xorp protocol plugin feature set.
>>>>>>
>>>>>> But, it will be a bit longer before I get to this..need to make sure
>>>>>> I have the multicast fixes I've been working on all working properly
>>>>>> first.
>>>>>>
>>>>>> I think after all of the pending patches are in, I'll start
>>>>>> thinking about doing a release...
>>>>>>
>>>>>> Thanks,
>>>>>> Ben
>>>>>>
>>>>>> --
>>>>>> Ben Greear <greearb at candelatech.com>
>>>>>> Candela Technologies Inc  http://www.candelatech.com
>>>>>>
>>>
>>>
>>> --
>>> Ben Greear <greearb at candelatech.com>
>>> Candela Technologies Inc  http://www.candelatech.com
>>>
>
>
> --
> Ben Greear <greearb at candelatech.com>
> Candela Technologies Inc  http://www.candelatech.com
>



More information about the Xorp-hackers mailing list