From noreply at github.com Mon Sep 3 20:11:38 2012 From: noreply at github.com (GitHub) Date: Mon, 03 Sep 2012 20:11:38 -0700 Subject: [Xorp-hackers] [greearb/xorp.ct] c0c0c2: FEA: Use MREQN when joining mcast membership. Message-ID: <5045716ad7f09_981ff0af01869a3@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/greearb/xorp.ct Commit: c0c0c28a4e54f723bb612a9fea8eec3b71ead556 https://github.com/greearb/xorp.ct/commit/c0c0c28a4e54f723bb612a9fea8eec3b71ead556 Author: Ben Greear Date: 2012-09-03 (Mon, 03 Sep 2012) Changed paths: M xorp/fea/data_plane/io/io_ip_socket.cc Log Message: ----------- FEA: Use MREQN when joining mcast membership. This allows Xorp to work properly when multiple interfaces have the same IP address. Original patch by: Leonid Veytser Signed-off-by: Ben Greear From noreply at github.com Tue Sep 4 10:10:03 2012 From: noreply at github.com (GitHub) Date: Tue, 04 Sep 2012 10:10:03 -0700 Subject: [Xorp-hackers] [greearb/xorp.ct] 224af2: FEA: Use MREQN when leaving mcast membership. Message-ID: <504635ebc75d5_53b214abaf495824@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/greearb/xorp.ct Commit: 224af2da24739e25ea6a197c07de3c507f034aa1 https://github.com/greearb/xorp.ct/commit/224af2da24739e25ea6a197c07de3c507f034aa1 Author: Ben Greear Date: 2012-09-04 (Tue, 04 Sep 2012) Changed paths: M xorp/fea/data_plane/io/io_ip_socket.cc Log Message: ----------- FEA: Use MREQN when leaving mcast membership. This allows Xorp to work properly when multiple interfaces have the same IP address. Original patch by: Leonid Veytser Signed-off-by: Ben Greear From greearb at candelatech.com Tue Sep 4 11:46:28 2012 From: greearb at candelatech.com (Ben Greear) Date: Tue, 04 Sep 2012 11:46:28 -0700 Subject: [Xorp-hackers] [PATCH 00/15] Add new operators for changing metric in policy code In-Reply-To: <1346412841-31507-1-git-send-email-igorm@etf.rs> References: <1346412841-31507-1-git-send-email-igorm@etf.rs> Message-ID: <50464C84.2030508@candelatech.com> On 08/31/2012 04:33 AM, igorm at etf.rs wrote: > From: Igor Maravic > > Hi, > > As suggested by Phil, I've added new operators for changing metric in policy code. > New operators are *=, /=, <<=, >>=, &=, |= and ^=. > > I didn't have the time to test it thouroughly, so any volunteers to test the code are welcome. :) > > In the first patch I've added new patern for one line comments. > Everything after %% is considered a comment. > > In the last patch I've hacked RIP so the routes that have metric > RIP_INFINITY would be pushed through the EXPORT filter. I've tested it, and it works. Unfortunatelly I'm not 100% sure if this hack is ok. > > All other patches should be fine! Just FYI, I haven't forgotten about these yet...and the previous patches for the xorp protocol plugin feature set. But, it will be a bit longer before I get to this..need to make sure I have the multicast fixes I've been working on all working properly first. I think after all of the pending patches are in, I'll start thinking about doing a release... Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com From nenad.vukmirovic at etf.rs Tue Sep 11 10:29:31 2012 From: nenad.vukmirovic at etf.rs (Nenad Vukmirovic) Date: Tue, 11 Sep 2012 19:29:31 +0200 Subject: [Xorp-hackers] A problem with the Router Alert option Message-ID: I have a question about raw IPv4 packet input/output. I am working on a new XORP module (protocol) which uses raw IPv4 IO and relies on the Router Alert option to work properly. I have managed to send packets with that option (flag) set to ON successfully so far. I have also received packets that have the destination IP address of my router (in the IP header). However, it seems I cannot receive packets (with the Router Alert flag turned on) whose destination IP address doesn't match any address on my router. I have checked that those packets arrive at my router and that my router forwards them to their final destination, but those packets don't get inspected by my protocol (running on the router). Does anyone know if FEA is capable of letting such packets into the protocol to be inspected automatically? If it is, what part of my code should I change to make it work? Yours faithfully, Nenad Vukmirovic From noreply at github.com Wed Sep 12 14:30:39 2012 From: noreply at github.com (GitHub) Date: Wed, 12 Sep 2012 14:30:39 -0700 Subject: [Xorp-hackers] [greearb/xorp.ct] 2ba669: fea: Retry mcast joins. Message-ID: <5050feff639a1_79251702af050053@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/greearb/xorp.ct Commit: 2ba669aec46158a580ca97b9115376b6a40b7264 https://github.com/greearb/xorp.ct/commit/2ba669aec46158a580ca97b9115376b6a40b7264 Author: Ben Greear Date: 2012-09-05 (Wed, 05 Sep 2012) Changed paths: M xorp/fea/data_plane/io/io_ip_socket.cc Log Message: ----------- fea: Retry mcast joins. Might work around some transient issues related to bouncing interfaces. Signed-off-by: Ben Greear Commit: 331c29bc0d0d0461290e52ed23302d5af5ce3c41 https://github.com/greearb/xorp.ct/commit/331c29bc0d0d0461290e52ed23302d5af5ce3c41 Author: Ben Greear Date: 2012-09-05 (Wed, 05 Sep 2012) Changed paths: M xorp/pim/pim_config.cc M xorp/pim/pim_node.cc M xorp/pim/pim_vif.cc M xorp/pim/pim_vif.hh Log Message: ----------- pim: Store dr_priority in perm_info settings. And now we don't have to fail if something sets dr_priority on VIF that doesn't exist. Signed-off-by: Ben Greear Commit: c021d3c1792fb01a6b929bc1c88f0d141223676c https://github.com/greearb/xorp.ct/commit/c021d3c1792fb01a6b929bc1c88f0d141223676c Author: Ben Greear Date: 2012-09-05 (Wed, 05 Sep 2012) Changed paths: M xorp/fea/mfea_mrouter.cc M xorp/fea/mfea_node.cc M xorp/fea/mfea_vif.cc Log Message: ----------- mfea: trigger update logic when IP addrs change too. Signed-off-by: Ben Greear Commit: 162df3b5af471a58911f52a8dafb6c3da64f1500 https://github.com/greearb/xorp.ct/commit/162df3b5af471a58911f52a8dafb6c3da64f1500 Author: Ben Greear Date: 2012-09-06 (Thu, 06 Sep 2012) Changed paths: M xorp/pim/pim_config.cc M xorp/pim/pim_vif.cc M xorp/pim/pim_vif.hh Log Message: ----------- pim: Store hello-period config for later if vif is NULL. Helps with interfaces coming and going, and being gone on startup. Signed-off-by: Ben Greear Commit: 5146c7489d2c5da5472c161ea3543c7208514591 https://github.com/greearb/xorp.ct/commit/5146c7489d2c5da5472c161ea3543c7208514591 Author: Ben Greear Date: 2012-09-06 (Thu, 06 Sep 2012) Changed paths: M xorp/pim/pim_node.cc M xorp/pim/pim_vif.cc Log Message: ----------- pim: Try to start vif later if IP addr is invalid. Instead of just failing to start and thus failing the commit and causing xorp to stop... Signed-off-by: Ben Greear Commit: 975dd3b628f1a52c415fe6978869f83715e22b2f https://github.com/greearb/xorp.ct/commit/975dd3b628f1a52c415fe6978869f83715e22b2f Author: Ben Greear Date: 2012-09-06 (Thu, 06 Sep 2012) Changed paths: M xorp/pim/pim_config.cc M xorp/pim/pim_node.cc M xorp/pim/pim_node.hh M xorp/pim/pim_vif.cc M xorp/pim/pim_vif.hh Log Message: ----------- pim: Consolidate vif set/reset logic, store it permanently. Better than one-by-one fixes to cache each item, hopefully. Signed-off-by: Ben Greear Commit: ba0f724a531df54ea9a4fd007c5b63da52b766ab https://github.com/greearb/xorp.ct/commit/ba0f724a531df54ea9a4fd007c5b63da52b766ab Author: Ben Greear Date: 2012-09-06 (Thu, 06 Sep 2012) Changed paths: M xorp/pim/pim_config.cc M xorp/pim/pim_proto_hello.cc M xorp/pim/pim_vif.cc Log Message: ----------- pim: Fix bugs in last commit. Don't try to send packets when vif is not up or pending down. Signed-off-by: Ben Greear Commit: 18d21f10897c89c3f1df5803c3343f04098d1ce3 https://github.com/greearb/xorp.ct/commit/18d21f10897c89c3f1df5803c3343f04098d1ce3 Author: Ben Greear Date: 2012-09-06 (Thu, 06 Sep 2012) Changed paths: M xorp/pim/pim_node.cc Log Message: ----------- pim: Create vif if needed when trying to start vif. Signed-off-by: Ben Greear Commit: 22fa0bcdc3739f67ca8cfa71ebb241f9e6774701 https://github.com/greearb/xorp.ct/commit/22fa0bcdc3739f67ca8cfa71ebb241f9e6774701 Author: Ben Greear Date: 2012-09-06 (Thu, 06 Sep 2012) Changed paths: M xorp/pim/pim_node.cc Log Message: ----------- pim: More debugging for failure to start vif. Signed-off-by: Ben Greear Commit: 548a590ac5af3e987fb1ab39e8e6fb2983c0f8d1 https://github.com/greearb/xorp.ct/commit/548a590ac5af3e987fb1ab39e8e6fb2983c0f8d1 Author: Ben Greear Date: 2012-09-07 (Fri, 07 Sep 2012) Changed paths: M xorp/pim/xrl_pim_node.cc Log Message: ----------- pim: More logging for register/unregister logic. Signed-off-by: Ben Greear Commit: 52e0e5f51e6fbf2fd2165b7f012751091e84dbad https://github.com/greearb/xorp.ct/commit/52e0e5f51e6fbf2fd2165b7f012751091e84dbad Author: Ben Greear Date: 2012-09-07 (Fri, 07 Sep 2012) Changed paths: M xorp/fea/data_plane/io/io_ip_socket.cc M xorp/fea/mfea_mrouter.cc M xorp/fea/mfea_node.cc M xorp/fea/xrl_mfea_node.cc M xorp/libxipc/xrl_pf_stcp.cc M xorp/rib/rib.cc M xorp/rib/rib.hh M xorp/rib/rib_manager.cc M xorp/rib/vifmanager.cc Log Message: ----------- logging: Decrease severity of some logging, improve others. rib errors about not being able to delete interfaces that are already gone should be warnings, and add some extra info when the IPC readers die. Signed-off-by: Ben Greear Commit: efe4ba3f51ffcf96370cc1a7dded94337f8ef224 https://github.com/greearb/xorp.ct/commit/efe4ba3f51ffcf96370cc1a7dded94337f8ef224 Author: Ben Greear Date: 2012-09-07 (Fri, 07 Sep 2012) Changed paths: M xorp/fea/mfea_node.cc Log Message: ----------- mfea: Add more debugging around mfea-vif update assert. Need to figure out why the vif_index is invalid... Signed-off-by: Ben Greear Commit: d8f1b1d602da5d4d8b31cd25ee3eef3e342d76ce https://github.com/greearb/xorp.ct/commit/d8f1b1d602da5d4d8b31cd25ee3eef3e342d76ce Author: Ben Greear Date: 2012-09-07 (Fri, 07 Sep 2012) Changed paths: M xorp/fea/mfea_mrouter.cc M xorp/fea/mfea_mrouter.hh M xorp/fea/mfea_node.cc M xorp/fea/mfea_node.hh M xorp/fea/mfea_vif.cc Log Message: ----------- mfea: Attempt restart if could not register mcast vif. Previous code would just fail and would not retry later. Also clean up the logging a bit and pass the error message back up the stack. Signed-off-by: Ben Greear Commit: 8c6d10c8e7c2260a3c683d73dff603e7b804c4bb https://github.com/greearb/xorp.ct/commit/8c6d10c8e7c2260a3c683d73dff603e7b804c4bb Author: Ben Greear Date: 2012-09-07 (Fri, 07 Sep 2012) Changed paths: M xorp/pim/pim_vif.cc M xorp/pim/pim_vif.hh M xorp/pim/xrl_pim_node.cc M xorp/pim/xrl_pim_node.hh Log Message: ----------- pim: Retry mcast join if it fails. Seems that races with interface creation/deletion can cause this to fail in FEA due to not finding VIF there. Retry the joins... Signed-off-by: Ben Greear Compare: https://github.com/greearb/xorp.ct/compare/224af2da2473...8c6d10c8e7c2 From igorm at etf.rs Thu Sep 13 00:32:02 2012 From: igorm at etf.rs (=?ISO-8859-2?Q?Igor_Maravi=E6?=) Date: Thu, 13 Sep 2012 09:32:02 +0200 Subject: [Xorp-hackers] [PATCH 00/15] Add new operators for changing metric in policy code In-Reply-To: <50464C84.2030508@candelatech.com> References: <1346412841-31507-1-git-send-email-igorm@etf.rs> <50464C84.2030508@candelatech.com> Message-ID: Ben, I'm going on vacation this Saturday, and I'm going to be out of my office for two weeks. You can wait up with patches, if you wish, until I come back. BR Igor 2012/9/4 Ben Greear : > On 08/31/2012 04:33 AM, igorm at etf.rs wrote: >> >> From: Igor Maravic >> >> Hi, >> >> As suggested by Phil, I've added new operators for changing metric in >> policy code. >> New operators are *=, /=, <<=, >>=, &=, |= and ^=. >> >> I didn't have the time to test it thouroughly, so any volunteers to test >> the code are welcome. :) >> >> In the first patch I've added new patern for one line comments. >> Everything after %% is considered a comment. >> >> In the last patch I've hacked RIP so the routes that have metric > >> RIP_INFINITY would be pushed through the EXPORT filter. I've tested it, and >> it works. Unfortunatelly I'm not 100% sure if this hack is ok. >> >> All other patches should be fine! > > > Just FYI, I haven't forgotten about these yet...and the previous patches > for the xorp protocol plugin feature set. > > But, it will be a bit longer before I get to this..need to make sure > I have the multicast fixes I've been working on all working properly > first. > > I think after all of the pending patches are in, I'll start > thinking about doing a release... > > Thanks, > Ben > > -- > Ben Greear > Candela Technologies Inc http://www.candelatech.com > From greearb at candelatech.com Fri Sep 14 09:12:24 2012 From: greearb at candelatech.com (Ben Greear) Date: Fri, 14 Sep 2012 09:12:24 -0700 Subject: [Xorp-hackers] A problem with the Router Alert option In-Reply-To: References: Message-ID: <50535768.8060209@candelatech.com> On 09/11/2012 10:29 AM, Nenad Vukmirovic wrote: > I have a question about raw IPv4 packet input/output. > > I am working on a new XORP module (protocol) which uses raw IPv4 IO and > relies on the Router Alert option to work properly. I have managed to send > packets with that option (flag) set to ON successfully so far. I have also > received packets that have the destination IP address of my router (in the > IP header). > > However, it seems I cannot receive packets (with the Router Alert flag > turned on) whose destination IP address doesn't match any address on my > router. > > I have checked that those packets arrive at my router and that my router > forwards them to their final destination, but those packets don't get > inspected by my protocol (running on the router). > > Does anyone know if FEA is capable of letting such packets into the > protocol to be inspected automatically? If it is, what part of my code > should I change to make it work? Not sure, but the 'io_ip_socket.cc' file is likely the place to start looking. You might have to create a socket that listens for all packets and then uses a pcap-filter to deliver only the RA packets to user-space? Thanks, Ben > > Yours faithfully, > Nenad Vukmirovic > > > _______________________________________________ > Xorp-hackers mailing list > Xorp-hackers at icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers > -- Ben Greear Candela Technologies Inc http://www.candelatech.com From noreply at github.com Tue Sep 18 13:02:02 2012 From: noreply at github.com (GitHub) Date: Tue, 18 Sep 2012 13:02:02 -0700 Subject: [Xorp-hackers] [greearb/xorp.ct] 313ca1: rib: Fix ref-counting in RouteEntry class. Message-ID: <5058d33aae7cb_457c171aaec93097@sh3.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/greearb/xorp.ct Commit: 313ca1e7398fbe76b32f2a638f8daf101d07c15e https://github.com/greearb/xorp.ct/commit/313ca1e7398fbe76b32f2a638f8daf101d07c15e Author: Ben Greear Date: 2012-09-18 (Tue, 18 Sep 2012) Changed paths: M xorp/libxorp/vif.cc M xorp/libxorp/vif.hh M xorp/rib/redist_policy.hh M xorp/rib/redist_xrl.cc M xorp/rib/rib.cc M xorp/rib/rib.hh M xorp/rib/route.cc M xorp/rib/route.hh M xorp/rib/rt_tab_register.cc Log Message: ----------- rib: Fix ref-counting in RouteEntry class. RouteEntry does ref-counting on the vif object, but it did not implement copy constructors or operator=. This means ref-counting didn't work right. Attempt to fix this by properly implementing the copy constructors and operator= methods in RouteEntry and child classes. RIB is still a scary mess of pointers, but maybe this helps a bit. Signed-off-by: Ben Greear From noreply at github.com Tue Sep 18 20:50:21 2012 From: noreply at github.com (GitHub) Date: Tue, 18 Sep 2012 20:50:21 -0700 Subject: [Xorp-hackers] [greearb/xorp.ct] e47ef8: static: Change assert to warning when cannot un-r... Message-ID: <505940fd19852_76de1d37aec73665@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/greearb/xorp.ct Commit: e47ef88ba1fe9e7ea443ecb1962972b1d1735b5f https://github.com/greearb/xorp.ct/commit/e47ef88ba1fe9e7ea443ecb1962972b1d1735b5f Author: Ben Greear Date: 2012-09-18 (Tue, 18 Sep 2012) Changed paths: M xorp/static_routes/xrl_static_routes_node.cc Log Message: ----------- static: Change assert to warning when cannot un-register table. Signed-off-by: Ben Greear Commit: e59d4894110a5d8cd975c8480c20ca3e42989fdb https://github.com/greearb/xorp.ct/commit/e59d4894110a5d8cd975c8480c20ca3e42989fdb Author: Ben Greear Date: 2012-09-18 (Tue, 18 Sep 2012) Changed paths: M xorp/static_routes/xrl_static_routes_node.cc Log Message: ----------- static: Don't assert if we fail to de-register IPv6 igp table. Compare: https://github.com/greearb/xorp.ct/compare/313ca1e7398f...e59d4894110a From rkerur at gmail.com Wed Sep 26 15:43:18 2012 From: rkerur at gmail.com (ravi kerur) Date: Wed, 26 Sep 2012 15:43:18 -0700 Subject: [Xorp-hackers] Q on MP-BGP and LDP Message-ID: Hello, I am currently working on developing LDP for Quagga and due to issues (some technical and non-technical) I am reaching out to XORP as an alternate solution and wanted to get some technical insight into contributing to XORP. 1. I see RFC 2858 mentioned in bgp/specs directory, I am assuming MP-BGP support is available in current XORP code base? 2. Does XORP take advantage of multi-core SMP processors? I believe Quagga has a bottleneck architecture here, please correct me if I am wrong. 3. XORP code is developed in C++, is it mandatory to have development in C++ i.e. If I want to bring in LDP code from Quagga do I need to modify it from C to C++? 4. Do you performance numbers published i.e I am more inteested in network convergence numbers? Inputs appreciated. Thanks, Ravi -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-hackers/attachments/20120926/b2579c64/attachment.html From greearb at candelatech.com Wed Sep 26 15:58:49 2012 From: greearb at candelatech.com (Ben Greear) Date: Wed, 26 Sep 2012 15:58:49 -0700 Subject: [Xorp-hackers] Q on MP-BGP and LDP In-Reply-To: References: Message-ID: <506388A9.2080501@candelatech.com> On 09/26/2012 03:43 PM, ravi kerur wrote: > Hello, > > I am currently working on developing LDP for Quagga and due to issues (some technical and non-technical) I am reaching out to XORP as an alternate solution and > wanted to get some technical insight into contributing to XORP. > > 1. I see RFC 2858 mentioned in bgp/specs directory, I am assuming MP-BGP support is available in current XORP code base? I don't know..haven't used more than just the basics for BGP. > > 2. Does XORP take advantage of multi-core SMP processors? I believe Quagga has a bottleneck architecture here, please correct me if I am wrong. Yes, at least to some degree. But, I'm not sure it would be any faster since there is a lot of overhead in the IPC message passing. > 3. XORP code is developed in C++, is it mandatory to have development in C++ i.e. If I want to bring in LDP code from Quagga do I need to modify it from C to C++? No...if it compiles and works (and is GPL), then it will be considered for inclusion. git-format patch series are preferred. > 4. Do you performance numbers published i.e I am more inteested in network convergence numbers? No..but interested in knowing your results if you do any tests... Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com