[Xorp-hackers] [greearb/xorp.ct] 2ba669: fea: Retry mcast joins.

GitHub noreply at github.com
Wed Sep 12 14:30:39 PDT 2012


  Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct
  Commit: 2ba669aec46158a580ca97b9115376b6a40b7264
      https://github.com/greearb/xorp.ct/commit/2ba669aec46158a580ca97b9115376b6a40b7264
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M xorp/fea/data_plane/io/io_ip_socket.cc

  Log Message:
  -----------
  fea:  Retry mcast joins.

Might work around some transient issues related to bouncing
interfaces.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 331c29bc0d0d0461290e52ed23302d5af5ce3c41
      https://github.com/greearb/xorp.ct/commit/331c29bc0d0d0461290e52ed23302d5af5ce3c41
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M xorp/pim/pim_config.cc
    M xorp/pim/pim_node.cc
    M xorp/pim/pim_vif.cc
    M xorp/pim/pim_vif.hh

  Log Message:
  -----------
  pim:  Store dr_priority in perm_info settings.

And now we don't have to fail if something sets
dr_priority on VIF that doesn't exist.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: c021d3c1792fb01a6b929bc1c88f0d141223676c
      https://github.com/greearb/xorp.ct/commit/c021d3c1792fb01a6b929bc1c88f0d141223676c
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M xorp/fea/mfea_mrouter.cc
    M xorp/fea/mfea_node.cc
    M xorp/fea/mfea_vif.cc

  Log Message:
  -----------
  mfea:  trigger update logic when IP addrs change too.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 162df3b5af471a58911f52a8dafb6c3da64f1500
      https://github.com/greearb/xorp.ct/commit/162df3b5af471a58911f52a8dafb6c3da64f1500
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-09-06 (Thu, 06 Sep 2012)

  Changed paths:
    M xorp/pim/pim_config.cc
    M xorp/pim/pim_vif.cc
    M xorp/pim/pim_vif.hh

  Log Message:
  -----------
  pim:  Store hello-period config for later if vif is NULL.

Helps with interfaces coming and going, and being gone
on startup.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 5146c7489d2c5da5472c161ea3543c7208514591
      https://github.com/greearb/xorp.ct/commit/5146c7489d2c5da5472c161ea3543c7208514591
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-09-06 (Thu, 06 Sep 2012)

  Changed paths:
    M xorp/pim/pim_node.cc
    M xorp/pim/pim_vif.cc

  Log Message:
  -----------
  pim:  Try to start vif later if IP addr is invalid.

Instead of just failing to start and thus failing the commit
and causing xorp to stop...

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 975dd3b628f1a52c415fe6978869f83715e22b2f
      https://github.com/greearb/xorp.ct/commit/975dd3b628f1a52c415fe6978869f83715e22b2f
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-09-06 (Thu, 06 Sep 2012)

  Changed paths:
    M xorp/pim/pim_config.cc
    M xorp/pim/pim_node.cc
    M xorp/pim/pim_node.hh
    M xorp/pim/pim_vif.cc
    M xorp/pim/pim_vif.hh

  Log Message:
  -----------
  pim:  Consolidate vif set/reset logic, store it permanently.

Better than one-by-one fixes to cache each item, hopefully.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: ba0f724a531df54ea9a4fd007c5b63da52b766ab
      https://github.com/greearb/xorp.ct/commit/ba0f724a531df54ea9a4fd007c5b63da52b766ab
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-09-06 (Thu, 06 Sep 2012)

  Changed paths:
    M xorp/pim/pim_config.cc
    M xorp/pim/pim_proto_hello.cc
    M xorp/pim/pim_vif.cc

  Log Message:
  -----------
  pim:  Fix bugs in last commit.

Don't try to send packets when vif is not up
or pending down.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 18d21f10897c89c3f1df5803c3343f04098d1ce3
      https://github.com/greearb/xorp.ct/commit/18d21f10897c89c3f1df5803c3343f04098d1ce3
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-09-06 (Thu, 06 Sep 2012)

  Changed paths:
    M xorp/pim/pim_node.cc

  Log Message:
  -----------
  pim:  Create vif if needed when trying to start vif.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 22fa0bcdc3739f67ca8cfa71ebb241f9e6774701
      https://github.com/greearb/xorp.ct/commit/22fa0bcdc3739f67ca8cfa71ebb241f9e6774701
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-09-06 (Thu, 06 Sep 2012)

  Changed paths:
    M xorp/pim/pim_node.cc

  Log Message:
  -----------
  pim:  More debugging for failure to start vif.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 548a590ac5af3e987fb1ab39e8e6fb2983c0f8d1
      https://github.com/greearb/xorp.ct/commit/548a590ac5af3e987fb1ab39e8e6fb2983c0f8d1
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-09-07 (Fri, 07 Sep 2012)

  Changed paths:
    M xorp/pim/xrl_pim_node.cc

  Log Message:
  -----------
  pim:  More logging for register/unregister logic.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 52e0e5f51e6fbf2fd2165b7f012751091e84dbad
      https://github.com/greearb/xorp.ct/commit/52e0e5f51e6fbf2fd2165b7f012751091e84dbad
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-09-07 (Fri, 07 Sep 2012)

  Changed paths:
    M xorp/fea/data_plane/io/io_ip_socket.cc
    M xorp/fea/mfea_mrouter.cc
    M xorp/fea/mfea_node.cc
    M xorp/fea/xrl_mfea_node.cc
    M xorp/libxipc/xrl_pf_stcp.cc
    M xorp/rib/rib.cc
    M xorp/rib/rib.hh
    M xorp/rib/rib_manager.cc
    M xorp/rib/vifmanager.cc

  Log Message:
  -----------
  logging:  Decrease severity of some logging, improve others.

rib errors about not being able to delete interfaces that are
already gone should be warnings, and add some extra info when
the IPC readers die.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: efe4ba3f51ffcf96370cc1a7dded94337f8ef224
      https://github.com/greearb/xorp.ct/commit/efe4ba3f51ffcf96370cc1a7dded94337f8ef224
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-09-07 (Fri, 07 Sep 2012)

  Changed paths:
    M xorp/fea/mfea_node.cc

  Log Message:
  -----------
  mfea:  Add more debugging around mfea-vif update assert.

Need to figure out why the vif_index is invalid...

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: d8f1b1d602da5d4d8b31cd25ee3eef3e342d76ce
      https://github.com/greearb/xorp.ct/commit/d8f1b1d602da5d4d8b31cd25ee3eef3e342d76ce
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-09-07 (Fri, 07 Sep 2012)

  Changed paths:
    M xorp/fea/mfea_mrouter.cc
    M xorp/fea/mfea_mrouter.hh
    M xorp/fea/mfea_node.cc
    M xorp/fea/mfea_node.hh
    M xorp/fea/mfea_vif.cc

  Log Message:
  -----------
  mfea:  Attempt restart if could not register mcast vif.

Previous code would just fail and would not retry later.
Also clean up the logging a bit and pass the error message
back up the stack.

Signed-off-by: Ben Greear <greearb at candelatech.com>


  Commit: 8c6d10c8e7c2260a3c683d73dff603e7b804c4bb
      https://github.com/greearb/xorp.ct/commit/8c6d10c8e7c2260a3c683d73dff603e7b804c4bb
  Author: Ben Greear <greearb at candelatech.com>
  Date:   2012-09-07 (Fri, 07 Sep 2012)

  Changed paths:
    M xorp/pim/pim_vif.cc
    M xorp/pim/pim_vif.hh
    M xorp/pim/xrl_pim_node.cc
    M xorp/pim/xrl_pim_node.hh

  Log Message:
  -----------
  pim:  Retry mcast join if it fails.

Seems that races with interface creation/deletion can cause
this to fail in FEA due to not finding VIF there.  Retry
the joins...

Signed-off-by: Ben Greear <greearb at candelatech.com>


Compare: https://github.com/greearb/xorp.ct/compare/224af2da2473...8c6d10c8e7c2


More information about the Xorp-hackers mailing list