[Xorp-users] ERROR xorp_rtrmgr:89197 FINDER +381 finder_tcp_messenger.cc do_auto_connect

[Pavlin Radoslavov]

> 
> >The manual tests I ran failed on FreeBSD 5.3 with the same errors
> >you've seen, so there has been a bad commit to CVS.  Unlucky this
> >should happen right when the tinderbox was broken, but I guess that's
> >Murphy's law for you.
> >
> >We will get this fixed as soon as possible.  Sorry for the problems,
> >and thanks for reporting this.
> 
> If you're in a hurry, here's a diff that appears to fix this problem.
> I'm not really familiar with this code, so it's possible this isn't
> the best solution, but it does appear to work for me on FreeBSD 5.3.
> I'll leave it to someone with a better understanding of this part of
> the code than me to commit an official fix into CVS.

Yes, the fix is correct and is committed to CVS. Thanks for the
catch!

Guilty as charged,
Pavlin

> 
> Cheers,	  
> 	  Mark
> 
> 
> vulture.xorp.org: cd xorp/xorp/libcomm/
> vulture.xorp.org: cvs diff
> cvs diff: Diffing .
> Index: comm_user.c
> ===================================================================
> RCS file: /usr/local/share/doc/apache/cvs/xorp/libcomm/comm_user.c,v
> retrieving revision 1.17
> diff -r1.17 comm_user.c
> 612c612
> <       if (is_blocking && (in_progress != NULL) && (*in_progress == 1))
> ---
> >       if ((!is_blocking) && (in_progress != NULL) && (*in_progress == 1))
> 658c658
> <       if (is_blocking && (in_progress != NULL) && (*in_progress == 1))
> ---
> >       if ((!is_blocking) && (in_progress != NULL) && (*in_progress == 1))
> 711c711
> <       if (is_blocking && (in_progress != NULL) && (*in_progress == 1))
> ---
> >       if ((!is_blocking) && (in_progress != NULL) && (*in_progress == 1))
> 757c757
> <       if (is_blocking && (in_progress != NULL) && (*in_progress == 1))
> ---
> >       if ((!is_blocking) && (in_progress != NULL) && (*in_progress == 1))
> _______________________________________________
> Xorp-users mailing list
> Xorp-users@xorp.org
> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-users