[Xorp-users] xorp_rib SEGV when removing interface while using OSPF.
Ben Greear
greearb at candelatech.com
Tue Sep 25 09:43:31 PDT 2007
Pavlin Radoslavov wrote:
> Ben Greear <greearb at candelatech.com> wrote:
>
>> While testing removing interfaces & OSPF, I get a core from rib_xorp.
>> The backtrace shows that
>> the net object has a _vif that is bad memory (ie, already deleted as far
>> as I can tell.)
>>
>> I believe it might be because of this code in rib.cc. It is cleaning
>> out all of the
>> 'directly connected' routes, but maybe it is not cleaning up OSPF routes?
>>
>> Since we are deleting the vif object, I think we should notify all
>> tables that the
>> vif is being deleted and have it delete any route that references the
>> vif, regardless
>> of what IP the route is. Otherwise, stale memory will be referenced
>> next time
>> something messes with the routes on the dead interface.
>
> Without looking into all details, I think your intuition is right.
> Could you open a Bugzilla entry for the issue and include
> instuctions how to reproduce the issue. Without such instructions it
> will be much more difficult to track and fix the issue.
A great many things fail when you try to add/remove interfaces and/or
addresses, at least when using OSPF.
I think you will find bugs in almost any action you take, so it's not
really worth writing a detailed bug at this point.
(Try just changing an IP address w/out doing a commit between the remove
and the add of the new IP, for instance.)
Try a 'commit' and wonder why it takes multiple seconds to complete, etc.
I will work on this crash bug and others as time permits. Due to the fun of CVS, it's
difficult for me to send you specific change-sets, but if you can put
the 'unreachable' patch into CVS I can send you a new diff with my other
changes.
Thanks,
Ben
--
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc http://www.candelatech.com
More information about the Xorp-users
mailing list