From jose.calhariz at tecnico.ulisboa.pt Sun Jul 3 04:08:31 2016 From: jose.calhariz at tecnico.ulisboa.pt (Jose M Calhariz) Date: Sun, 3 Jul 2016 12:08:31 +0100 Subject: [Xorp-users] Beta testers for new debian package of xorp Message-ID: <20160703110831.GA20403@calhariz.com> I am preparing a new Debian package for xorp. This new version have hardening turned on and is from the lastest code on git. I am requesting beta testers to check that is OK, because I can no longer test it, before uploading the result to Debian. Send a private email to me and I can provide with the source code of the package or a compiled package for i386 and amd64 for any version of Debian. Kind regards Jose M Calhariz -- -- Os analistas de sistema adoram fazer programa, mas s? entre eles. O que obriga suas mulheres a chamarem o padeiro, o leiteiro ou o entregador de pizza. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: Digital signature Url : http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-users/attachments/20160703/60ed563b/attachment.bin From greearb at candelatech.com Sun Jul 3 04:26:28 2016 From: greearb at candelatech.com (Ben Greear) Date: Sun, 03 Jul 2016 04:26:28 -0700 Subject: [Xorp-users] Beta testers for new debian package of xorp In-Reply-To: <20160703110831.GA20403@calhariz.com> References: <20160703110831.GA20403@calhariz.com> Message-ID: <5778F664.7020600@candelatech.com> On 07/03/2016 04:08 AM, Jose M Calhariz wrote: > > I am preparing a new Debian package for xorp. This new version have > hardening turned on and is from the lastest code on git. I am > requesting beta testers to check that is OK, because I can no longer > test it, before uploading the result to Debian. Send a private email > to me and I can provide with the source code of the package or a > compiled package for i386 and amd64 for any version of Debian. If you made any code changes, please post patches. Thanks, Ben > > Kind regards > Jose M Calhariz > > > > > _______________________________________________ > Xorp-users mailing list > Xorp-users at xorp.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-users > -- Ben Greear Candela Technologies Inc http://www.candelatech.com From jose.calhariz at tecnico.ulisboa.pt Sun Jul 3 05:10:07 2016 From: jose.calhariz at tecnico.ulisboa.pt (Jose M Calhariz) Date: Sun, 3 Jul 2016 13:10:07 +0100 Subject: [Xorp-users] Beta testers for new debian package of xorp In-Reply-To: <5778F664.7020600@candelatech.com> References: <20160703110831.GA20403@calhariz.com> <5778F664.7020600@candelatech.com> Message-ID: <20160703121006.GB20403@calhariz.com> On Sun, Jul 03, 2016 at 04:26:28AM -0700, Ben Greear wrote: > On 07/03/2016 04:08 AM, Jose M Calhariz wrote: > > > >I am preparing a new Debian package for xorp. This new version have > >hardening turned on and is from the lastest code on git. I am > >requesting beta testers to check that is OK, because I can no longer > >test it, before uploading the result to Debian. Send a private email > >to me and I can provide with the source code of the package or a > >compiled package for i386 and amd64 for any version of Debian. > > If you made any code changes, please post patches. I will. Until now is one liners fixes. > > Thanks, > Ben > Kind regards Jose M Calhariz > > > >Kind regards > >Jose M Calhariz > > > > > > > > > >_______________________________________________ > >Xorp-users mailing list > >Xorp-users at xorp.org > >http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-users > > > > -- -- Os analistas de sistema adoram fazer programa, mas s? entre eles. O que obriga suas mulheres a chamarem o padeiro, o leiteiro ou o entregador de pizza. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: Digital signature Url : http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-users/attachments/20160703/e4ebe31c/attachment.bin From jose.calhariz at tecnico.ulisboa.pt Tue Jul 5 11:43:47 2016 From: jose.calhariz at tecnico.ulisboa.pt (Jose M Calhariz) Date: Tue, 5 Jul 2016 19:43:47 +0100 Subject: [Xorp-users] Lastest xorp git fails to compile with g++ 6.0 In-Reply-To: <20160627121640.GA20508@calhariz.com> References: <20160627121640.GA20508@calhariz.com> Message-ID: <20160705184347.GA28503@calhariz.com> On Mon, Jun 27, 2016 at 01:16:40PM +0100, Jose M Calhariz wrote: > > Debian is preparing for the future gcc/g++ 6.0. I fetched the lastest > xorp from git and done a compile with it. There is new warnings and > errors. Because the build have failed I attach the log of the > build. Debian is going to ship gcc/g++ 6.x. But xorp does not compile. I need help to fix the g++ error. If not xorp will be dropped out of next release of Debian. The error is: fea/data_plane/io/io_ip_socket.cc:2374:3: error: no match for 'operator<' (operand types are 'std::_Bind_helper::type {aka std::_Bind}' and 'int') if (bind(_proto_socket_out, ~~~~~~~~~~~~~~~~~~~~~~~ reinterpret_cast(&sin), ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sizeof(sin)) ~~~~~~~~~~~~ < 0) { ^~~ For more information contact me, or see the attachment in the previous email. > > Kind regards > Jose M Calhariz > > Kind regards Jose M Calhariz > _______________________________________________ > Xorp-users mailing list > Xorp-users at xorp.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-users -- -- Uma autobiografia ? um obituario em forma de seriado, ao qual falta o ?ltimo cap?tulo. -- Quentin Crisp -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: Digital signature Url : http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-users/attachments/20160705/6eb793c5/attachment.bin From jose.calhariz at tecnico.ulisboa.pt Fri Jul 8 02:54:19 2016 From: jose.calhariz at tecnico.ulisboa.pt (Jose M Calhariz) Date: Fri, 8 Jul 2016 10:54:19 +0100 Subject: [Xorp-users] Beta testers for new debian package of xorp In-Reply-To: <5778F664.7020600@candelatech.com> References: <20160703110831.GA20403@calhariz.com> <5778F664.7020600@candelatech.com> Message-ID: <20160708095410.GA6538@calhariz.com> On Sun, Jul 03, 2016 at 04:26:28AM -0700, Ben Greear wrote: > On 07/03/2016 04:08 AM, Jose M Calhariz wrote: > > > >I am preparing a new Debian package for xorp. This new version have > >hardening turned on and is from the lastest code on git. I am > >requesting beta testers to check that is OK, because I can no longer > >test it, before uploading the result to Debian. Send a private email > >to me and I can provide with the source code of the package or a > >compiled package for i386 and amd64 for any version of Debian. > > If you made any code changes, please post patches. > > Thanks, > Ben > The g++ 6.x compiler now barks at this function: Index: xorp-1.8.6~wip.20160217/rip/output.hh =================================================================== --- xorp-1.8.6~wip.20160217.orig/rip/output.hh 2016-07-07 20:38:44.732183207 +0100 +++ xorp-1.8.6~wip.20160217/rip/output.hh 2016-07-07 20:39:52.281766177 +0100 @@ -97,7 +97,7 @@ public: /** * Get number of packets placed on packet queue for output. */ - void packets_sent() const { return _pkts_out; } + void packets_sent() const { return; } protected: /** And I am guessing this fix is needed: Index: xorp-1.8.6~wip.20160217/libxorp/trie.hh =================================================================== --- xorp-1.8.6~wip.20160217.orig/libxorp/trie.hh 2013-08-14 19:35:45.000000000 +0100 +++ xorp-1.8.6~wip.20160217/libxorp/trie.hh 2016-07-08 10:38:54.943000432 +0100 @@ -244,8 +244,9 @@ public: lo = x->high(); ++lo; hi = n->_right->low(); --hi; } else if (a <= n->_right->_k.top_addr()) { // case 4: - if (n->_left && a > n->_left->_k.top_addr()) + if (n->_left && a > n->_left->_k.top_addr()) { lo = n->_left->high(); ++lo; + } n = n->_right; // and continue } else { // case 5: lo = n->_right->high(); ++lo; > > > >Kind regards > >Jose M Calhariz > > > > > > > > > >_______________________________________________ > >Xorp-users mailing list > >Xorp-users at xorp.org > >http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-users > > > > -- -- Loteria: acho que, jogando ou n?o, voc? tem a mesma chance de ganhar. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: Digital signature Url : http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-users/attachments/20160708/4b06d229/attachment.bin From jose.calhariz at tecnico.ulisboa.pt Fri Jul 8 08:38:52 2016 From: jose.calhariz at tecnico.ulisboa.pt (Jose M Calhariz) Date: Fri, 8 Jul 2016 16:38:52 +0100 Subject: [Xorp-users] Beta testers for new debian package of xorp In-Reply-To: <20160708095410.GA6538@calhariz.com> References: <20160703110831.GA20403@calhariz.com> <5778F664.7020600@candelatech.com> <20160708095410.GA6538@calhariz.com> Message-ID: <20160708153852.GA21710@calhariz.com> -rOn Fri, Jul 08, 2016 at 10:54:19AM +0100, Jose M Calhariz wrote: > On Sun, Jul 03, 2016 at 04:26:28AM -0700, Ben Greear wrote: > > On 07/03/2016 04:08 AM, Jose M Calhariz wrote: > > > > > >I am preparing a new Debian package for xorp. This new version have > > >hardening turned on and is from the lastest code on git. I am > > >requesting beta testers to check that is OK, because I can no longer > > >test it, before uploading the result to Debian. Send a private email > > >to me and I can provide with the source code of the package or a > > >compiled package for i386 and amd64 for any version of Debian. > > > > If you made any code changes, please post patches. > > > > Thanks, > > Ben > > > > The g++ 6.x compiler now barks at this function: > > Index: xorp-1.8.6~wip.20160217/rip/output.hh > =================================================================== > --- xorp-1.8.6~wip.20160217.orig/rip/output.hh 2016-07-07 > 20:38:44.732183207 +0100 > +++ xorp-1.8.6~wip.20160217/rip/output.hh 2016-07-07 > 20:39:52.281766177 +0100 > @@ -97,7 +97,7 @@ public: > /** > * Get number of packets placed on packet queue for output. > */ > - void packets_sent() const { > return _pkts_out; } > + void packets_sent() const { > return; } > > protected: > /** > > > And I am guessing this fix is needed: > > Index: xorp-1.8.6~wip.20160217/libxorp/trie.hh > =================================================================== > --- xorp-1.8.6~wip.20160217.orig/libxorp/trie.hh 2013-08-14 19:35:45.000000000 +0100 > +++ xorp-1.8.6~wip.20160217/libxorp/trie.hh 2016-07-08 10:38:54.943000432 +0100 > @@ -244,8 +244,9 @@ public: > lo = x->high(); ++lo; > hi = n->_right->low(); --hi; > } else if (a <= n->_right->_k.top_addr()) { // case 4: > - if (n->_left && a > n->_left->_k.top_addr()) > + if (n->_left && a > n->_left->_k.top_addr()) { > lo = n->_left->high(); ++lo; > + } > n = n->_right; // and continue > } else { // case 5: > lo = n->_right->high(); ++lo; > > > Another problem with indentation: Index: xorp-1.8.6~wip.20160217/bgp/route_table_ribin.cc =================================================================== --- xorp-1.8.6~wip.20160217.orig/bgp/route_table_ribin.cc 2013-08-14 19:35:44.000000000 +0100 +++ xorp-1.8.6~wip.20160217/bgp/route_table_ribin.cc 2016-07-08 12:17:57.135488124 +0100 @@ -299,7 +299,7 @@ RibInTable::lookup_route(const IPNet< return &(iter.payload()); } else fpa_list_ref = NULL; - return NULL; + return NULL; } template > > > > > >Kind regards > > >Jose M Calhariz > > > > > > > > > > > > > > >_______________________________________________ > > >Xorp-users mailing list > > >Xorp-users at xorp.org > > >http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-users > > > > > > > > Kind regards Jose M Calhariz -- -- O homem que tem uma lingua, eu digo, n?o e homem, se com sua l?ngua ele n?o consegue conquistar o amor de uma mulher. -- William Shakespeare -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: Digital signature Url : http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-users/attachments/20160708/380c9243/attachment.bin From greearb at candelatech.com Fri Jul 8 15:49:03 2016 From: greearb at candelatech.com (Ben Greear) Date: Fri, 8 Jul 2016 15:49:03 -0700 Subject: [Xorp-users] Beta testers for new debian package of xorp In-Reply-To: <20160708095410.GA6538@calhariz.com> References: <20160703110831.GA20403@calhariz.com> <5778F664.7020600@candelatech.com> <20160708095410.GA6538@calhariz.com> Message-ID: <57802DDF.8000405@candelatech.com> On 07/08/2016 02:54 AM, Jose M Calhariz wrote: > On Sun, Jul 03, 2016 at 04:26:28AM -0700, Ben Greear wrote: >> On 07/03/2016 04:08 AM, Jose M Calhariz wrote: >>> >>> I am preparing a new Debian package for xorp. This new version have >>> hardening turned on and is from the lastest code on git. I am >>> requesting beta testers to check that is OK, because I can no longer >>> test it, before uploading the result to Debian. Send a private email >>> to me and I can provide with the source code of the package or a >>> compiled package for i386 and amd64 for any version of Debian. >> >> If you made any code changes, please post patches. >> >> Thanks, >> Ben >> > > The g++ 6.x compiler now barks at this function: > > Index: xorp-1.8.6~wip.20160217/rip/output.hh > =================================================================== > --- xorp-1.8.6~wip.20160217.orig/rip/output.hh 2016-07-07 > 20:38:44.732183207 +0100 > +++ xorp-1.8.6~wip.20160217/rip/output.hh 2016-07-07 > 20:39:52.281766177 +0100 > @@ -97,7 +97,7 @@ public: > /** > * Get number of packets placed on packet queue for output. > */ > - void packets_sent() const { > return _pkts_out; } > + void packets_sent() const { > return; } > > protected: > /** > > > And I am guessing this fix is needed: > > Index: xorp-1.8.6~wip.20160217/libxorp/trie.hh > =================================================================== > --- xorp-1.8.6~wip.20160217.orig/libxorp/trie.hh 2013-08-14 19:35:45.000000000 +0100 > +++ xorp-1.8.6~wip.20160217/libxorp/trie.hh 2016-07-08 10:38:54.943000432 +0100 > @@ -244,8 +244,9 @@ public: > lo = x->high(); ++lo; > hi = n->_right->low(); --hi; > } else if (a <= n->_right->_k.top_addr()) { // case 4: > - if (n->_left && a > n->_left->_k.top_addr()) > + if (n->_left && a > n->_left->_k.top_addr()) { > lo = n->_left->high(); ++lo; > + } > n = n->_right; // and continue > } else { // case 5: > lo = n->_right->high(); ++lo; I applied similar fixes and pushed it to xorp. Please try again and let me know if there are more warnings. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com From jose.calhariz at tecnico.ulisboa.pt Sat Jul 9 08:59:13 2016 From: jose.calhariz at tecnico.ulisboa.pt (Jose M Calhariz) Date: Sat, 9 Jul 2016 16:59:13 +0100 Subject: [Xorp-users] Beta testers for new debian package of xorp In-Reply-To: <57802DDF.8000405@candelatech.com> References: <20160703110831.GA20403@calhariz.com> <5778F664.7020600@candelatech.com> <20160708095410.GA6538@calhariz.com> <57802DDF.8000405@candelatech.com> Message-ID: <20160709155913.GA3706@calhariz.com> On Fri, Jul 08, 2016 at 03:49:03PM -0700, Ben Greear wrote: > On 07/08/2016 02:54 AM, Jose M Calhariz wrote: > >On Sun, Jul 03, 2016 at 04:26:28AM -0700, Ben Greear wrote: > >>On 07/03/2016 04:08 AM, Jose M Calhariz wrote: > >>> > >>>I am preparing a new Debian package for xorp. This new version have > >>>hardening turned on and is from the lastest code on git. I am > >>>requesting beta testers to check that is OK, because I can no longer > >>>test it, before uploading the result to Debian. Send a private email > >>>to me and I can provide with the source code of the package or a > >>>compiled package for i386 and amd64 for any version of Debian. > >> > >>If you made any code changes, please post patches. > >> > >>Thanks, > >>Ben > >> > > > >The g++ 6.x compiler now barks at this function: > > > >Index: xorp-1.8.6~wip.20160217/rip/output.hh > >=================================================================== > >--- xorp-1.8.6~wip.20160217.orig/rip/output.hh 2016-07-07 > >20:38:44.732183207 +0100 > >+++ xorp-1.8.6~wip.20160217/rip/output.hh 2016-07-07 > >20:39:52.281766177 +0100 > >@@ -97,7 +97,7 @@ public: > > /** > > * Get number of packets placed on packet queue for output. > > */ > >- void packets_sent() const { > > return _pkts_out; } > >+ void packets_sent() const { > > return; } > > > > protected: > > /** > > > > > >And I am guessing this fix is needed: > > > >Index: xorp-1.8.6~wip.20160217/libxorp/trie.hh > >=================================================================== > >--- xorp-1.8.6~wip.20160217.orig/libxorp/trie.hh 2013-08-14 19:35:45.000000000 +0100 > >+++ xorp-1.8.6~wip.20160217/libxorp/trie.hh 2016-07-08 10:38:54.943000432 +0100 > >@@ -244,8 +244,9 @@ public: > > lo = x->high(); ++lo; > > hi = n->_right->low(); --hi; > > } else if (a <= n->_right->_k.top_addr()) { // case 4: > >- if (n->_left && a > n->_left->_k.top_addr()) > >+ if (n->_left && a > n->_left->_k.top_addr()) { > > lo = n->_left->high(); ++lo; > >+ } > > n = n->_right; // and continue > > } else { // case 5: > > lo = n->_right->high(); ++lo; > > I applied similar fixes and pushed it to xorp. Please try again and let me know > if there are more warnings. Yes, there is still need a third patch. It is on my previous email. > > Thanks, > Ben > Kind regards Jose M Calhariz -- -- Minha maior extravag?ncia ? ser ministro da Economia --Marc?lio Marques Moreira -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: Digital signature Url : http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-users/attachments/20160709/7da8c900/attachment.bin From greearb at candelatech.com Mon Jul 11 10:06:32 2016 From: greearb at candelatech.com (Ben Greear) Date: Mon, 11 Jul 2016 10:06:32 -0700 Subject: [Xorp-users] Beta testers for new debian package of xorp In-Reply-To: <20160709155913.GA3706@calhariz.com> References: <20160703110831.GA20403@calhariz.com> <5778F664.7020600@candelatech.com> <20160708095410.GA6538@calhariz.com> <57802DDF.8000405@candelatech.com> <20160709155913.GA3706@calhariz.com> Message-ID: <5783D218.5040806@candelatech.com> On 07/09/2016 08:59 AM, Jose M Calhariz wrote: >> I applied similar fixes and pushed it to xorp. Please try again and let me know >> if there are more warnings. > > Yes, there is still need a third patch. It is on my previous email. Can you resend that patch? I cannot find it in my email. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com From jose.calhariz at tecnico.ulisboa.pt Thu Jul 14 06:09:33 2016 From: jose.calhariz at tecnico.ulisboa.pt (Jose M Calhariz) Date: Thu, 14 Jul 2016 14:09:33 +0100 Subject: [Xorp-users] Beta testers for new debian package of xorp In-Reply-To: <5783D218.5040806@candelatech.com> References: <20160703110831.GA20403@calhariz.com> <5778F664.7020600@candelatech.com> <20160708095410.GA6538@calhariz.com> <57802DDF.8000405@candelatech.com> <20160709155913.GA3706@calhariz.com> <5783D218.5040806@candelatech.com> Message-ID: <20160714130933.GA23252@calhariz.com> On Mon, Jul 11, 2016 at 10:06:32AM -0700, Ben Greear wrote: > > > On 07/09/2016 08:59 AM, Jose M Calhariz wrote: > > >>I applied similar fixes and pushed it to xorp. Please try again and let me know > >>if there are more warnings. > > > >Yes, there is still need a third patch. It is on my previous email. > > Can you resend that patch? I cannot find it in my email. > > Thanks, > Ben > > In attach is the third patch. Kind regards Jose M Calhariz -- -- As pessoas mudam atrav?s do que alcan?am --Wystan Hugh Auden -------------- next part -------------- Subject: Fix missleading indentation From: Jose M Calhariz Index: xorp-1.8.6~wip.20160217/bgp/route_table_ribin.cc =================================================================== --- xorp-1.8.6~wip.20160217.orig/bgp/route_table_ribin.cc 2013-08-14 19:35:44.000000000 +0100 +++ xorp-1.8.6~wip.20160217/bgp/route_table_ribin.cc 2016-07-08 12:17:57.135488124 +0100 @@ -299,7 +299,7 @@ RibInTable ::lookup_route(const IPNet< return &(iter.payload()); } else fpa_list_ref = NULL; - return NULL; + return NULL; } template -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: Digital signature Url : http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-users/attachments/20160714/2133c7c5/attachment.bin From greearb at candelatech.com Fri Jul 15 08:24:24 2016 From: greearb at candelatech.com (Ben Greear) Date: Fri, 15 Jul 2016 08:24:24 -0700 Subject: [Xorp-users] Beta testers for new debian package of xorp In-Reply-To: <20160714130933.GA23252@calhariz.com> References: <20160703110831.GA20403@calhariz.com> <5778F664.7020600@candelatech.com> <20160708095410.GA6538@calhariz.com> <57802DDF.8000405@candelatech.com> <20160709155913.GA3706@calhariz.com> <5783D218.5040806@candelatech.com> <20160714130933.GA23252@calhariz.com> Message-ID: <57890028.4010501@candelatech.com> On 07/14/2016 06:09 AM, Jose M Calhariz wrote: > On Mon, Jul 11, 2016 at 10:06:32AM -0700, Ben Greear wrote: >> >> >> On 07/09/2016 08:59 AM, Jose M Calhariz wrote: >> >>>> I applied similar fixes and pushed it to xorp. Please try again and let me know >>>> if there are more warnings. >>> >>> Yes, there is still need a third patch. It is on my previous email. >> >> Can you resend that patch? I cannot find it in my email. >> >> Thanks, >> Ben >> >> > > In attach is the third patch. I fixed it slightly differently. In the future, please include a 'Signed-off-by' in your patches so that I can directly apply them. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com