[Xorp-users] Beta testers for new debian package of xorp

[Jose M Calhariz]

On Sun, Jul 03, 2016 at 04:26:28AM -0700, Ben Greear wrote:
> On 07/03/2016 04:08 AM, Jose M Calhariz wrote:
> >
> >I am preparing a new Debian package for xorp.  This new version have
> >hardening turned on and is from the lastest code on git.  I am
> >requesting beta testers to check that is OK, because I can no longer
> >test it, before uploading the result to Debian.  Send a private email
> >to me and I can provide with the source code of the package or a
> >compiled package for i386 and amd64 for any version of Debian.
> 
> If you made any code changes, please post patches.
> 
> Thanks,
> Ben
> 

The g++ 6.x compiler now barks at this function:

Index: xorp-1.8.6~wip.20160217/rip/output.hh
===================================================================
--- xorp-1.8.6~wip.20160217.orig/rip/output.hh  2016-07-07
20:38:44.732183207 +0100
+++ xorp-1.8.6~wip.20160217/rip/output.hh       2016-07-07
20:39:52.281766177 +0100
@@ -97,7 +97,7 @@ public:
     /**
     * Get number of packets placed on packet queue for output.
     */
-    void packets_sent() const                 {
     return _pkts_out; }
+    void packets_sent() const                 {
     return; }

 protected:
      /**
      

And I am guessing this fix is needed:

Index: xorp-1.8.6~wip.20160217/libxorp/trie.hh
===================================================================
--- xorp-1.8.6~wip.20160217.orig/libxorp/trie.hh	2013-08-14 19:35:45.000000000 +0100
+++ xorp-1.8.6~wip.20160217/libxorp/trie.hh	2016-07-08 10:38:54.943000432 +0100
@@ -244,8 +244,9 @@ public:
 		lo = x->high(); ++lo;
 		hi = n->_right->low(); --hi;
 	    } else if (a <= n->_right->_k.top_addr()) {	// case 4:
-		if (n->_left && a > n->_left->_k.top_addr())
+		if (n->_left && a > n->_left->_k.top_addr()) {
 		    lo = n->_left->high(); ++lo;
+		}
 		n = n->_right; // and continue
 	    } else {					// case 5:
 		lo = n->_right->high(); ++lo;



> >
> >Kind regards
> >Jose M Calhariz
> >
> >
> >
> >
> >_______________________________________________
> >Xorp-users mailing list
> >Xorp-users at xorp.org
> >http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-users
> >
> 
> 

-- 
--
Loteria: acho que, jogando ou não, você tem a mesma chance de ganhar.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
Url : http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-users/attachments/20160708/4b06d229/attachment.bin