[Bro-Dev] #289: Crash in broctl due to missing lockfile.

Bro Tracker bro-dev at bro-ids.org
Mon Nov 15 13:47:03 PST 2010


#289: Crash in broctl due to missing lockfile.
-------------------------+--------------------------------------------------
  Reporter:  seth        |       Owner:  robin 
      Type:  Patch       |      Status:  new   
  Priority:  Normal      |   Milestone:  Bro1.6
 Component:  BroControl  |     Version:  1.5.2 
Resolution:              |    Keywords:        
-------------------------+--------------------------------------------------
Changes (by seth):

  * type:  Problem => Patch
  * milestone:  => Bro1.6


Comment:

 This is a patch to avoid the crash.  IOError handles a problem with "open"
 failing and OSError handles problems with os.unlink failing.

 {{{

 Index: util.py
 ===================================================================
 --- util.py     (revision 7072)
 +++ util.py     (working copy)
 @@ -102,7 +102,7 @@
          os.unlink(config.Config.lockfile)
          return True

 -    except IOError:
 +    except (OSError, IOError):
          return False

  def _aquireLock():
 }}}

-- 
Ticket URL: <http://tracker.icir.org/bro/ticket/289#comment:2>
Bro Tracker <http://tracker.icir.org/bro>
Bro Issue Tracker




More information about the bro-dev mailing list