[Bro-Dev] #315: TCP Reassemblier type inconsistency

Bro Tracker bro at tracker.icir.org
Mon Nov 22 11:48:06 PST 2010


#315: TCP Reassemblier type inconsistency
----------------------+------------------------
 Reporter:  gregor    |      Owner:
     Type:  Problem   |     Status:  new
 Priority:  Low       |  Milestone:
Component:  Bro       |    Version:  git/master
 Keywords:  inttypes  |
----------------------+------------------------
 {{{
 #!rst

 The TCP Reassembler (and the general Reassembler which is the base class)
 have a type inconsitency:

 internally they define the sequence numbers as ``int``. When they have to
 compare seq numbers, they call ``seq_delta()`` which takes two ``uint32``.

 The reassemblers should also use ``uint32_t`` internally.

 }}}

-- 
Ticket URL: <http://tracker.icir.org/bro/ticket/315>
Bro Tracker <http://tracker.icir.org/bro>
Bro Issue Tracker




More information about the bro-dev mailing list