[Bro-Dev] #474: &raw_output turns null values into \0

Bro Tracker bro at tracker.bro-ids.org
Wed Aug 3 19:47:43 PDT 2011


#474: &raw_output turns null values into \0
----------------------------+------------------------
  Reporter:  seth           |      Owner:  jsiwek
      Type:  Merge Request  |     Status:  assigned
  Priority:  Normal         |  Milestone:  Bro1.6
 Component:  Bro            |    Version:  git/master
Resolution:                 |   Keywords:  preview
----------------------------+------------------------

Comment (by jsiwek):

 Replying to [comment:4 robin]:
 > > (Re)Assigning to identifiers with the &raw_output attribute should
 also
 > > now correctly apply the attribute to the file value being assigned.
 >
 > Can we leave this part out and use the enable_raw_output() function
 instead?

 Yeah.  Besides &raw_output, there's &encrypt, &disable_print_hook,
 &rotate_interval, and &rotate_size that `BroFile` is supposed to know
 about, but in most cases won't work because they don't get transferred
 from the identifier to assigned values.  Would it be better to remove them
 all and just provide equivalent BIFs for ones that don't already have
 them?

 > That's just the part in NameExpr, correct?

 I had the test for &raw_output in language/raw_output_attr.test (the test
 for the BIF was in the bif/ dir)

-- 
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/474#comment:7>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker



More information about the bro-dev mailing list