[Bro-Dev] #545: More script reorg fallout

[Bro Tracker]

#545: More script reorg fallout
----------------------+------------------------
  Reporter:  jsiwek   |      Owner:
      Type:  Problem  |     Status:  new
  Priority:  Normal   |  Milestone:  Bro1.6
 Component:  Bro      |    Version:  git/master
Resolution:           |   Keywords:
----------------------+------------------------

Comment (by seth):

 > - in general, it seems scripts may be leaving out `@load` directives
 based
 > on the assumption that everything in the `base/` directory is loaded by
 > default.  Scripts should always explicitly `@load` all dependencies as
 > that will be more pleasant for a user trying to run with `--bare-mode`
 > enabled.

 Yes, I left that out with an eye toward discussing it a bit more.  Do you
 think scripts within the base/ directory should do relative loading or
 they should be doing full path loading?  I suppose it doesn't matter in
 any real sense, but I feel like we may run into side effect going with one
 way compared to another.  Presumably the scripts in policy/ would be doing
 full path loading, but that suddenly makes leaving base/ out of the path a
 little nasty because people are going to end up prepending that to most of
 the @loads they do.

 > - the `testing/btest/policy` directory should be renamed/reorganized
 > according to the new script organization

 Agreed.

 > - the `policy/misc/testing-coverage.bro` unit test is falsely succeeding

 I'd rather that worked the way to propose anyway.

 > - the `make restdoc` target should also enable `--bare-mode` for
 creating
 > documentation for individual scripts


 Good point.

-- 
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/545#comment:0>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker