[Bro-Dev] [Bro-Commits] [git/bro] master: Updates for SSH scripts. (9c2273b)

[Gregor Maier]

On 8/11/11 8:39 , Seth Hall wrote:
>
> On Aug 11, 2011, at 11:22 AM, Gregor Maier wrote:
>
>>> +##! Requires that :bro:id:`use_conn_size_analyzer` is set to T!  The heuristic
>>> +##! is not attempted if the connection size analyzer isn't enabled.
>>
>> I looks like the code doesn't check yet, whether use_conn_size_analyzer is indeed on (or better, it should probably check
>> c$resp?$num_ip_bytes, since num_ip_bytes is optional.
>
>
> It actually does that check further down in the file when the ssh_watcher event is initially scheduled. :)

But you call check_ssh_connection() form connection_state_remove() as 
well and then you don't check.

cu
Gregor
-- 
Gregor Maier
<gregor at icir.org>  <gregor at icsi.berkeley.edu>
Int. Computer Science Institute (ICSI)
1947 Center St., Ste. 600
Berkeley, CA 94704, USA
http://www.icir.org/gregor/