[Bro-Dev] #712: LogMgr should escape the set separator

Bro Tracker bro at tracker.bro-ids.org
Wed Dec 7 07:51:57 PST 2011


#712: LogMgr should escape the set separator
----------------------+------------------------
  Reporter:  amannb   |      Owner:  jsiwek
      Type:  Problem  |     Status:  assigned
  Priority:  Normal   |  Milestone:  Bro2.0
 Component:  Bro      |    Version:  git/master
Resolution:           |   Keywords:
----------------------+------------------------

Comment (by jsiwek):

 > > 1) I think it makes sense to limit the escaping of set_separator to
 only data contained within a set/table/vector field?  Any reason to go
 beyond that?
 >
 > My answer would be "yes" except that I'm not quite sure what "beyond"
 might be?

 I just meant that if there's a field that's a plain string type, it
 doesn't seem necessary to escape the set_separator if it appears in any
 values.  The ambiguity could only occur in fields that are
 vector/set/table types.

 > > 2) Is there a reason why set_separator isn't included in the ascii log
 header like 'separator' is?  Seems like you'll want that added?
 >
 > That's an oversight, same for the other missing options from
 `logging/writers/ascii`. Please add.

 Ok. Think header_prefix can still be omitted since it's implicitly the
 string of characters before the first instance of "separator"?

-- 
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/712#comment:4>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker



More information about the bro-dev mailing list