[Bro-Dev] [Bro-Commits] [git/bro] topic/seth/dns-updates: Fixed some bugs with capturing data in the base DNS script. (04e2773)

Seth Hall seth at icir.org
Thu Dec 8 11:20:09 PST 2011


On Dec 8, 2011, at 1:15 PM, Matthias Vallentin wrote:

>> @@ -140,15 +140,11 @@ event DNS::do_reply(c: connection, msg: dns_msg, ans: dns_answer, reply: string)
> 
> What is the reason for the DNS:: namespace of the event handler? I
> looks like it could be removed, since the file specifies "module DNS"
> at the top already without changing that before do_reply again.


If I remember correctly there is a bug (or feature?) with handling non-global events where they always need to be fully scoped.  Normally, people don't see this (and the reason the bug is there) because all of the core generated events are in the GLOBAL namespace.

  .Seth

--
Seth Hall
International Computer Science Institute
(Bro) because everyone has a network
http://www.bro-ids.org/




More information about the bro-dev mailing list