[Bro-Dev] #712: LogMgr should escape the set separator

Bro Tracker bro at tracker.bro-ids.org
Sun Dec 18 16:42:29 PST 2011


#712: LogMgr should escape the set separator
----------------------------+------------------------
  Reporter:  amannb         |      Owner:  jsiwek
      Type:  Merge Request  |     Status:  assigned
  Priority:  Normal         |  Milestone:  Bro2.0
 Component:  Bro            |    Version:  git/master
Resolution:                 |   Keywords:
----------------------------+------------------------

Comment (by robin):

 Allowing multiple escape strings is the right thing to do, thanks! What
 worries me a bit however is that this might all get quite expensive CPU-
 wise: the code now needs to search for all escape strings each time
 something's written out, and it also needs register/deregister the escape
 strings as it traverses the log data structures. It's fine for now, but
 eventually we may want to profile this and see if something can be
 improved (on the other hand, once logging is done in threads, this will
 matter much less).

 One other nit: why do the new header lines (`#empty_field` etc.) always
 escape everything? Would be more readable if only printable characters
 were printed as is.

 I'm going to merge this and then close the ticket.

-- 
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/712#comment:8>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker



More information about the bro-dev mailing list