[Bro-Dev] #712: LogMgr should escape the set separator

Bro Tracker bro at tracker.bro-ids.org
Mon Dec 19 08:08:45 PST 2011


#712: LogMgr should escape the set separator
----------------------------+------------------------
  Reporter:  amannb         |      Owner:  jsiwek
      Type:  Merge Request  |     Status:  assigned
  Priority:  Normal         |  Milestone:  Bro2.0
 Component:  Bro            |    Version:  git/master
Resolution:                 |   Keywords:
----------------------------+------------------------

Comment (by jsiwek):

 > Allowing multiple escape strings is the right thing to do, thanks! What
 worries me a bit however is that this might all get quite expensive CPU-
 wise

 I was a bit concerned about that, too.

 > One other nit: why do the new header lines (`#empty_field` etc.) always
 escape everything? Would be more readable if only printable characters
 were printed as is.

 I was mostly just following the example set by `#separator` which is
 always fully escaped.  I guess it's a bit weird since space is considered
 a printing character, but we need to escape it.  And maybe consistently
 escaping everything makes it a bit easier for log-consuming programs.

-- 
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/712#comment:9>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker



More information about the bro-dev mailing list