[Bro-Dev] RecordType::Init dead code

Siwek, Jonathan Luke jsiwek at illinois.edu
Mon Dec 19 09:43:20 PST 2011


I was exploring the internals of records and noticed in RecordType::Init that there's an "assert(false)".  Is this dead code that can be removed?

Removing it would also involve removing the RecordField class, the "fields" and "base" members of RecordType, the two-arg RecordType ctor, and the "refined_type" rule from the parser (used in type and event declarations).  What was the use for this "refined" record type?

I already experimented with removing all that stuff with all unit tests passing, want me to commit it so it can get merged?

+Jon


More information about the bro-dev mailing list