[Bro-Dev] #405: Broccoli's `make install` may clobber existing user-modified broccoli.conf

[Bro Tracker]

#405: Broccoli's `make install` may clobber existing user-modified broccoli.conf
-----------------------+------------------------
  Reporter:  jsiwek    |      Owner:  jsiwek
      Type:  Problem   |     Status:  new
  Priority:  Normal    |  Milestone:  Bro1.6
 Component:  Broccoli  |    Version:  git/master
Resolution:            |   Keywords:
-----------------------+------------------------

Comment (by jsiwek):

 > But I'll also see if the "check for existing $PREFIX/etc/broccoli.conf
 at make install time" solution really did have other issues (like I said I
 couldn't remember above).

 The other issue with this was that it is incompatible with packaging via
 CPack.  In order for CPack to create binary packages correctly, the files
 to be installed need to be specified inside a typical CMake install()
 macro, but that's not scriptable at `make install` time.  The fix is to
 require a configure time flag, `--binary-package`, to know when to use
 extra "scripted" install versus use the plain install().

 `topic/jsiwek/config-file-clobber-fixes` branches now exist in the
 broccoli, broctl, and bro repositories with the changes listed in the
 previous comment.

 Craig, if you try out at least the broccoli one, let me know if it looks
 good and I'll send a request to merge them to master.

-- 
Ticket URL: <http://tracker.icir.org/bro/ticket/405#comment:5>
Bro Tracker <http://tracker.icir.org/bro>
Bro Issue Tracker