[Bro-Dev] #272: topic/seth/strings-without-checkstring - Use Bytes() and Len() instead of CheckString() in strings.bif

Bro Tracker bro at tracker.icir.org
Thu Jan 20 14:35:46 PST 2011


#272: topic/seth/strings-without-checkstring - Use Bytes() and Len() instead of
CheckString() in strings.bif
----------------------------+----------------------
  Reporter:  seth           |      Owner:  seth
      Type:  Merge Request  |     Status:  assigned
  Priority:  Normal         |  Milestone:  Bro1.6
 Component:  Bro            |    Version:  1.5.2
Resolution:                 |   Keywords:  sprint
----------------------------+----------------------

Comment (by robin):

 I've added a few smaller tweaks to the branch but I have trouble following
 do_split() (well, that's true for the original version as well). One
 question: In the inner loop with MatchPrefix(), n is decreased, but it's
 never reset later. Is that right? (offset is reset to zero at the
 beginning of the outer loop.).

 Also, I've added a check to  strip(), please check.

-- 
Ticket URL: <http://tracker.icir.org/bro/ticket/272#comment:10>
Bro Tracker <http://tracker.icir.org/bro>
Bro Issue Tracker



More information about the bro-dev mailing list