[Bro-Dev] #297: Remove trace rewriter
Bro Tracker
bro at tracker.icir.org
Thu Mar 17 09:34:31 PDT 2011
#297: Remove trace rewriter
---------------------+---------------------
Reporter: seth | Owner: robin
Type: Task | Status: testing
Priority: Normal | Milestone: Bro1.6
Component: Bro | Version:
Resolution: | Keywords: cleanup
---------------------+---------------------
Comment (by robin):
> I don't quite understand the comment about "probably be quite
> impractical". Why is that?
The problem is that with the scripts changing a lot, a simple patch
doesn't really work: if it just adds the rewriting-specific parts to
the new code, that is unlikely to work in any reasonable way due to
the restructuring of logic and data structures. A patch that gets us
back to the current functionality would essentially need to revert all
the scripts changes and go back to their old versions.
What I could see is:
(1) we create a patch that re-adds all the old versions of the
scripts in a separate directory, like "old-for-rewriting".
(2) our patch does actually not add rewriting to 1.6, but
*removes* rewriting from 1.5. Rewriting is already not working
correctly in 1.5, and I think the orginal idea was mainly to have
reference of the code as it used to be. Having the remove-from-1.5
patch can play that role too. Anybody who actually wants to use it
with 1.6 needs to invest quite a bit work anyway.
--
Ticket URL: <http://tracker.icir.org/bro/ticket/297#comment:10>
Bro Tracker <http://tracker.icir.org/bro>
Bro Issue Tracker
More information about the bro-dev
mailing list