[Bro-Dev] #636: topic/jsiwek/comphash-func-determinism
Bro Tracker
bro at tracker.bro-ids.org
Wed Oct 5 16:46:41 PDT 2011
#636: topic/jsiwek/comphash-func-determinism
----------------------------+------------------------
Reporter: jsiwek | Owner: jsiwek
Type: Merge Request | Status: assigned
Priority: Normal | Milestone:
Component: Bro | Version: git/master
Resolution: | Keywords:
----------------------------+------------------------
Changes (by robin):
* owner: => jsiwek
* status: new => assigned
Comment:
Don't really like this patch I have to say.
- I don't like assigning the unique names to anonymous functions, with
them then printing like
{{{anonymous-function3 { return ((Notice::n$note in
Notice::alarmed_types)); }}}}
- More generally,assigning dummy names seems like overkill to me just to
achieve consistent output for testing. Doesn't the earlier suggestion work
to hash the functions Describe() output when in seeded-hash mode?
- Is the is_singelton case correct in the following? I don't see the
distinction
made when the hash is created?
{{{
if ( is_singleton )
{
kp1 = kp0;
n = k->Size();
}
else
{
const int* const kp = AlignType<int>(kp0);
n = *kp;
kp1 = reinterpret_cast<const char*>(kp+1);
}
string name(kp1, n);
}}}
--
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/636#comment:1>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker
More information about the bro-dev
mailing list